Skip to content

feat: Support rich parameters in autobuilds - #5916

Merged
mtojek merged 1 commit into
coder:mainfrom
mtojek:5574-support-autostart
Jan 30, 2023
Merged

mtojek merged 1 commit into
coder:mainfrom
mtojek:5574-support-autostart

Conversation

@mtojek

@mtojek mtojek commented Jan 30, 2023

Copy link
Copy Markdown
Member

Related: #5574

This PR enables support for rich parameters in autobuilds. I didn't notice that the build logic is duplicated.

@mtojek mtojek self-assigned this Jan 30, 2023
@mtojek mtojek mentioned this pull request Jan 30, 2023
@mtojek
mtojek force-pushed the 5574-support-autostart branch from 6fcf970 to 5954844 Compare January 30, 2023 12:31
@mtojek
mtojek requested review from johnstcn and kylecarbs January 30, 2023 12:31
@mtojek
mtojek marked this pull request as ready for review January 30, 2023 12:32
}
return nil

return store.InTx(func(db database.Store) error {

@johnstcn johnstcn Jan 30, 2023 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is strictly necessary as each workspace is processed in its own transaction (see #L132)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rather thinking about the case when it inserts a record to the workspace table, but it fails to insert parameters for some reason. In this case, it's better to rollback the entire transaction.

@mtojek
mtojek merged commit 23176bf into coder:main Jan 30, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 30, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants