Skip to content

fix(site): Hide agent lifecycle unless opted in via delay_login_until_ready - #5850

Merged
mafredri merged 3 commits into
mainfrom
mafredri/fix-hide-agent-lifecycle-status-unless-optin
Jan 25, 2023
Merged

mafredri merged 3 commits into
mainfrom
mafredri/fix-hide-agent-lifecycle-status-unless-optin

Conversation

@mafredri

@mafredri mafredri commented Jan 25, 2023 •

Copy link
Copy Markdown
Member

Refs: #5835, #5749

@mafredri
mafredri marked this pull request as ready for review January 25, 2023 10:36

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just check if the screenshots in Chromatic checks are the expected results

@mafredri

Copy link
Copy Markdown
Member Author

Looks good to me. Just check if the screenshots in Chromatic checks are the expected results

@BrunoQuaresma the only changes I see is build progress bar. There are no changes to the agent status and this is what I'd expect since the mocked values have delay_login_until_ready: true.

@BrunoQuaresma

Copy link
Copy Markdown
Contributor

@mafredri I have to fix this on storybook but it looks good to go.

@mafredri
mafredri merged commit 5c5ddc6 into main Jan 25, 2023
@mafredri
mafredri deleted the mafredri/fix-hide-agent-lifecycle-status-unless-optin branch January 25, 2023 13:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants