Repository navigation
fix(site): Hide agent lifecycle unless opted in via delay_login_until_ready - #5850
Merged
mafredri merged 3 commits intoJan 25, 2023
Merged
Conversation
9 of 13 tasks
mafredri
marked this pull request as ready for review
January 25, 2023 10:36
mafredri
commented
Jan 25, 2023
BrunoQuaresma
approved these changes
Jan 25, 2023
BrunoQuaresma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Just check if the screenshots in Chromatic checks are the expected results
Member
Author
@BrunoQuaresma the only changes I see is build progress bar. There are no changes to the agent status and this is what I'd expect since the mocked values have |
Contributor
|
@mafredri I have to fix this on storybook but it looks good to go. |
mafredri
deleted the
mafredri/fix-hide-agent-lifecycle-status-unless-optin
branch
January 25, 2023 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #5835, #5749