Skip to content

feat: Validate workspace build parameters - #5807

Merged
mtojek merged 38 commits into
coder:mainfrom
mtojek:5574-validation-rules
Jan 24, 2023
Merged

mtojek merged 38 commits into
coder:mainfrom
mtojek:5574-validation-rules

Conversation

@mtojek

@mtojek mtojek commented Jan 20, 2023 •

Copy link
Copy Markdown
Member

Related: #5574

This PR enables coder_parameter validation on different levels: CLI, API and Terraform.

Changes:

  • feat: validate rich parameters passed via CLI
  • feat: add validation_error column to use on the CLI, API validation level
  • feat: update terraform-provider-coder to improve validation messages
  • feat: RichParameter's prompt for Options

@mtojek mtojek self-assigned this Jan 20, 2023
@mtojek mtojek mentioned this pull request Jan 20, 2023
@mtojek
mtojek marked this pull request as ready for review January 24, 2023 12:48
@mtojek
mtojek requested a review from kylecarbs January 24, 2023 12:48

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm happy we're using the same validation logic everywhere - should be a nice UX.

@mtojek
mtojek merged commit 26c6952 into coder:main Jan 24, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 24, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants