Skip to content

refactor: User settings page - #5661

Merged
BrunoQuaresma merged 4 commits into
mainfrom
bq/refactor-user-settings-page
Jan 10, 2023
Merged

BrunoQuaresma merged 4 commits into
mainfrom
bq/refactor-user-settings-page

Conversation

@BrunoQuaresma

Copy link
Copy Markdown
Contributor

Update the user settings page to use the same layout as Deployment Settings.

Things to consider:

  • The components are not abstracted yet. I would wait a bit before creating common components. I'm not sure this is the design we want to keep/follow.

Before:
Screen Shot 2023-01-10 at 16 13 29
Screen Shot 2023-01-10 at 16 13 37
Screen Shot 2023-01-10 at 16 13 45

After:
Screen Shot 2023-01-10 at 16 13 56
Screen Shot 2023-01-10 at 16 14 16
Screen Shot 2023-01-10 at 16 14 05

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 10, 2023
@BrunoQuaresma
BrunoQuaresma requested a review from a team as a code owner January 10, 2023 19:21
@BrunoQuaresma
BrunoQuaresma requested review from presleyp and removed request for a team January 10, 2023 19:21

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@BrunoQuaresma
BrunoQuaresma merged commit f5d623f into main Jan 10, 2023
@BrunoQuaresma
BrunoQuaresma deleted the bq/refactor-user-settings-page branch January 10, 2023 20:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants