Skip to content

build: Fix parallelism of make -j build - #5438

Merged
mafredri merged 2 commits into
mainfrom
mafredri/build-fix-makefile-parallelism
Dec 15, 2022
Merged

mafredri merged 2 commits into
mainfrom
mafredri/build-fix-makefile-parallelism

Conversation

@mafredri

Copy link
Copy Markdown
Member

Makefile's aren't my expertise, but it seems like we start multiple instances of sha/zstd. It could potentially result in half-written/corrupted files.

See error in deploy: https://github.com/coder/coder/actions/runs/3705314216/jobs/6279069212

It's apparent we are running multiple instances of sha1 summing here.

@mafredri mafredri self-assigned this Dec 15, 2022
Comment thread Makefile Resolved
Comment thread Makefile Resolved
@mafredri
mafredri merged commit 44c10bb into main Dec 15, 2022
@mafredri
mafredri deleted the mafredri/build-fix-makefile-parallelism branch December 15, 2022 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants