Skip to content

feat: allow http and https listening simultaneously - #5365

Merged
deansheather merged 8 commits into
mainfrom
dean/http-https
Dec 15, 2022
Merged

deansheather merged 8 commits into
mainfrom
dean/http-https

Conversation

@deansheather

@deansheather deansheather commented Dec 9, 2022 •

Copy link
Copy Markdown
Collaborator

Deprecates --address in favor of --http-address and --tls-address.

If --address is set, prints a warning and then copies it's value to --http-address (or --tls-address if --tls-enable is true) and clears the other address.

New default behavior

Default behavior is to listen on HTTP.

If TLS is enabled, Coder will now listen on a HTTP and a HTTPS port. Users can restore the old behavior by using --http-address "" to unset the default.

TODO:

  • Redirect from HTTP to HTTPS (controlled by a flag, on by default)
  • Helm support
  • Manually test helm

Closes #3123

Comment thread cli/deployment/config.go Resolved
@f0ssel
f0ssel removed their request for review December 15, 2022 16:09
@deansheather
deansheather requested a review from a team as a code owner December 15, 2022 16:29
@deansheather
deansheather requested review from BrunoQuaresma and removed request for a team December 15, 2022 16:29
@deansheather
deansheather requested a review from coadler December 15, 2022 17:01
@deansheather
deansheather enabled auto-merge (squash) December 15, 2022 19:56
@deansheather
deansheather enabled auto-merge (squash) December 15, 2022 19:58
@deansheather
deansheather merged commit 31d38d4 into main Dec 15, 2022
@deansheather
deansheather deleted the dean/http-https branch December 15, 2022 20:09
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HTTPS listen address flag

2 participants