Skip to content

fix: Use immutable names for volumes in example templates - #4954

Merged
mafredri merged 4 commits into
mainfrom
mafredri/stable-volume-names-in-templates
Nov 9, 2022
Merged

mafredri merged 4 commits into
mainfrom
mafredri/stable-volume-names-in-templates

Conversation

@mafredri

@mafredri mafredri commented Nov 8, 2022

Copy link
Copy Markdown
Member

This contributes towards #3000, #3386

Related #3409

Revives #3663 (with changes)

I've added a bunch of labels to the docker templates that are nice when needed, but look a bit verbose. Thoughts? Keep them all? Reduce their numbers? Or only keep them in one template?

These changes also mean that it should be safe for anyone to update their templates to the latest version as long as they keep the lifecycle blocks (thanks @ammario for that tip).

@kylecarbs

Copy link
Copy Markdown
Member

I've added a bunch of labels to the docker templates that are nice when needed, but look a bit verbose. Thoughts? Keep them all? Reduce their numbers? Or only keep them in one template?

I like the labels!

Comment thread docs/templates.md
name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"
name = "coder-${data.coder_workspace.me.id}-home"
lifecycle {
ignore_changes = all

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should put a comment about what this means

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it, but this section begins with a link that explains it in greater detail.

If you think it’s good even considering this I don’t mind adding it (my thinking was that keeping the doc more focused/short here was better).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind, I didn't see the link 👍

@mafredri
mafredri merged commit ed7de90 into main Nov 9, 2022
@mafredri
mafredri deleted the mafredri/stable-volume-names-in-templates branch November 9, 2022 14:18
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants