Repository navigation
Support high build time variation in progress bar - #4941
Conversation
kylecarbs
left a comment
There was a problem hiding this comment.
Nothing is required, but I think we could benefit from moving more to the BE.
| ) | ||
|
|
||
| func TestLoadTest(t *testing.T) { | ||
| t.Skipf("This test is flakey. See https://github.com/coder/coder/issues/4942") |
There was a problem hiding this comment.
I already disabled the flakey test in another PR.
| // If variation is too high (and greater than second), don't show | ||
| // progress bar and give range. | ||
| const highVariation = stddev / median > 0.1 && highGuess - lowGuess > 1 |
There was a problem hiding this comment.
I might do this logic on the backend instead and return simpler API values. In the current format, it's not possible for our CLI to display a progress bar or estimated time remaining without duplicating this logic.
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
|
@kylecarbs — agree it would've been better to add this into the backend, but I want to merge into the frontend for now since it's not the most important work I could be doing. |
Resolves #4676
This PR changes the Progress Bar's behavior so that it shows an estimate range (and no progress slider) when estimate variation is too high.