Repository navigation
chore: Separate the provisionerd server into it's own package - #4940
Merged
Merged
Conversation
This code should be thoroughly tested now that we understand the abstraction. I separated it to make our lives a bit easier for external provisioner daemons as well!
kylecarbs
force-pushed
the
provisionerserver
branch
from
November 7, 2022 23:32
dd9dc1d to
dfa73b3
Compare
kylecarbs
marked this pull request as ready for review
November 8, 2022 00:23
coadler
approved these changes
Nov 8, 2022
Comment on lines
914
to
932
Contributor
There was a problem hiding this comment.
random nit; it feels weird that these are at the bottom
Member
Author
There was a problem hiding this comment.
i had them at the top and it felt weird too... tbh they are weird structs
kylecarbs
force-pushed
the
provisionerserver
branch
from
November 8, 2022 00:36
96f963c to
a57a934
Compare
kylecarbs
enabled auto-merge (squash)
November 8, 2022 00:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code should be thoroughly tested now that we understand the abstraction.
I separated it to make our lives a bit easier for external provisioner daemons as well!