Skip to content

chore: Separate the provisionerd server into it's own package - #4940

Merged
kylecarbs merged 6 commits into
mainfrom
provisionerserver
Nov 8, 2022
Merged

kylecarbs merged 6 commits into
mainfrom
provisionerserver

Conversation

@kylecarbs

@kylecarbs kylecarbs commented Nov 7, 2022 •

Copy link
Copy Markdown
Member

This code should be thoroughly tested now that we understand the abstraction.

I separated it to make our lives a bit easier for external provisioner daemons as well!

  • Add a boatload of tests!

This code should be thoroughly tested now that we understand the abstraction.

I separated it to make our lives a bit easier for external provisioner daemons
as well!
@kylecarbs kylecarbs self-assigned this Nov 7, 2022
@kylecarbs
kylecarbs requested a review from coadler November 8, 2022 00:23
@kylecarbs
kylecarbs marked this pull request as ready for review November 8, 2022 00:23
Comment on lines 914 to 932

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random nit; it feels weird that these are at the bottom

@kylecarbs kylecarbs Nov 8, 2022 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had them at the top and it felt weird too... tbh they are weird structs

@kylecarbs
kylecarbs enabled auto-merge (squash) November 8, 2022 00:45
@kylecarbs
kylecarbs merged commit da05bbb into main Nov 8, 2022
@kylecarbs
kylecarbs deleted the provisionerserver branch November 8, 2022 01:10
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants