Skip to content

feat: change template max_ttl to default_ttl - #4843

Merged
f0ssel merged 18 commits into
mainfrom
f0ssel/remove-min-auto-start
Nov 9, 2022
Merged

f0ssel merged 18 commits into
mainfrom
f0ssel/remove-min-auto-start

Conversation

@f0ssel

@f0ssel f0ssel commented Nov 1, 2022 •

Copy link
Copy Markdown
Member

What this changes:

  • Removal of the "auto-stop max" feature on a template
  • Removal of the "min auto-start interval" - were not seeing value or usage from it and it simplifies the feature to remove it.
  • Addition of an "auto-stop default" feature - any workspaces made the from the template will start with an auto-off of X hours. Users are free to set the auto-off back to 0 or any other value once created.
  • Migration of the auto-stop max value to the new default - I feel this was safe enough since we are moving to a more lax state and I didn't want people to lose their data. Let me know if anyone disagrees with the decision or has suggestions to improve.

image

Closes #4849 - basic behavior has changed
Closes #3304 - this functionality will be provided with the upcoming quotas work
Closes #3811 - No longer relevant to this feature

@f0ssel
f0ssel requested a review from a team as a code owner November 1, 2022 19:42
@f0ssel
f0ssel requested review from Kira-Pilot and removed request for a team November 1, 2022 19:42

@Kira-Pilot Kira-Pilot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE ✅

@f0ssel
f0ssel marked this pull request as draft November 2, 2022 15:42
@f0ssel
f0ssel force-pushed the f0ssel/remove-min-auto-start branch from a2be20c to fe465c5 Compare November 4, 2022 18:57
@f0ssel f0ssel changed the title fix: remove unused min autostart feature feat: change template max_ttl to default_ttl Nov 4, 2022
@f0ssel
f0ssel force-pushed the f0ssel/remove-min-auto-start branch from 1b89889 to ae93fce Compare November 7, 2022 17:33
@f0ssel
f0ssel marked this pull request as ready for review November 7, 2022 22:02
@f0ssel
f0ssel requested review from a team and Kira-Pilot November 8, 2022 15:53

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree with all these decisions

@f0ssel
f0ssel requested a review from kylecarbs November 8, 2022 19:45

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely change!

Comment thread cli/templatecreate.go Resolved
@f0ssel
f0ssel enabled auto-merge (squash) November 9, 2022 18:48
@f0ssel
f0ssel force-pushed the f0ssel/remove-min-auto-start branch from 19a90a7 to f243da4 Compare November 9, 2022 19:13
@f0ssel
f0ssel merged commit d277e28 into main Nov 9, 2022
@f0ssel
f0ssel deleted the f0ssel/remove-min-auto-start branch November 9, 2022 19:36
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Purpose of the auto stop limit? Allow admins to control the max time-until-shutdown Move template schedule controls into enterprise

6 participants