Skip to content

fix: chrome requests hanging over port-forward - #4588

Merged
coadler merged 1 commit into
mainfrom
colin/forward-hang
Oct 17, 2022
Merged

coadler merged 1 commit into
mainfrom
colin/forward-hang

Conversation

@coadler

@coadler coadler commented Oct 17, 2022 •

Copy link
Copy Markdown
Contributor

There was an issue where one side of the connection closing wouldn't exit the bicopy.

Fixes #3733

@coadler coadler self-assigned this Oct 17, 2022

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet we can re-enable the tests after this too! They probably no longer flake.

@ammario

ammario commented Oct 17, 2022

Copy link
Copy Markdown
Member

Big if fixes

@coadler

coadler commented Oct 17, 2022

Copy link
Copy Markdown
Contributor Author

huge

@coadler
coadler force-pushed the colin/forward-hang branch from b98f5f7 to c343177 Compare October 17, 2022 16:18
@coadler
coadler merged commit 29acd25 into main Oct 17, 2022
@coadler
coadler deleted the colin/forward-hang branch October 17, 2022 16:45
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coder port-forward does not work as expected. Requests are hanging

3 participants