Skip to content

feat: Add browser-only connections to Enterprise - #4135

Merged
kylecarbs merged 6 commits into
mainfrom
disablessh
Sep 22, 2022
Merged

kylecarbs merged 6 commits into
mainfrom
disablessh

Conversation

@kylecarbs

@kylecarbs kylecarbs commented Sep 20, 2022 •

Copy link
Copy Markdown
Member

Fixes #4131.

This adds a feature to disable all non-browser connections to Coder. When attempting to SSH, speed test, or port-forward, the following message is printed: "Non-browser connections are disabled for your deployment."

I still have to hide the SSH button in the UI if this is disabled.

@kylecarbs
kylecarbs requested review from bpmct, deansheather and sreya and removed request for deansheather September 20, 2022 18:16

@bpmct bpmct left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna write docs real quick
nvm missed it

@bpmct
bpmct self-requested a review September 20, 2022 18:27

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@kylecarbs
kylecarbs requested a review from a team as a code owner September 20, 2022 19:49
@kylecarbs
kylecarbs requested review from BrunoQuaresma and removed request for a team September 20, 2022 19:49

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE LGTM

@kylecarbs
kylecarbs merged commit 7ad4276 into main Sep 22, 2022
@kylecarbs
kylecarbs deleted the disablessh branch September 22, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enterprise feature: Ability for administrators to disable SSH for groups or site-wide

3 participants