Skip to content

feat: add orphan support - #3849

Merged
ammario merged 17 commits into
mainfrom
orphan
Sep 6, 2022
Merged

ammario merged 17 commits into
mainfrom
orphan

Conversation

@ammario

@ammario ammario commented Sep 2, 2022 •

Copy link
Copy Markdown
Member

Resolves #3844

image

Comment thread codersdk/workspaces.go Resolved
@ammario
ammario requested a review from a team as a code owner September 2, 2022 23:34
@ammario
ammario requested review from BrunoQuaresma and removed request for a team September 2, 2022 23:34
@ammario

ammario commented Sep 2, 2022

Copy link
Copy Markdown
Member Author

@kylecarbs instead of adding a button to the frontend, I'm thinking we add a callout here that shows the command coder rm --orphan {workspace_name} when we're in a Failed Delete state. This way, we can add more explanation and since the command is only advertised in a failed delete state, there's a lower chance of newb misuse.

image

@ammario
ammario requested a review from kylecarbs September 4, 2022 00:18
@ammario

ammario commented Sep 4, 2022

Copy link
Copy Markdown
Member Author

@kylecarbs please take a look.

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE looks good to me

Comment thread cli/delete.go Resolved
Comment thread cli/delete.go Resolved
ammario and others added 2 commits September 6, 2022 11:57
Co-authored-by: Kyle Carberry <kyle@coder.com>
Co-authored-by: Kyle Carberry <kyle@coder.com>
@ammario
ammario enabled auto-merge (squash) September 6, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add workspace force delete

3 participants