Repository navigation
feat: Generate DB unique constraints as enums - #3701
Merged
Merged
Conversation
This fixes a TODO from #3409.
johnstcn
approved these changes
Aug 26, 2022
johnstcn
left a comment
Member
There was a problem hiding this comment.
👍
Noting that this is also possible by querying the postgres catalog, but the downside is then that we can't make those nice comments that show the query where the line was added.
Member
|
Would be nice to somehow combine it with the apitypings/main.go. Like some sort of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a TODO from #3409.
I started out with a bash script, but ultimately I think writing this in Go will be more extensible in the future.
For reference, Bash: