Skip to content

feat: Add emoji picker for template icons - #3601

Merged
BrunoQuaresma merged 8 commits into
mainfrom
bq/add-emoji-picker
Aug 19, 2022
Merged

BrunoQuaresma merged 8 commits into
mainfrom
bq/add-emoji-picker

Conversation

@BrunoQuaresma

Copy link
Copy Markdown
Contributor

Closes #2262

Demo:

Screen.Recording.2022-08-19.at.14.04.40.mov

@BrunoQuaresma
BrunoQuaresma requested a review from a team as a code owner August 19, 2022 17:18
@BrunoQuaresma
BrunoQuaresma requested review from presleyp and removed request for a team August 19, 2022 17:18
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 19, 2022
Comment thread site/src/theme/overrides.ts Resolved
@BrunoQuaresma
BrunoQuaresma requested a review from presleyp August 19, 2022 18:26
@presleyp

Copy link
Copy Markdown
Contributor

Looks like one of those theme changes affected some borders throughout the app, sorry if I led you astray!

@BrunoQuaresma

BrunoQuaresma commented Aug 19, 2022 •

Copy link
Copy Markdown
Contributor Author

Looks like one of those theme changes affected some borders throughout the app, sorry if I led you astray!

Yes, it was intentional. The outlined button was not using the right border color which is the palette. divider like the MuiButton-root is using.

I noticed it is breaking the ErrorSummary retry button. I'm sending a fix for it.

@BrunoQuaresma
BrunoQuaresma enabled auto-merge (squash) August 19, 2022 19:27
@BrunoQuaresma
BrunoQuaresma merged commit 54b8e79 into main Aug 19, 2022
@BrunoQuaresma
BrunoQuaresma deleted the bq/add-emoji-picker branch August 19, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for emojis on templates

2 participants