Skip to content

docs concept: workspace activity auto-stop - #3529

Closed
bpmct wants to merge 4 commits into
mainfrom
bpmct/concept/workspace-activity
Closed

bpmct wants to merge 4 commits into
mainfrom
bpmct/concept/workspace-activity

Conversation

@bpmct

@bpmct bpmct commented Aug 16, 2022

Copy link
Copy Markdown
Member

This isn't a feature we've implemented yet but I figured we could start with the docs, discuss ideas, and go from there. We'll likely close this PR and merge it into another branch with the solution

Please consult the RFC first.

Read Docs | Figma | RFC

@bpmct
bpmct requested a review from ammario as a code owner August 16, 2022 19:31
@bpmct
bpmct marked this pull request as draft August 16, 2022 19:31
@bpmct
bpmct removed the request for review from ammario August 16, 2022 19:31
Comment thread docs/workspaces.md

- HTTP (or websocket) request on `coder_app`

Coder's proxy will detect any traffic on apps (e.g. code-server)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For websockets, it is not clear to me whether we bump the lifetime only on the websocket request, or periodically while it is open like the SSH connection

@bpmct bpmct Aug 16, 2022 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emyrk any thoughts here? I'd imagine websockets are more likely to be left open (vs SSH connections), but I'm admittedly not the expert here 🤷🏼

@bpmct bpmct Aug 16, 2022 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spikecurtis would love your thoughts too. Happy to guess here and adjust from feedback 😝

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do know that Jupyter keeps a websocket open while you are interacting with a notebook. So, without periodic bumps, we would not consider a user "active" if they were working in a single Jupyter notebook. (opening new notebooks would cause a bump)

If we're going to do periodic bumps on an SSH connection, I think we should also do the same for any websockets open to coder_apps

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't any ide app have some sort of long lived connection? For sending keystrokes and whatnot?

I agree with Spike

Comment thread docs/workspaces.md

Coder's proxy will detect any traffic on apps (e.g. code-server)

- Typing in web terminal

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be rolled up into apps?

@github-actions

Copy link
Copy Markdown
Contributor

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions Bot added the stale This issue is like stale bread. label Aug 25, 2022
@github-actions github-actions Bot closed this Aug 28, 2022
@bpmct bpmct mentioned this pull request Sep 19, 2022
@github-actions
github-actions Bot deleted the bpmct/concept/workspace-activity branch February 17, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue is like stale bread.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants