Repository navigation
Conversation
|
|
||
| - HTTP (or websocket) request on `coder_app` | ||
|
|
||
| Coder's proxy will detect any traffic on apps (e.g. code-server) |
There was a problem hiding this comment.
For websockets, it is not clear to me whether we bump the lifetime only on the websocket request, or periodically while it is open like the SSH connection
There was a problem hiding this comment.
@Emyrk any thoughts here? I'd imagine websockets are more likely to be left open (vs SSH connections), but I'm admittedly not the expert here 🤷🏼
There was a problem hiding this comment.
@spikecurtis would love your thoughts too. Happy to guess here and adjust from feedback 😝
There was a problem hiding this comment.
I do know that Jupyter keeps a websocket open while you are interacting with a notebook. So, without periodic bumps, we would not consider a user "active" if they were working in a single Jupyter notebook. (opening new notebooks would cause a bump)
If we're going to do periodic bumps on an SSH connection, I think we should also do the same for any websockets open to coder_apps
There was a problem hiding this comment.
Wouldn't any ide app have some sort of long lived connection? For sending keystrokes and whatnot?
I agree with Spike
|
|
||
| Coder's proxy will detect any traffic on apps (e.g. code-server) | ||
|
|
||
| - Typing in web terminal |
There was a problem hiding this comment.
Can this be rolled up into apps?
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
This isn't a feature we've implemented yet but I figured we could start with the docs, discuss ideas, and go from there. We'll likely close this PR and merge it into another branch with the solution
Please consult the RFC first.
Read Docs | Figma | RFC