Skip to content

add metadata to example templates - #3451

Merged
bpmct merged 9 commits into
mainfrom
bpmct/add-metadata
Aug 10, 2022
Merged

bpmct merged 9 commits into
mainfrom
bpmct/add-metadata

Conversation

@bpmct

@bpmct bpmct commented Aug 10, 2022 •

Copy link
Copy Markdown
Member

resolves #3432

I manually tested each template

@bpmct
bpmct requested a review from dwahler August 10, 2022 12:07

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

PS: Just be careful with the commit message. It is missing the prefix like chore: My message

Comment thread examples/templates/aws-linux/main.tf Outdated
}
item {
key = "disk"
value = "${aws_instance.dev.root_block_device[0].volume_size} GB"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I think all of these "volume size" parameters are actually measured in GiB, not decimal GB. How about labeling them that way?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure!

@bpmct
bpmct merged commit cee0d1f into main Aug 10, 2022
@bpmct
bpmct deleted the bpmct/add-metadata branch August 10, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add resource metadata to example templates

3 participants