Skip to content

chore: Fix golangci-lint configuration and patch errors#34

Merged
kylecarbs merged 5 commits intomainfrom
fixlint
Jan 20, 2022
Merged

chore: Fix golangci-lint configuration and patch errors#34
kylecarbs merged 5 commits intomainfrom
fixlint

Conversation

@kylecarbs
Copy link
Copy Markdown
Member

Due to misconfiguration of a linting rules directory, our linter has not been
working properly. This change fixes the configuration issue, and all remaining
linting errors.

Due to misconfiguration of a linting rules directory, our linter has not been
working properly. This change fixes the configuration issue, and all remaining
linting errors.
@kylecarbs kylecarbs self-assigned this Jan 20, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2022

Codecov Report

Merging #34 (3ca4a35) into main (6a919ae) will increase coverage by 5.04%.
The diff coverage is 69.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   65.33%   70.37%   +5.04%     
==========================================
  Files          19       48      +29     
  Lines         150     2167    +2017     
  Branches        9        9              
==========================================
+ Hits           98     1525    +1427     
- Misses         48      499     +451     
- Partials        4      143     +139     
Flag Coverage Δ
unittest-go-macos-latest 66.73% <67.40%> (?)
unittest-go-ubuntu-latest 70.05% <69.23%> (?)
unittest-go-windows-latest 66.04% <66.66%> (?)
unittest-js 65.33% <ø> (ø)
Impacted Files Coverage Δ
database/db.go 0.00% <0.00%> (ø)
database/pubsub_memory.go 87.17% <0.00%> (ø)
peer/netconn.go 30.00% <0.00%> (ø)
peerbroker/listen.go 82.81% <ø> (ø)
database/postgres/postgres.go 66.66% <20.00%> (ø)
provisioner/terraform/provision.go 63.26% <50.00%> (ø)
httpapi/httpapi.go 68.11% <55.55%> (ø)
coderd/users.go 59.58% <62.50%> (ø)
coderd/userpassword/userpassword.go 63.41% <66.66%> (ø)
cryptorand/numbers.go 40.70% <66.66%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a919ae...3ca4a35. Read the comment docs.

Copy link
Copy Markdown
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the lint misconfiguration and fixing these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants