Skip to content

chore: alphabetize template list - #3363

Merged
bpmct merged 2 commits into
mainfrom
bpmct/fix-template-order
Aug 5, 2022
Merged

bpmct merged 2 commits into
mainfrom
bpmct/fix-template-order

Conversation

@bpmct

@bpmct bpmct commented Aug 3, 2022

Copy link
Copy Markdown
Member

fixes #2836

@bpmct bpmct self-assigned this Aug 3, 2022

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sensible change considering the client can't request different ordering.

Test failures need addressing but otherwise good to go. 👍🏻

Comment thread coderd/database/queries/templates.sql Resolved
@bpmct
bpmct requested a review from dwahler August 4, 2022 16:29

@dwahler dwahler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bpmct
bpmct merged commit f14efd1 into main Aug 5, 2022
@bpmct
bpmct deleted the bpmct/fix-template-order branch August 5, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template lists should be alphabetical

4 participants