Skip to content

fix: handle workspace errors - #3341

Merged
AbhineetJain merged 13 commits into
mainfrom
abhineetjain/workspace-errors
Aug 5, 2022
Merged

AbhineetJain merged 13 commits into
mainfrom
abhineetjain/workspace-errors

Conversation

@AbhineetJain

@AbhineetJain AbhineetJain commented Aug 1, 2022 •

Copy link
Copy Markdown
Contributor

This PR handles the errors shown on the Workspace (singular) page. We handle the following types of errors:

  • get workspace
  • check permissions
  • get resources
  • get builds
  • build error
  • build cancellation

Subtasks

  • display the errors using the ErrorSummary component for the listed errors
  • add stories

Fixes #3094

Screenshots

get resources

Screen Shot 2022-08-01 at 1 35 54 PM

get builds

Screen Shot 2022-08-01 at 1 35 42 PM

build cancellation

Screen Shot 2022-08-01 at 1 35 30 PM

build error

Screen Shot 2022-08-01 at 1 18 15 PM

get workspace

Screen Shot 2022-08-01 at 1 36 51 PM

@AbhineetJain
AbhineetJain requested a review from a team as a code owner August 1, 2022 16:33

@presleyp presleyp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! Do you know why the Chromatic check is being skipped?

@AbhineetJain

Copy link
Copy Markdown
Contributor Author

The code looks great! Do you know why the Chromatic check is being skipped?

@presleyp No idea, maybe the latest refactor in this PR (#3330) did it.

@AbhineetJain

Copy link
Copy Markdown
Contributor Author

@presleyp

presleyp commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Storybook makes it look like we're displaying an error message when a build is successfully canceled - is it supposed to be an error saying it failed to cancel? Or a success message about cancellation?

@AbhineetJain
AbhineetJain requested a review from presleyp August 3, 2022 18:45
@AbhineetJain
AbhineetJain merged commit e7bc013 into main Aug 5, 2022
@AbhineetJain
AbhineetJain deleted the abhineetjain/workspace-errors branch August 5, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix error messages in workspaceXService

3 participants