Skip to content

fix: prepend scheme to access url - #3317

Merged
sreya merged 3 commits into
mainfrom
jon/fixaccessurl
Jul 31, 2022
Merged

sreya merged 3 commits into
mainfrom
jon/fixaccessurl

Conversation

@sreya

@sreya sreya commented Jul 30, 2022

Copy link
Copy Markdown
Collaborator
  • Problems can arise spawning workspaces if a scheme-less URL is passed
    as the access URL.

    If an access URL is detected to not have an "http" or "https" scheme
    then it is prepended with "https". If the hostname is detected
    to be a loopback device then "http" is preferred.

fixes #2874

sreya added 2 commits July 30, 2022 00:46
- Problems can arise spawning workspaces if a schemeless URL is passed
  as the access URL.

  If an access url is detected to not have an "http" or "https" scheme
  then it is prepended with "https". If the hostname is detected
  to be a loopback device then "http" is preferred.
@sreya
sreya requested a review from dwahler July 30, 2022 00:54
Comment thread cli/server.go Resolved
@sreya
sreya merged commit 8b17bf9 into main Jul 31, 2022
@sreya
sreya deleted the jon/fixaccessurl branch July 31, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CODER_ACCESS_URL shouldn't require protocol

2 participants