Skip to content

Fix: surface error when over-extending workspace - #3275

Merged
presleyp merged 1 commit into
mainfrom
banner-error/presleyp/3097
Jul 28, 2022
Merged

presleyp merged 1 commit into
mainfrom
banner-error/presleyp/3097

Conversation

@presleyp

Copy link
Copy Markdown
Contributor

Fixes #3097

We were displaying a hard-coded error, and I changed it to display the error message from the backend. That message is currently not great in terms of specificity, but will improve with work @johnstcn is planning. It does not have a detail aspect, so there is no need to expand/collapse, and so I thought keeping the snackbar made sense.

Screen Shot 2022-07-28 at 3 23 48 PM

Testing

When I click + on the Workspace Schedule button too many times,
Then I see an error snackbar that says "Bad extend workspace request"

Once the backend error is updated, the snackbar will say something like "New deadline is greater than workspace allows"

With future work, the + button will be disabled so that it's impossible to elicit this error. It's just here in case of frontend bugs.

@presleyp
presleyp marked this pull request as ready for review July 28, 2022 20:07
@presleyp
presleyp requested a review from a team as a code owner July 28, 2022 20:07
@presleyp
presleyp merged commit 6b82fdd into main Jul 28, 2022
@presleyp
presleyp deleted the banner-error/presleyp/3097 branch July 28, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix error messages in workspaceScheduleXService and workspaceScheduleBannerXService

2 participants