Repository navigation
chore: remove the remaining export_test.go shims - #32434
Draft
ethanndickson wants to merge 3 commits into
Draft
ethanndickson wants to merge 3 commits into
ethanndickson wants to merge 3 commits into
Conversation
…-export-test-shims
…lpers ChatMachine.ChatID had no caller outside tests, and Update already returns the chat row, so the tests use that. The mcpclient connect budget test builds its one healthy server inline, not through copies of the external test helpers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CODAGT-1607
Follow-up to #32162, which left 5
export_test.goshims behind:coderd,aibridged,chatd,chatstateandmcpclient. This PR removes them. It's stacked on #32433, which deals with the chat workspace functions incoderd.Same approach as before. Tests of package internals are now
*_internal_test.gofiles, with no changes beyond what the move forces, and tests that only needed a constant just use the value.chatstateneeded one small accessor, soAllowedExecutionTransitionOutputsis just exported for real, and its tests stay where they were. Unfortunately themcpclientconnect budget test needs an unexported timeout, so it moved to an internal file and builds its own server there.I've removed
TestConnectAll_LateServerReaped,TestAllExecutionStates_Enumerationand a few assertions instead of moving them, as I couldn't find a breakage that only they would catch.With no shims left, the
testpackagepath exclusion is gone, so a newexport_test.gonow fails lint.