Skip to content

chore: remove the remaining export_test.go shims - #32434

Draft
ethanndickson wants to merge 3 commits into
ethan/chat-workspace-tool-testsfrom
ethan/remove-last-export-test-shims
Draft

ethanndickson wants to merge 3 commits into
ethan/chat-workspace-tool-testsfrom
ethan/remove-last-export-test-shims

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Closes CODAGT-1607

Follow-up to #32162, which left 5 export_test.go shims behind: coderd, aibridged, chatd, chatstate and mcpclient. This PR removes them. It's stacked on #32433, which deals with the chat workspace functions in coderd.

Same approach as before. Tests of package internals are now *_internal_test.go files, with no changes beyond what the move forces, and tests that only needed a constant just use the value. chatstate needed one small accessor, so AllowedExecutionTransitionOutputs is just exported for real, and its tests stay where they were. Unfortunately the mcpclient connect budget test needs an unexported timeout, so it moved to an internal file and builds its own server there.

I've removed TestConnectAll_LateServerReaped, TestAllExecutionStates_Enumeration and a few assertions instead of moving them, as I couldn't find a breakage that only they would catch.

With no shims left, the testpackage path exclusion is gone, so a new export_test.go now fails lint.

@linear-code

linear-code Bot commented Nov 19, 2026

Copy link
Copy Markdown

CODAGT-1607

…lpers

ChatMachine.ChatID had no caller outside tests, and Update already
returns the chat row, so the tests use that. The mcpclient connect
budget test builds its one healthy server inline, not through copies
of the external test helpers.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant