Skip to content

feat: Add backend API support for resource metadata - #3242

Merged
dwahler merged 7 commits into
mainfrom
dwahler/2989-resource-metadata
Aug 1, 2022
Merged

dwahler merged 7 commits into
mainfrom
dwahler/2989-resource-metadata

Conversation

@dwahler

@dwahler dwahler commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

This PR adds the initial API support for workspace resource metadata, as described in #2989.

Metadata fields are extracted from templates by the Terraform provisioner, propagated from provisionerd to coderd, persisted in a new workspace_resource_metadata table, and included in a new Metadata field of the WorkspaceResource objects that are returned from the following API endpoints:

  • /api/v2/workspacebuilds/{id}/resources
  • /api/v2/workspaceresources/{id}/

Depends on the corresponding Terraform provider changes in coder/terraform-provider-coder#34.

@dwahler
dwahler requested a review from a team July 27, 2022 05:51
@dwahler
dwahler requested a review from a team as a code owner July 27, 2022 05:51

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, but you might want to get another review from someone more familiar with the Terraform provisioner.

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FE part looks good!

@dwahler
dwahler force-pushed the dwahler/2989-resource-metadata branch from 90f9fb1 to 1a47f27 Compare July 28, 2022 20:59
@dwahler
dwahler merged commit 8a28112 into main Aug 1, 2022
@dwahler
dwahler deleted the dwahler/2989-resource-metadata branch August 1, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants