Repository navigation
feat: Add backend API support for resource metadata - #3242
Merged
Merged
Conversation
johnstcn
approved these changes
Jul 27, 2022
johnstcn
left a comment
Member
There was a problem hiding this comment.
It looks fine to me, but you might want to get another review from someone more familiar with the Terraform provisioner.
BrunoQuaresma
approved these changes
Jul 27, 2022
BrunoQuaresma
left a comment
Contributor
There was a problem hiding this comment.
The FE part looks good!
dwahler
force-pushed
the
dwahler/2989-resource-metadata
branch
from
July 28, 2022 20:59
90f9fb1 to
1a47f27
Compare
kylecarbs
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the initial API support for workspace resource metadata, as described in #2989.
Metadata fields are extracted from templates by the Terraform provisioner, propagated from provisionerd to coderd, persisted in a new
workspace_resource_metadatatable, and included in a newMetadatafield of theWorkspaceResourceobjects that are returned from the following API endpoints:/api/v2/workspacebuilds/{id}/resources/api/v2/workspaceresources/{id}/Depends on the corresponding Terraform provider changes in coder/terraform-provider-coder#34.