Repository navigation
feat: add GPT-6.2 Astra and GPT-6.2 Sol to Agents and AI Gateway - #32370
Conversation
…or GPT-6.2 models GPT-6.2 Astra and GPT-6.2 Sol reject the none and minimal reasoning efforts with HTTP 400, as GPT-6 Astra and GPT-6.1 Sol do. One prefix list in chatprovider now names all four models and replaces the two exported chatopenai helpers.
| var openAILowFloorPrefixes = []string{ | ||
| "gpt-6-astra", | ||
| "gpt-6.1-sol", | ||
| "gpt-6.2-astra", | ||
| "gpt-6.2-sol", | ||
| } |
There was a problem hiding this comment.
We should handle this in the follow-up, CODAGT-1609, rather than add to this list every time a new model rejects these efforts.
…m ARCHITECTURE.md
|
|
||
| During generation preparation, the effective effort is resolved as the chat's `last_reasoning_effort` if set, else the config's `default`; clamped to the config's `max` on the global scale `none < minimal < low < medium < high < xhigh < max`; and passed through to the provider. The provider verifies whether the configured value is valid for that model at runtime. If the model config has no `reasoning_effort`, any user-selected value is ignored. The resolved value is injected into the provider-native options by `chatprovider.ProviderOptionsForCall`, which converts the model config and applies the effort in one step. For Anthropic, the fantasy provider converts effort into enabled budget thinking on models older than Claude 4.6, which reject adaptive thinking. | ||
|
|
||
| `applyReasoningEffort` clamps `none` and `minimal` to `low` for GPT-6 Astra and its dated snapshots (`chatopenai.IsGPT6Astra`, a case-insensitive prefix match on `gpt-6-astra`), because that model rejects `none` with HTTP 400 and lists no `minimal` effort. |
There was a problem hiding this comment.
I don't think this belongs in ARCHITECTURE.md at all, so I've deleted it rather than extend it to the new models. It's a per-model detail, and the comment on the list in reasoningeffort.go already covers it.
Add both models to the Agents known models catalog for openai, openrouter, and vercel, and regenerate the AI Gateway price book from models.dev.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a823d22a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review The earlier finding "Route the new GPT-6.2 models through Responses" did not reproduce, so the head is unchanged. In the pinned SDK, |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ssncferreira
left a comment
There was a problem hiding this comment.
LGTM from AI Gateway and price book side 👍
Closes CODAGT-1608
This adds
gpt-6.2-astraandgpt-6.2-solto the Agents known models catalog, so they're suggested when an admin adds a chat model, and regenerates the AI Gateway price book from models.dev so the gateway can price them.Prices are per 1M tokens, and both models have a 1,050,000 token context window and 128,000 max output tokens. They're in the catalog for OpenAI (with a suggested effort of
medium, same asgpt-6-astraandgpt-6.1-sol), OpenRouter and Vercel. models.dev doesn't list them on Azure or Bedrock yet, so I've left those out for now.Both models also reject the
noneandminimalreasoning efforts. A model config only sets a default and a maximum effort, so the picker always offers both, and picking either one fails the turn:We already send
lowinstead forgpt-6-astraandgpt-6.1-sol, so to fix, we'll just do the same for the two new models. All four now live in one list of model ID prefixes, rather than a helper each. I checked this against the real models: all four return a 400 like the one above fornoneandminimal, and acceptlow.gpt-6-solandgpt-6.1-terrastill acceptnone, so they're left alone.Regenerating the price book also brings in everything else models.dev changed since the last weekly refresh, mostly on OpenRouter and Vercel: 22 other new entries (4 of them
-proand-fastvariants of these two), 29 it dropped and 51 price changes. 6 existing catalog entries get new prices or limits the same way.