Repository navigation
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deque's
label-is-missing-selectcheckpoint (WCAG 3.3.2) flagged filter dropdowns and the workspace sharing form because their only label was placeholder text ("All users", "Search for user or group"). That text goes away once you pick a value.ComboboxButtontakes an optionallabeland shows it before the value, so the trigger readsUser: AllorUser: admin. It also sets the accessible name to the same string.SelectFilterpasses itslabel(now a short noun such as "User", "Action" or "Organization") through and always uses "All" as the placeholder. Each caller only renames its label.DateTimeRangePickershows its existinglabel(default "Time range") the same way:Time range: Last 24 hours. The Users page "All time" preset now shows "All time" instead of repeating "Last seen".ProjectAccessDialog.aria-hiddenso their initials don't breaklabel-content-name-mismatch.Closes DEQ-176
Closes DEQ-190
Closes DEQ-284
Closes DEQ-396
Closes DEQ-548
Closes DEQ-565
SelectFilterwas replaced by the filter combobox in #29809. The remaining "Last seen" picker now has a visible label, and so does theUsersFilterstatus menu (org and group members).mainby #29426, which replaced these dropdowns with the filter combobox. No change here.Connection log, Spend and the organization menu also use
SelectFilter, so they get the labels too.Grouping and decision log
SelectFilter/ComboboxButtonorDateTimeRangePicker, so the fix goes in those primitives and the call sites only rename labels. DEQ-176 is the sharing form, which needs its own labels.Label: valuekeeps the filter rows' height and layout, and it reads well in a single row. I shortened the Connection log labels to "Status" and "Method" so values still fit at the 175px multi-org width.htmlForon "User or group": the trigger is named byaria-labelledby(label, then itself). A<label for>made the self-reference resolve to the label text (accname step 2D), so the name lost the selection. As a result, clicking that label no longer focuses the picker. The "Role" label still useshtmlFor.placeholderprop, a stale comment, and a test that asserted an attribute instead of the name.ProjectAccessDialog'ssr-onlylabel have the same problem but aren't in these tickets. The assertions already in the touched story play functions were left as they were.🤖 Generated by Coder Agents on behalf of @aqandrew.