Skip to content

fix(site): give select filters and the sharing form visible labels - #32360

Open
aqandrew wants to merge 4 commits into
mainfrom
a11y/label-is-missing-select
Open

aqandrew wants to merge 4 commits into
mainfrom
a11y/label-is-missing-select

Conversation

@aqandrew

@aqandrew aqandrew commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Deque's label-is-missing-select checkpoint (WCAG 3.3.2) flagged filter dropdowns and the workspace sharing form because their only label was placeholder text ("All users", "Search for user or group"). That text goes away once you pick a value.

  • ComboboxButton takes an optional label and shows it before the value, so the trigger reads User: All or User: admin. It also sets the accessible name to the same string. SelectFilter passes its label (now a short noun such as "User", "Action" or "Organization") through and always uses "All" as the placeholder. Each caller only renames its label.
  • DateTimeRangePicker shows its existing label (default "Time range") the same way: Time range: Last 24 hours. The Users page "All time" preset now shows "All time" instead of repeating "Last seen".
  • The workspace sharing form gets visible "User or group" and "Role" labels above its fields. The autocomplete keeps the label in its name after a selection, using the same pattern as ProjectAccessDialog.
  • Trigger avatars are aria-hidden so their initials don't break label-content-name-mismatch.

Closes DEQ-176
Closes DEQ-190
Closes DEQ-284
Closes DEQ-396
Closes DEQ-548
Closes DEQ-565

Ticket Surface Screenshots
DEQ-176 Workspace sharing form (share popover, workspace settings) before/after
DEQ-190 AI Gateway sessions filters and time range before/after
DEQ-284 Templates author and organization filters before/after
DEQ-396 Users page. The audited status SelectFilter was replaced by the filter combobox in #29809. The remaining "Last seen" picker now has a visible label, and so does the UsersFilter status menu (org and group members). before/after
DEQ-548 Audit log filters before/after
DEQ-565 Workspaces page. Already fixed on main by #29426, which replaced these dropdowns with the filter combobox. No change here. n/a

Connection log, Spend and the organization menu also use SelectFilter, so they get the labels too.

Grouping and decision log
  • One root cause: all six tickets use a placeholder as the only label. Five of them render through SelectFilter/ComboboxButton or DateTimeRangePicker, so the fix goes in those primitives and the call sites only rename labels. DEQ-176 is the sharing form, which needs its own labels.
  • Label prefix, not a label above: an inline Label: value keeps the filter rows' height and layout, and it reads well in a single row. I shortened the Connection log labels to "Status" and "Method" so values still fit at the 175px multi-org width.
  • No htmlFor on "User or group": the trigger is named by aria-labelledby (label, then itself). A <label for> made the self-reference resolve to the label text (accname step 2D), so the name lost the selection. As a result, clicking that label no longer focuses the picker. The "Role" label still uses htmlFor.
  • Self-review findings fixed: duplicate "Last seen: Last seen", the visible-text and name mismatch (missing space, avatar initials), the unused placeholder prop, a stale comment, and a test that asserted an attribute instead of the name.
  • Out of scope, noted: the Spend page organization autocomplete and ProjectAccessDialog's sr-only label have the same problem but aren't in these tickets. The assertions already in the touched story play functions were left as they were.

🤖 Generated by Coder Agents on behalf of @aqandrew.

@linear-code

linear-code Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

@aqandrew
aqandrew marked this pull request as ready for review November 18, 2026 00:19

This branch was successfully deployed

1 active deployment
main — fba27549 Deployed Nov 18, 2026 by aqandrew via cla #259056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant