Skip to content

fix(site/src): add navigation semantics to pagination and deployment banner - #32354

Open
aqandrew wants to merge 1 commit into
mainfrom
a11y/semantic-nav
Open

aqandrew wants to merge 1 commit into
mainfrom
a11y/semantic-nav

Conversation

@aqandrew

Copy link
Copy Markdown
Collaborator

Adds navigation semantics to two groups of links that Deque flagged under semantic-nav (WCAG 1.3.1).

  • PaginationWidgetBase now renders <nav aria-label="Pagination"> with a <ul>, and each page button sits in its own <li>. The narrow/wide toggle moved from display: contents wrappers onto the lis.
  • DeploymentBannerView is now a <section aria-label="Deployment stats"> region. The workspace status links sit in a <nav> labelled by the visible "Workspaces" text, as a <ul> with one <li> per status. The / separators are aria-hidden.

Closes DEQ-145
Closes DEQ-487

Ticket UI surface Visible change
DEQ-145 Pagination on every paginated list (Audit Logs, Workspaces, Users, and others) None
DEQ-487 Deployment banner at the bottom of the dashboard (admins only) None

I captured Storybook screenshots before and after (PaginationWidgetBase wide and narrow, DeploymentBannerView/Example). They are byte-identical, so none are attached. Running axe-core 4.11 on those stories reported no violations on either base or branch.

Grouping, decisions, and dropped findings
  • Grouping: two tickets, one PR. Both are the same rule and both fixes are markup-only (163 non-test lines).
  • No new tests: at first I added Vitest assertions for the nav, list, and listitem roles. frontend-deep-review (TS2/TS5) flagged them under FE1 because they assert DOM structure, not a behavior outcome, so I removed them. The existing behavior tests still pass unchanged.
  • Dropped finding: the shared PaginationWidgetBase always uses the name "Pagination", and two widgets on one page would produce duplicate landmark names. No page renders more than one, so I did not add a label prop.
  • Pre-existing, not in scope: the banner's workspace status links get their accessible name only from the count, with the status in a tooltip description. I left this for a separate ticket.

🤖 Generated by Coder Agents on behalf of @aqandrew.

…banner

Wrap PaginationWidgetBase in a labeled nav with list markup, and give
the deployment banner a region landmark with a labeled nav list for the
workspace status links. Separators in the banner are hidden from
assistive technology.

Fixes DEQ-145 and DEQ-487.
@linear-code

linear-code Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

DEQ-487

DEQ-145

@aqandrew
aqandrew marked this pull request as ready for review November 17, 2026 23:21

This branch was successfully deployed

1 active deployment
main — 887cfaf1 Deployed Nov 17, 2026 by aqandrew via cla #259028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant