Repository navigation
Conversation
…banner Wrap PaginationWidgetBase in a labeled nav with list markup, and give the deployment banner a region landmark with a labeled nav list for the workspace status links. Separators in the banner are hidden from assistive technology. Fixes DEQ-145 and DEQ-487.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds navigation semantics to two groups of links that Deque flagged under
semantic-nav(WCAG 1.3.1).PaginationWidgetBasenow renders<nav aria-label="Pagination">with a<ul>, and each page button sits in its own<li>. The narrow/wide toggle moved fromdisplay: contentswrappers onto thelis.DeploymentBannerViewis now a<section aria-label="Deployment stats">region. The workspace status links sit in a<nav>labelled by the visible "Workspaces" text, as a<ul>with one<li>per status. The/separators arearia-hidden.Closes DEQ-145
Closes DEQ-487
I captured Storybook screenshots before and after (
PaginationWidgetBasewide and narrow,DeploymentBannerView/Example). They are byte-identical, so none are attached. Running axe-core 4.11 on those stories reported no violations on either base or branch.Grouping, decisions, and dropped findings
frontend-deep-review(TS2/TS5) flagged them under FE1 because they assert DOM structure, not a behavior outcome, so I removed them. The existing behavior tests still pass unchanged.PaginationWidgetBasealways uses the name "Pagination", and two widgets on one page would produce duplicate landmark names. No page renders more than one, so I did not add a label prop.🤖 Generated by Coder Agents on behalf of @aqandrew.