Skip to content

feat: add dbcrypt support for oauth_extra - #32344

Open
sreya wants to merge 1 commit into
mainfrom
sreya/crypt-oauth-extra
Open

sreya wants to merge 1 commit into
mainfrom
sreya/crypt-oauth-extra

Conversation

@sreya

@sreya sreya commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sreya
sreya temporarily deployed to main November 17, 2026 22:08 — with GitHub Actions Inactive
@sreya
sreya temporarily deployed to main November 17, 2026 22:08 — with GitHub Actions Inactive

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to text this on really large databases... ensure no-nonsense please.

@sreya

sreya commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T22:38:44.656320Z a026095 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a026095fd6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1250 to +1254
encoded, err := json.Marshal(payload)
if err != nil {
return xerrors.Errorf("marshal encrypted extra: %w", err)
}
extra.RawMessage = encoded

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stage encrypted extras for rolling upgrades

With the default Kubernetes RollingUpdate strategy, a new replica immediately replaces a nonempty oauth_extra object with this ciphertext JSON string, while a pre-change replica does not understand oauth_extra_key_id and passes the string to createExternalAuthResponse, where unmarshalling it into TokenExtra fails. More seriously, if that old replica refreshes the token, its old update writes plaintext oauth_extra without clearing the new key-ID column, so new replicas subsequently attempt to decrypt plaintext and reject the link. Please use a staged or otherwise backward-compatible cutover before enabling encrypted writes.

Useful? React with 👍 / 👎.

@sreya
sreya added this pull request to stack #32357 November 17, 2026 23:20

This branch was previously deployed

1 inactive deployment
main — a026095f Deployed Nov 17, 2026 by sreya via cla #258968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants