Repository navigation
Conversation
kylecarbs
left a comment
There was a problem hiding this comment.
Be sure to text this on really large databases... ensure no-nonsense please.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a026095fd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| encoded, err := json.Marshal(payload) | ||
| if err != nil { | ||
| return xerrors.Errorf("marshal encrypted extra: %w", err) | ||
| } | ||
| extra.RawMessage = encoded |
There was a problem hiding this comment.
Stage encrypted extras for rolling upgrades
With the default Kubernetes RollingUpdate strategy, a new replica immediately replaces a nonempty oauth_extra object with this ciphertext JSON string, while a pre-change replica does not understand oauth_extra_key_id and passes the string to createExternalAuthResponse, where unmarshalling it into TokenExtra fails. More seriously, if that old replica refreshes the token, its old update writes plaintext oauth_extra without clearing the new key-ID column, so new replicas subsequently attempt to decrypt plaintext and reject the link. Please use a staged or otherwise backward-compatible cutover before enabling encrypted writes.
Useful? React with 👍 / 👎.
No description provided.