Skip to content

fix(site/src/pages/LoginPage): give the login page a non-empty document title - #32327

Open
jeremyruppel wants to merge 2 commits into
mainfrom
a11y/document-title
Open

jeremyruppel wants to merge 2 commits into
mainfrom
a11y/document-title

Conversation

@jeremyruppel

@jeremyruppel jeremyruppel commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

The login page's browser title was empty, which axe flags as document-title (WCAG 2.4.2).

<title>Sign in to {applicationName}</title> gives <title> two JSX children. React 19 only sets <title> text from a single string child, so it hoisted an empty <title> ahead of index.html's <title>Coder</title>, and document.title was "". A template literal makes the child a single string. The visible text is unchanged.

Screenshot 2026-11-17 at 11 27 08 AM

Closes DEQ-254

Ticket Surface Screenshots
DEQ-254 /login document title n/a: no rendered UI change
Grouping and decision log
  • DEQ-254 is the only ticket with the document-title label. The issue is not global: site/index.html already ships <title>Coder</title>.
  • I reproduced it with jsdom and the repo's react-dom 19.3.1. Main gives <title></title><title>Coder</title> and document.title === "". The branch gives "Sign in to Coder".
  • axe-core 4.11.1 document-title against the rendered login page: 1 violation on main, 0 on the branch.
  • I scanned every site/src/**/*.tsx file with the TS AST for <title> elements without exactly one child. LoginPage was the only one.
  • I did not use pageTitle(), because it appends " - Coder" and would change the title text.
  • I did not add a repo-wide lint rule for multi-child <title>. It is a possible follow-up.
  • Self-review (frontend-review, frontend-deep-review, frontend-accessibility, test-audit) found no blocking or should-fix findings. I applied one nit, the test name.

🤖 Generated by Coder Agents on behalf of @jeremyruppel.

@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

DEQ-254

@jeremyruppel
jeremyruppel temporarily deployed to main November 17, 2026 16:26 — with GitHub Actions Inactive
@jeremyruppel
jeremyruppel temporarily deployed to main November 17, 2026 16:26 — with GitHub Actions Inactive
@jeremyruppel
jeremyruppel temporarily deployed to main November 17, 2026 16:28 — with GitHub Actions Inactive
@jeremyruppel
jeremyruppel marked this pull request as ready for review November 17, 2026 16:31
@jeremyruppel
jeremyruppel temporarily deployed to main November 17, 2026 16:31 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
main — 90f38b0b Deployed Nov 17, 2026 by jeremyruppel via cla #258797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant