Repository navigation
fix(site/src/pages/LoginPage): give the login page a non-empty document title - #32327
Open
jeremyruppel wants to merge 2 commits into
Open
jeremyruppel wants to merge 2 commits into
jeremyruppel wants to merge 2 commits into
Conversation
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login page's browser title was empty, which axe flags as
document-title(WCAG 2.4.2).<title>Sign in to {applicationName}</title>gives<title>two JSX children. React 19 only sets<title>text from a single string child, so it hoisted an empty<title>ahead ofindex.html's<title>Coder</title>, anddocument.titlewas"". A template literal makes the child a single string. The visible text is unchanged.Closes DEQ-254
/logindocument titleGrouping and decision log
document-titlelabel. The issue is not global:site/index.htmlalready ships<title>Coder</title>.<title></title><title>Coder</title>anddocument.title === "". The branch gives"Sign in to Coder".document-titleagainst the rendered login page: 1 violation on main, 0 on the branch.site/src/**/*.tsxfile with the TS AST for<title>elements without exactly one child. LoginPage was the only one.pageTitle(), because it appends " - Coder" and would change the title text.<title>. It is a possible follow-up.🤖 Generated by Coder Agents on behalf of @jeremyruppel.