Skip to content

fix(site/src/pages/WorkspacesPage): show the select all workspaces label on hover and focus - #32325

Open
jeremyruppel wants to merge 2 commits into
a11y/table-data-not-headerfrom
a11y/label-not-present
Open

jeremyruppel wants to merge 2 commits into
a11y/table-data-not-headerfrom
a11y/label-not-present

Conversation

@jeremyruppel

@jeremyruppel jeremyruppel commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

The "Select all workspaces" checkbox had only an aria-label, so sighted users saw an unlabeled checkbox (Deque label-not-present, WCAG 3.3.2). It now shows a "Select all workspaces" tooltip on hover and keyboard focus, the pattern Deque's guidance allows (Gmail's "Select all"). It reuses the shared Tooltip, as PrimaryAction in the same file does.

Stacked on #32322, which moves this checkbox into its own td column. Stack order: #32322, then this PR.

Closes DEQ-348

Ticket Surface Screenshots
DEQ-348 Workspaces table select-all checkbox (WorkspacesTable.tsx) before/after

The tooltip trigger is the wrapper div, not the Checkbox. Radix TooltipTrigger asChild sets data-state (closed, delayed-open) on its child, which overrides the checkbox's checked/unchecked state and breaks its data-[state=…] styling. Using the wrapper also lets hover reveal the label while the checkbox is disabled, and keeps the tooltip's aria-describedby off the checkbox so screen readers don't read the name twice.

Grouping and decision log
  • Batch label-not-present had one eligible ticket (DEQ-348), one root cause.
  • Options: (a) always-visible text label next to the checkbox: it would crowd the leading checkbox column that fix(site/src/pages/WorkspacesPage): move selection checkboxes out of table header cells #32322 adds and duplicate the column purpose, needs a design call; (b) label on hover and focus via the shared Tooltip: chosen, matches Deque's suggested label text and an existing pattern in this file.
  • Stacked on fix(site/src/pages/WorkspacesPage): move selection checkboxes out of table header cells #32322 because both change the same checkbox block.
  • Self-review found the data-state collision when the Checkbox was the trigger (checked styling never applied). Fixed by making the wrapper div the trigger. Verified in Storybook that the checkbox keeps data-state="checked".
  • The first version had a Vitest test that asserted the tooltip renders. Replaced with a SelectAllLabel story that focuses the checkbox so Pixel captures the label, per FE1.
  • Verified by hand in Storybook: focus shows the label, hover shows it (also on a disabled checkbox), and it reopens after a real click, leave, and re-enter.
  • Pre-existing, not touched: aria-valid-attr-value on the filter combobox input (aria-controls points to an unmounted popover).
  • Checks: pnpm check, pnpm lint, pnpm format; WorkspacesPageView unit tests; all 36 WorkspacesPageView stories in the Storybook Vitest project; axe on SelectAllLabel; frontend-review, frontend-deep-review, and frontend-accessibility self-review.

🤖 Generated by Coder Agents on behalf of @jeremyruppel.

@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

DEQ-348

@jeremyruppel
jeremyruppel marked this pull request as ready for review November 17, 2026 16:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant