Repository navigation
fix(site/src/pages/WorkspacesPage): show the select all workspaces label on hover and focus - #32325
Open
jeremyruppel wants to merge 2 commits into
Open
jeremyruppel wants to merge 2 commits into
jeremyruppel wants to merge 2 commits into
Conversation
…bel on hover and focus
… the select all tooltip
jeremyruppel
marked this pull request as ready for review
November 17, 2026 16:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Select all workspaces" checkbox had only an
aria-label, so sighted users saw an unlabeled checkbox (Dequelabel-not-present, WCAG 3.3.2). It now shows a "Select all workspaces" tooltip on hover and keyboard focus, the pattern Deque's guidance allows (Gmail's "Select all"). It reuses the sharedTooltip, asPrimaryActionin the same file does.Stacked on #32322, which moves this checkbox into its own
tdcolumn. Stack order: #32322, then this PR.Closes DEQ-348
WorkspacesTable.tsx)The tooltip trigger is the wrapper
div, not theCheckbox. RadixTooltipTrigger asChildsetsdata-state(closed,delayed-open) on its child, which overrides the checkbox'schecked/uncheckedstate and breaks itsdata-[state=…]styling. Using the wrapper also lets hover reveal the label while the checkbox is disabled, and keeps the tooltip'saria-describedbyoff the checkbox so screen readers don't read the name twice.Grouping and decision log
label-not-presenthad one eligible ticket (DEQ-348), one root cause.Tooltip: chosen, matches Deque's suggested label text and an existing pattern in this file.data-statecollision when theCheckboxwas the trigger (checked styling never applied). Fixed by making the wrapperdivthe trigger. Verified in Storybook that the checkbox keepsdata-state="checked".SelectAllLabelstory that focuses the checkbox so Pixel captures the label, per FE1.aria-valid-attr-valueon the filter combobox input (aria-controlspoints to an unmounted popover).pnpm check,pnpm lint,pnpm format; WorkspacesPageView unit tests; all 36 WorkspacesPageView stories in the Storybook Vitest project; axe onSelectAllLabel; frontend-review, frontend-deep-review, and frontend-accessibility self-review.🤖 Generated by Coder Agents on behalf of @jeremyruppel.