Repository navigation
fix(site/src/pages/WorkspacesPage): move selection checkboxes out of table header cells - #32322
Open
jeremyruppel wants to merge 1 commit into
Open
jeremyruppel wants to merge 1 commit into
jeremyruppel wants to merge 1 commit into
Conversation
…table header cells The select-all checkbox sat inside the Name column header and each row checkbox inside its row header, so screen readers announced the control labels as part of the headers (DEQ-233, axe table-data-not-header). Give the checkboxes their own leading column of data cells.
Collaborator
Author
|
easier to view the table diff without whitespace https://github.com/coder/coder/pull/32322/changes?w=1 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Workspaces table put the "Select all workspaces" checkbox inside the Name column header and each row checkbox inside its row header, so screen readers announced the control as part of the header (axe
table-data-not-header, WCAG 1.3.1). The checkboxes now live in their own leading column oftdcells; the Name column header and row headers contain only their labels.Closes DEQ-233
WorkspacesTable.tsx)Visible change: the checkbox-to-avatar gap shrinks from about 25px to 17px (the Table primitive's checkbox-cell padding), and Template/Status shift a few pixels. Vertical alignment and table borders are unchanged.
Dropped review finding: axe's experimental
td-has-headerflags the new checkbox cells because no header labels them. Experimental rules are out of the audit scope, and labelling the column with athwould put the control back inside a header cell, which is this ticket's issue. Each checkbox keeps its own accessible name.Grouping and decision log
table-data-not-headerhad one eligible ticket (DEQ-233), one root cause.thwith sr-only text plus the checkbox: still a control in a header cell, rejected; (b) separate leading column oftdcells: chosen.tdinsidethead;TableHeaderalready removestdborders there.<div className="flex">so it sits centred like before; without it, the inline-block checkbox sat about 2px low and the header grew 3px.aria-valid-attr-valueon the filter combobox input;aria-progressbar-name/button-namein the loading skeleton.mainand passes here;pnpm check,pnpm lint,pnpm format; axe run on AllStates, Loading, OwnerHasNoWorkspaces and SelectAllMixedEligibility, before and after (no new violations); frontend-review, frontend-deep-review and frontend-accessibility self-review.🤖 Generated by Coder Agents on behalf of @jeremyruppel.