Repository navigation
Conversation
…eir template or module Repeated "View details" registry links in the template builder had identical accessible names but different destinations (WCAG 2.4.4). Add visually hidden context so each name reads "View details for <name>"; the visible text stays first in the name (2.5.3). Closes DEQ-210, DEQ-142
chrifro
marked this pull request as ready for review
November 17, 2026 14:58
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template builder repeats a "View details" registry link on every base template card (step 1), module card (step 2), and configured item, so screen reader users could not tell which template or module each link opens (WCAG 2.4.4, Link Purpose (In Context)).
Each link now has visually hidden context after its visible text, so its accessible name reads "View details for AWS EC2 (Linux) (opens in new tab)". The visible text is unchanged and stays first in the name, so voice-control users can still say "View details" (2.5.3).
Closes DEQ-210, DEQ-142
/templates/new/builder, step 1 base template cards (TemplateCard)/templates/new/builder?step=module-select, module cards (ModuleCard)TemplateBuilderAvatarData)Accessible names read from Chromium's accessibility tree on the running dev server:
View details (opens in new tab)(repeated)View details for Docker Containers (opens in new tab),View details for AWS EC2 (Linux) (opens in new tab), ...View details (opens in new tab)(repeated)View details for Claude Code (opens in new tab),View details for Codex CLI (opens in new tab), ...Decision log
sr-onlyspan overaria-label:aria-labelwould override the link content and duplicate the "(opens in new tab)" text thatLinkalready appends. The hidden span extends the name in place and keeps label-in-name.sr-onlyspan overaria-describedby(used in fix(site/src/modules/notifications): describe inbox action links with notification content #32317): these cards have no single element whose text alone identifies the item without extra noise, and the Deque suggested labels ("View details for Git Clone") are names, not descriptions. Putting the item in the name also fixes link lists such as the NVDA Elements List.inline-flexlink.hrefinstead of the accessible name) was fixed. Its optional nit (extract a shared link component for the three call sites) was skipped to keep the fix small.TemplateCardtest fails without the fix),pnpm check,pnpm lint, and a Playwright check of accessible names on both steps against./scripts/develop.sh.🤖 Generated by Coder Agents on behalf of @chrifro.