Repository navigation
Conversation
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy confirmations (the tick icon and the "Copied" status) disappeared after a 1 second timer, which fails WCAG 2.2.1 Timing Adjustable.
useClipboardnow keepsshowCopiedSuccesstrue until the user's next pointer press or key press anywhere on the page, which is the "leave the content on screen until dismissed by the user" fix the audit recommends. Every copy control that uses the hook gets the fix.TemplateEmbedPageViewdisabled its copy button while the confirmation showed. Now that the confirmation can stay up indefinitely, the button would have stayed disabled, so it no longer disables.Closes DEQ-95
Closes DEQ-407
Closes DEQ-494
CopyButton); "Notifications are blocked" error toastCopyButton,AgentRow)The DEQ-95 toast was already fixed on
mainby #30420, which keeps error toasts open until dismissed. This PR covers the tick icon.Dropped review findings
CopyableValue,UserDropdownContent,AgentRow,RemoteDiffPanel) keep that text until the next click or key press, so hovering the control again still shows "Copied!". Accessible names don't change. Also dismissing onpointerleaveorblurwould be a product decision, and the tickets ask for persistence, so I left this unchanged.Grouping and decision log
CLIPBOARD_TIMEOUT_MSinsite/src/hooks/useClipboard.tsresetshowCopiedSuccessafter 1 second. Every reported tick icon reads that flag, so one fix in the hook replaces several call-site patches.pointerdownandkeydownondocumentin the capture phase, so components that stop propagation (Radix menus) still dismiss it. The event that starts a copy has already been dispatched by the time the listener is attached, so the confirmation does not dismiss itself.useClipboardtests were replaced. The persistence and dismissal behavior is covered throughCopyButton(key press and pointer press), and these tests fail onmain. One vacuous "no success timer after unmount" test was removed because no timer exists anymore.onTestFinishedinstead oftry/finally, and the disabled embed button. In frontend-accessibility, axe-core 4.11 runs on theUserDropdownandWorkspaceTopbarstories in the copied state. They report only the page-level rules that isolated stories ignore, and the results matchmain.site/.🤖 Generated by Coder Agents on behalf of @chrifro.