Skip to content

fix(site/src/modules/notifications): describe inbox action links with notification content - #32317

Open
chrifro wants to merge 2 commits into
mainfrom
a11y/inbox-action-link-purpose
Open

chrifro wants to merge 2 commits into
mainfrom
a11y/inbox-action-link-purpose

Conversation

@chrifro

@chrifro chrifro commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Notification inbox action links such as "View workspace" read the same for every notification, so screen reader users could not tell which workspace a link opens (WCAG 2.4.4, Link Purpose (In Context)).

Each action link now has aria-describedby pointing at its notification's message. The link keeps its visible text as its accessible name, so voice-control users can still say "View workspace" (2.5.3). The message wrapper is a plain div because react-markdown 9 does not accept an id; the Markdown classes moved onto it so the rendered output stays the same and only one wrapper is emitted.

Closes DEQ-364

Ticket Surface Visible change
DEQ-364 Navbar notifications popover, action buttons on each item None (ARIA only), so no screenshots
Decision log
  • aria-describedby over aria-label/aria-labelledby: both alternatives replace the link name with the full message, which breaks label-in-name and makes link names long. The description supplements the name, which is what the Deque guidance suggests as option 2.
  • One fix in InboxItem covers every action on every notification type; no backend template changes needed.
  • Known limit: screen reader link lists (NVDA Elements List) show only the name, which is the AAA criterion 2.4.9 and out of scope.
  • Self-review: frontend-deep-review, frontend-review (FE1 to FE10), frontend-accessibility, and test-audit found no blocking or should-fix issues. One nit (Markdown added a second wrapper div) was fixed.
  • Checks run locally: InboxItem.test.tsx (new test fails without the fix, passes with it), pnpm check, pnpm lint, pnpm format.

🤖 Generated by Coder Agents on behalf of @chrifro.

@chrifro
chrifro temporarily deployed to main November 17, 2026 13:37 — with GitHub Actions Inactive
@chrifro
chrifro temporarily deployed to main November 17, 2026 13:37 — with GitHub Actions Inactive
@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

DEQ-364

@chrifro
chrifro requested a review from aqandrew November 17, 2026 13:49
@chrifro
chrifro marked this pull request as ready for review November 17, 2026 13:49
@chrifro
chrifro temporarily deployed to main November 17, 2026 13:49 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
main — a145fbe6 Deployed Nov 17, 2026 by chrifro via cla #258673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant