Repository navigation
Conversation
… notification content
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification inbox action links such as "View workspace" read the same for every notification, so screen reader users could not tell which workspace a link opens (WCAG 2.4.4, Link Purpose (In Context)).
Each action link now has
aria-describedbypointing at its notification's message. The link keeps its visible text as its accessible name, so voice-control users can still say "View workspace" (2.5.3). The message wrapper is a plaindivbecausereact-markdown9 does not accept anid; the Markdown classes moved onto it so the rendered output stays the same and only one wrapper is emitted.Closes DEQ-364
Decision log
aria-describedbyoveraria-label/aria-labelledby: both alternatives replace the link name with the full message, which breaks label-in-name and makes link names long. The description supplements the name, which is what the Deque guidance suggests as option 2.InboxItemcovers every action on every notification type; no backend template changes needed.div) was fixed.InboxItem.test.tsx(new test fails without the fix, passes with it),pnpm check,pnpm lint,pnpm format.🤖 Generated by Coder Agents on behalf of @chrifro.