Skip to content

feat(coderd): enforce the chat project template limit - #32310

Open
jaaydenh wants to merge 4 commits into
mainfrom
chat-project-templates/enforcement
Open

jaaydenh wants to merge 4 commits into
mainfrom
chat-project-templates/enforcement

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Enforces the chat project template limit that #30754 stores. With limit_templates off, a project's chats can use every template their owner can use. With it on, they can only use attached templates that their owner can also access, and none when nothing is attached.

  • The limit is checked on every path that binds a workspace to a chat: chat creation, PATCH /chats/{chat} with workspace_id, and the workspace the create_workspace tool creates. A template the limit does not allow is rejected with a 400.
  • A PATCH that sets both project_id and workspace_id is checked against the project the chat moves to, and binds the workspace only if the move succeeds.
  • Workspace creation claims a prebuilt workspace by its preset alone, so a preset of another template is held to the limit like that template.
  • Subagent chats use their root chat's project.
  • Chats that already have a workspace keep it. A chat whose owner can no longer read its project is not limited.

coderd/x/chatd/ARCHITECTURE.md now says that the project move follows every write of the request except the workspace binding.

Stack (merge top to bottom):

@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T10:47:23.437707Z e79dbee Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4476753a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/exp_chats.go Resolved
Comment thread coderd/exp_chats.go Resolved
@jaaydenh
jaaydenh marked this pull request as ready for review November 17, 2026 08:09
@jaaydenh
jaaydenh requested a review from f0ssel November 17, 2026 08:10
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f70a0e16c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/x/chatd/ARCHITECTURE.md Resolved
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: e79dbee7a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jaaydenh added a commit that referenced this pull request Nov 17, 2026
Adds the database layer for attaching workspace templates to chat
projects: the schema, the queries, their authorization, and the audit
type. Nothing calls the new queries yet, and the existing create and
update handlers pass the new parameters unset. The API, the limit's
enforcement, and the agent tools follow in the PRs above.

- Attachments live in a `chat_project_templates` table (`project_id`,
`template_id`, `created_by`, `created_at`), deleted with the project or
the template. `chat_projects` gains `limit_templates` (default `false`),
`default_template_id`, `default_template_version_preset_id`, and
`default_parameters jsonb`. A project stores a default preset or default
parameter values, not both.
- `InsertChatProjectTemplates` needs project `update` and `use` on every
template. It skips templates that are already attached, and templates
outside the project's organization, so an attachment never crosses
organizations. `DeleteChatProjectTemplate` needs project `update` and
template `read`, and clears the project's default when it detaches the
default template. Both checks are in dbauthz.
- `GetChatProjectTemplatesByProjectIDs` is authorized through the
project, and leaves out deleted, deprecated, and agent-disabled
templates. It does not check the caller's access to each template, so
callers do that before they expose one.
- `UpdateChatProjectByID` changes the template settings only when the
request sets them, so an update that omits them cannot write back a
stale snapshot.
- `AuditableChatProjectTemplates` is the audit form of a project's
attached templates, logged as a write to the project. The new
`chat_projects` columns are tracked in the project's own audit diff,
with the default parameter values masked because they may hold
credentials.

**NOTE**: the migration adds one table and four columns and changes no
existing rows. Existing projects keep unlimited template access.

Stack (merge top to bottom):
- #32309 👈
- #30754
- #32310
- #30755
- #30756
- #30898
@jaaydenh
jaaydenh removed this pull request from stack #32311 November 18, 2026 08:06
@jaaydenh
jaaydenh added this pull request to stack #32380 November 18, 2026 08:07
Base automatically changed from chat-project-templates/api to main November 18, 2026 13:36
jaaydenh added a commit that referenced this pull request Nov 18, 2026
Adds the API for attaching workspace templates to a chat project, on the
schema and queries in #32309. A project can attach templates, turn on a
limit that restricts its chats to them, and set a default template with
either a default preset or default parameter values. Attaching a
template never grants access to it: every reader is checked against the
template's own sharing. This PR stores and returns `limit_templates`;
#32310 enforces it.

- The limit is opt-in. `limit_templates` is off unless a request turns
it on, which is what every existing project gets.
- Templates are attached and detached one at a time with `PUT` and
`DELETE /chats/projects/{project}/templates/{template}`, so a caller
never replaces a list they can only partly see. Attaching needs project
`update` and template `use`. Detaching needs project `update` and
template `read`, and a template the caller cannot read is reported as
not found. `POST /chats/projects` accepts `template_ids`,
`limit_templates`, and `default_template` for the new project.
- `PATCH /chats/projects/{project}` sets `limit_templates` and
`default_template`, and no longer changes which templates are attached.
The default must be an attached template the caller can read, and its
preset must belong to the template's active version. Default parameter
names and values are checked against that version for templates on the
classic parameter flow; dynamic parameters are checked when a workspace
is built. Detaching the default template clears the default.
- Project responses list only the attached templates the caller can
read, as `templates`, and count the rest as `hidden_template_count`.
`default_template` is omitted when the caller cannot read it. Deleted,
deprecated, and agent-disabled templates are left out and are not
counted as hidden.
- Editing uses `chat_project:update`, which the project owner and the
project `admin` ACL role have.
- Attaching and detaching are audited as writes to the project, with the
template list before and after, including the templates attached while
creating a project. Changes to `limit_templates` and the default
template are part of the project's own audit diff.

Not included: showing which project members lack access to an attached
template, and MCP server attachments.

Stack (merge top to bottom):
- #32309
- #30754 👈
- #32310
- #30755
- #32371
- #32372
- #30756
- #32373
- #32374
- #32375
- #30898
- #32376
- #32377
- #32378
- #32379
Check a chat project's template limit on every path that binds a
workspace to a chat: chat creation, PATCH /chats/{chat} with
workspace_id, and the workspace the create_workspace tool creates. A
workspace sent with a project move is checked against the project the
chat moves to and bound only after the move succeeds.
Workspace creation claims a prebuilt workspace by its preset alone, so a
create_workspace request that named an attached template and a preset of
another template could bind a workspace of that other template to a chat
in a limited project. The preset's template is now checked against the
project's limit as well.
…cture

The chat update endpoint now binds a workspace after the project move, so
the sentence that calls the move the request's last write is out of date.
Leave a note for the document's author in that section.
…workspace

Replace the note left for the document's author with the corrected
sentence: the project move follows every write except the workspace
binding, and a workspace sent with a move is bound only if the move
succeeds.
@jaaydenh
jaaydenh force-pushed the chat-project-templates/enforcement branch from a0fd658 to f1d971c Compare November 18, 2026 13:36

This branch was previously deployed

1 inactive deployment
main — f1d971ca Deployed Nov 18, 2026 by jaaydenh via cla #259471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant