Skip to content

ci: refuse to tag a commit that was already released (release/2.34) - #32244

Merged
kylecarbs merged 1 commit into
release/2.34from
backport/release-2.34-refuse-already-released
Nov 16, 2026
Merged

kylecarbs merged 1 commit into
release/2.34from
backport/release-2.34-refuse-already-released

Conversation

@kylecarbs

Copy link
Copy Markdown
Member

Backport of #32240 to release/2.34. Also gives release/2.34 a new commit to release.

version.sh fails when the released commit has two release tags, with a misleading "not tagged with an annotated tag" error. Re-releasing without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit as the previous release, failed at "Print version", and left a stray tag that only the release App can remove.

This fails before creating the tag instead, saying the commit was already released and to merge a new commit.

🤖 Generated with Claude Code

version.sh fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing a
release branch without a new commit tagged the same commit again,
failed at "Print version", and left a stray tag only the release App
can remove. Fail before creating the tag instead.
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @kylecarbs!

This PR is targeting the release/2.34 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@kylecarbs kylecarbs changed the title ci(release): refuse to tag a commit that was already released (release/2.34) ci: refuse to tag a commit that was already released (release/2.34) Nov 16, 2026
@kylecarbs
kylecarbs merged commit 0875659 into release/2.34 Nov 16, 2026
35 of 37 checks passed
@kylecarbs
kylecarbs deleted the backport/release-2.34-refuse-already-released branch November 16, 2026 05:37
@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

SEC-1436

This branch had an error being deployed

1 failed deployment
docs-preview — 8b8e0622 Deployed Nov 16, 2026 by kylecarbs via cleanup #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants