Skip to content

ci: refuse to tag a commit that was already released - #32240

Merged
kylecarbs merged 1 commit into
mainfrom
release-refuse-already-released
Nov 16, 2026
Merged

kylecarbs merged 1 commit into
mainfrom
release-refuse-already-released

Conversation

@kylecarbs

Copy link
Copy Markdown
Member

version.sh fails when the released commit has two release tags, with a misleading "not tagged with an annotated tag" error. Re-releasing without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit as the previous release, failed at "Print version", and left a stray tag that only the release App can remove.

This fails before creating the tag instead, saying the commit was already released and to merge a new commit.

🤖 Generated with Claude Code

version.sh fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing a
release branch without a new commit tagged the same commit again,
failed at "Print version", and left a stray tag only the release App
can remove. Fail before creating the tag instead.
@kylecarbs
kylecarbs requested a review from a team November 16, 2026 05:35
@kylecarbs
kylecarbs temporarily deployed to main November 16, 2026 05:35 — with GitHub Actions Inactive
@kylecarbs
kylecarbs temporarily deployed to main November 16, 2026 05:35 — with GitHub Actions Inactive
@kylecarbs kylecarbs changed the title ci(release): refuse to tag a commit that was already released ci: refuse to tag a commit that was already released Nov 16, 2026
@kylecarbs
kylecarbs temporarily deployed to main November 16, 2026 05:36 — with GitHub Actions Inactive
kylecarbs added a commit that referenced this pull request Nov 16, 2026
…32242)

Backport of #32240 to release/2.38. Also gives release/2.38 a new commit
to release.

`version.sh` fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing
without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit
as the previous release, failed at "Print version", and left a stray tag
that only the release App can remove.

This fails before creating the tag instead, saying the commit was
already released and to merge a new commit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
kylecarbs added a commit that referenced this pull request Nov 16, 2026
…32243)

Backport of #32240 to release/2.37. Also gives release/2.37 a new commit
to release.

`version.sh` fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing
without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit
as the previous release, failed at "Print version", and left a stray tag
that only the release App can remove.

This fails before creating the tag instead, saying the commit was
already released and to merge a new commit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
kylecarbs added a commit that referenced this pull request Nov 16, 2026
…32241)

Backport of #32240 to release/2.39. Also gives release/2.39 a new commit
to release.

`version.sh` fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing
without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit
as the previous release, failed at "Print version", and left a stray tag
that only the release App can remove.

This fails before creating the tag instead, saying the commit was
already released and to merge a new commit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
kylecarbs added a commit that referenced this pull request Nov 16, 2026
…32245)

Backport of #32240 to release/2.29. Also gives release/2.29 a new commit
to release.

`version.sh` fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing
without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit
as the previous release, failed at "Print version", and left a stray tag
that only the release App can remove.

This fails before creating the tag instead, saying the commit was
already released and to merge a new commit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
kylecarbs added a commit that referenced this pull request Nov 16, 2026
…32244)

Backport of #32240 to release/2.34. Also gives release/2.34 a new commit
to release.

`version.sh` fails when the released commit has two release tags, with a
misleading "not tagged with an annotated tag" error. Re-releasing
without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit
as the previous release, failed at "Print version", and left a stray tag
that only the release App can remove.

This fails before creating the tag instead, saying the commit was
already released and to merge a new commit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@kylecarbs
kylecarbs merged commit a97894b into main Nov 16, 2026
35 of 36 checks passed
@kylecarbs
kylecarbs deleted the release-refuse-already-released branch November 16, 2026 05:51
@kylecarbs
kylecarbs temporarily deployed to main November 16, 2026 05:52 — with GitHub Actions Inactive
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026

This branch had an error being deployed

1 failed and 1 inactive deployments
main — 13544277 Deployed Nov 16, 2026 by kylecarbs via cla #257300
docs-preview — 13544277 Deployed Nov 16, 2026 by kylecarbs via cleanup #95
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants