Skip to content

ci: sign dylibs with the KMS key in the release job on release/2.29 - #32237

Merged
sreya merged 1 commit into
release/2.29from
fix-dylib-hsm-signing-2.29
Nov 16, 2026
Merged

sreya merged 1 commit into
release/2.29from
fix-dylib-hsm-signing-2.29

Conversation

@sreya

@sreya sreya commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

The build-dylib job was the last consumer of the exportable PKCS#12 certificate secrets (AC_CERTIFICATE_P12_BASE64/AC_CERTIFICATE_PASSWORD) on this branch: the main release job was already migrated to the HSM-backed key in Google Cloud KMS, but the CoderVPN dylibs were still signed with the p12 on the macOS runner.

The HSM path cannot run on macOS: rcodesign reaches the KMS key through Google's Cloud KMS PKCS#11 library (libkmsp11.so), which is only published for Linux and Windows (GoogleCloudPlatform/kms-integrations#25). The dylib compile requires macOS, but the signing does not: rcodesign signs Mach-O files cross-platform, which is how every other darwin binary is already signed in the Linux release job.

Changes:

  • build-dylib builds the dylibs unsigned and no longer installs rcodesign or touches any certificate secrets.
  • The release job gains a Sign dylibs step between Download dylibs and Insert dylibs, reusing the exact KMS signing setup (certificate PEM, libkmsp11.so, PKCS#11 config, release-signer credentials from the existing auth step) already prepared earlier in that job for the darwin binaries.

After this lands (and the equivalent on release/2.30/release/2.31), nothing references the old p12 secrets and they can be deleted.

Validation: actionlint clean. The identical sign-on-Linux mechanism is what signed the darwin binaries in v2.39.2 (verified end-to-end incl. notarization tickets).

The build-dylib job was still signing the CoderVPN dylibs with the
exportable PKCS#12 certificate from GitHub secrets. The signing key now
lives in Google Cloud KMS, reached through the Cloud KMS PKCS#11
library, which has no macOS build, so the macOS runner cannot sign the
HSM way.

Build the dylibs unsigned on the macOS runner and sign them in the
release job on Linux instead, between downloading the dylib artifacts
and inserting them into the site assets. rcodesign signs Mach-O files
cross-platform, and the release job already prepares the certificate,
PKCS#11 library, config, and release-signer credentials for the other
darwin binaries. This removes the last use of the AC_CERTIFICATE_P12
secrets on this branch.
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @sreya!

This PR is targeting the release/2.29 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@sreya
sreya marked this pull request as ready for review November 16, 2026 04:35
@sreya
sreya requested a review from a team November 16, 2026 04:35
@sreya
sreya merged commit d88b008 into release/2.29 Nov 16, 2026
32 checks passed
@sreya
sreya deleted the fix-dylib-hsm-signing-2.29 branch November 16, 2026 04:35
@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

SEC-1433

This branch had an error being deployed

1 failed deployment
docs-preview — 802e7a3e Deployed Nov 16, 2026 by sreya via cleanup #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants