Repository navigation
ci: sign dylibs with the KMS key in the release job on release/2.29 - #32237
Merged
Merged
Conversation
The build-dylib job was still signing the CoderVPN dylibs with the exportable PKCS#12 certificate from GitHub secrets. The signing key now lives in Google Cloud KMS, reached through the Cloud KMS PKCS#11 library, which has no macOS build, so the macOS runner cannot sign the HSM way. Build the dylibs unsigned on the macOS runner and sign them in the release job on Linux instead, between downloading the dylib artifacts and inserting them into the site assets. rcodesign signs Mach-O files cross-platform, and the release job already prepares the certificate, PKCS#11 library, config, and release-signer credentials for the other darwin binaries. This removes the last use of the AC_CERTIFICATE_P12 secrets on this branch.
Contributor
|
👋 Hey @sreya! This PR is targeting the Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format: If this is not a bug fix, it likely should not target a release branch. |
kylecarbs
approved these changes
Nov 16, 2026
deansheather
approved these changes
Nov 16, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-dylibjob was the last consumer of the exportable PKCS#12 certificate secrets (AC_CERTIFICATE_P12_BASE64/AC_CERTIFICATE_PASSWORD) on this branch: the main release job was already migrated to the HSM-backed key in Google Cloud KMS, but the CoderVPN dylibs were still signed with the p12 on the macOS runner.The HSM path cannot run on macOS: rcodesign reaches the KMS key through Google's Cloud KMS PKCS#11 library (
libkmsp11.so), which is only published for Linux and Windows (GoogleCloudPlatform/kms-integrations#25). The dylib compile requires macOS, but the signing does not: rcodesign signs Mach-O files cross-platform, which is how every other darwin binary is already signed in the Linux release job.Changes:
build-dylibbuilds the dylibs unsigned and no longer installs rcodesign or touches any certificate secrets.libkmsp11.so, PKCS#11 config, release-signer credentials from the existing auth step) already prepared earlier in that job for the darwin binaries.After this lands (and the equivalent on
release/2.30/release/2.31), nothing references the old p12 secrets and they can be deleted.Validation:
actionlintclean. The identical sign-on-Linux mechanism is what signed the darwin binaries in v2.39.2 (verified end-to-end incl. notarization tickets).