Repository navigation
ci(.github/workflows): set dylib build version from input on release/2.29 - #32235
Merged
Merged
Conversation
Contributor
|
👋 Hey @sreya! This PR is targeting the Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format: If this is not a bug fix, it likely should not target a release branch. |
deansheather
approved these changes
Nov 16, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
build-dylibfailure in the v2.29.28 release dispatch: https://github.com/coder/coder/actions/runs/43800768746 — the "Build dylibs" step failed withERROR: version.sh: the current commit is not tagged with an annotated tag(exit 143).Root cause is a chicken-and-egg introduced by the App-created tag flow (#32212, backported as #32217): the annotated release tag is now created inside the
releasejob afterenvironment: releaseapproval, but on 2.29releasehasneeds: [build-dylib, check-perms]because it downloads the dylib artifacts. Sobuild-dylibruns before the tag exists, while the workflow-levelCODER_RELEASE: ${{ !inputs.dry_run }}makesscripts/version.shrequire an annotated tag at HEAD. Under the old flow the release wizard pushed the tag before dispatching, so this never fired.mainhas no dylib pipeline, so there is nothing to backport — this is a 2.29-only fix.Fix: add a "Set version for release builds" step to
build-dylib(right after "Fetch git tags"), gated on!inputs.dry_run, that validatesinputs.versionagainst^v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$and exportsCODER_FORCE_VERSION=${INPUT_VERSION#v}.scripts/version.shshort-circuits onCODER_FORCE_VERSIONbefore any tag inspection, so the dylib build no longer depends on the not-yet-created tag. This is safe because thereleasejob's existing "Verify release input" step independently checks that the tag it creates/uses matches the sameinputs.version— the dylibs are therefore always stamped with the same version the release is verified against. Dry runs are unaffected (step skipped; version.sh keeps producing a dev version).Scanned the job graph for other pre-tag consumers of version.sh:
check-permsis a pure github-script permission check (no checkout),build-dylibis fixed here, and everypublish-*job hasneeds: release, so they run after the tag exists. The failed run created no tag (thereleasejob never ran), so re-dispatching v2.29.28 on this branch is clean.Requested by @sreya.