Skip to content

ci(.github/workflows): set dylib build version from input on release/2.29 - #32235

Merged
sreya merged 1 commit into
release/2.29from
fix/build-dylib-version-to-2.29
Nov 16, 2026
Merged

sreya merged 1 commit into
release/2.29from
fix/build-dylib-version-to-2.29

Conversation

@sreya

@sreya sreya commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes the build-dylib failure in the v2.29.28 release dispatch: https://github.com/coder/coder/actions/runs/43800768746 — the "Build dylibs" step failed with ERROR: version.sh: the current commit is not tagged with an annotated tag (exit 143).

Root cause is a chicken-and-egg introduced by the App-created tag flow (#32212, backported as #32217): the annotated release tag is now created inside the release job after environment: release approval, but on 2.29 release has needs: [build-dylib, check-perms] because it downloads the dylib artifacts. So build-dylib runs before the tag exists, while the workflow-level CODER_RELEASE: ${{ !inputs.dry_run }} makes scripts/version.sh require an annotated tag at HEAD. Under the old flow the release wizard pushed the tag before dispatching, so this never fired. main has no dylib pipeline, so there is nothing to backport — this is a 2.29-only fix.

Fix: add a "Set version for release builds" step to build-dylib (right after "Fetch git tags"), gated on !inputs.dry_run, that validates inputs.version against ^v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$ and exports CODER_FORCE_VERSION=${INPUT_VERSION#v}. scripts/version.sh short-circuits on CODER_FORCE_VERSION before any tag inspection, so the dylib build no longer depends on the not-yet-created tag. This is safe because the release job's existing "Verify release input" step independently checks that the tag it creates/uses matches the same inputs.version — the dylibs are therefore always stamped with the same version the release is verified against. Dry runs are unaffected (step skipped; version.sh keeps producing a dev version).

Scanned the job graph for other pre-tag consumers of version.sh: check-perms is a pure github-script permission check (no checkout), build-dylib is fixed here, and every publish-* job has needs: release, so they run after the tag exists. The failed run created no tag (the release job never ran), so re-dispatching v2.29.28 on this branch is clean.

Requested by @sreya.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @sreya!

This PR is targeting the release/2.29 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@sreya
sreya marked this pull request as ready for review November 16, 2026 04:03
@sreya
sreya requested a review from a team November 16, 2026 04:03
@sreya
sreya merged commit f936b0d into release/2.29 Nov 16, 2026
34 checks passed
@sreya
sreya deleted the fix/build-dylib-version-to-2.29 branch November 16, 2026 04:07
@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

SEC-1433

This branch had an error being deployed

1 failed deployment
docs-preview — 41516afe Deployed Nov 16, 2026 by sreya via cleanup #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants