Skip to content

ci: backport release signing changes to release/2.38 (#32209, #32211) - #32225

Merged
sreya merged 2 commits into
release/2.38from
backport/32209-32211-to-2.38
Nov 16, 2026
Merged

sreya merged 2 commits into
release/2.38from
backport/32209-32211-to-2.38

Conversation

@sreya

@sreya sreya commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Backports release workflow changes from main so releases cut from release/2.38 use the current signing flow:

Each commit is a git cherry-pick -x of the original commit on main. Both picks applied cleanly and are patch-identical to the originals (verified with git patch-id --stable); no ci.yaml adaptation was needed.

Conflicts: none.

Validation: go build ./scripts/gpgkms/ and go test ./scripts/gpgkms/ pass (ok github.com/coder/coder/v2/scripts/gpgkms); bash -n scripts/sign_with_gpg.sh scripts/sign_darwin.sh scripts/build_go.sh passes; release.yaml, ci.yaml, and .github/actions/install-rcodesign/action.yml parse as valid YAML (actionlint unavailable locally). The residual release.yaml diff vs main is fully attributed to non-backported commits: pinned-action version drift from dependabot bumps #31341 (harden-runner, setup-java), #31052 (create-github-app-token), #30776 (linear-release-action, upload-artifact ×2), plus the retry.sh --timeout 120 change from #30889. All signing-related files (scripts/gpgkms/, sign_with_gpg.sh, sign_darwin.sh, build_go.sh, .github/actions/install-rcodesign/) are byte-identical to main.

Requested by @sreya.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @sreya!

This PR is targeting the release/2.38 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@sreya
sreya marked this pull request as ready for review November 16, 2026 02:49
@sreya
sreya requested a review from a team November 16, 2026 02:49
@sreya
sreya merged commit e311b35 into release/2.38 Nov 16, 2026
60 of 62 checks passed
@sreya
sreya deleted the backport/32209-32211-to-2.38 branch November 16, 2026 02:57
@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

SEC-1432

This branch had an error being deployed

1 failed deployment
docs-preview — 83c2896b Deployed Nov 16, 2026 by sreya via cleanup #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants