Repository navigation
ci: backport release signing changes to release/2.38 (#32209, #32211) - #32225
Merged
Merged
Conversation
Contributor
|
👋 Hey @sreya! This PR is targeting the Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format: If this is not a bug fix, it likely should not target a release branch. |
kylecarbs
approved these changes
Nov 16, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports release workflow changes from
mainso releases cut fromrelease/2.38use the current signing flow:Each commit is a
git cherry-pick -xof the original commit on main. Both picks applied cleanly and are patch-identical to the originals (verified withgit patch-id --stable); no ci.yaml adaptation was needed.Conflicts: none.
Validation:
go build ./scripts/gpgkms/andgo test ./scripts/gpgkms/pass (ok github.com/coder/coder/v2/scripts/gpgkms);bash -n scripts/sign_with_gpg.sh scripts/sign_darwin.sh scripts/build_go.shpasses;release.yaml,ci.yaml, and.github/actions/install-rcodesign/action.ymlparse as valid YAML (actionlint unavailable locally). The residualrelease.yamldiff vsmainis fully attributed to non-backported commits: pinned-action version drift from dependabot bumps #31341 (harden-runner, setup-java), #31052 (create-github-app-token), #30776 (linear-release-action, upload-artifact ×2), plus theretry.sh --timeout 120change from #30889. All signing-related files (scripts/gpgkms/,sign_with_gpg.sh,sign_darwin.sh,build_go.sh,.github/actions/install-rcodesign/) are byte-identical tomain.Requested by @sreya.