Repository navigation
ci(.claude/skills/doc-check): leave the deterministic checks and tests to CI in CI reviews - #32197
Merged
nickvigilante merged 1 commit intoNov 13, 2026
Conversation
…s to CI in CI reviews Step 3 of the doc-check skill tells the review to run make lint/emdash, make lint/docs-html, make lint/docs-manifest, markdownlint, and Vale. The lint and lint-docs jobs in ci.yaml already run each of them on the same PR, and both jobs are required. In the review workspace they cost model calls and tool time, and the tools are often missing. A CI review now skips the step and runs no test suite, build, or generator. The other modes keep the step, because an author runs them before CI does. Linear: DOCS-1751
bpmct
approved these changes
Nov 13, 2026
nickvigilante
deleted the
vigilante/docs-1751-doc-check-leave-the-deterministic-checks
branch
November 13, 2026 22:07
nickvigilante
temporarily deployed
to
docs-preview
November 13, 2026 22:07 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 3 of the doc-check skill has the review run lint that CI already runs on the same PR.
In CI review mode the skill now skips that step, and runs no test suite, build, or generator.
Changes
SKILL.mdstep 3 starts with a CI review rule: skip the step, run no test suite, build, or generator, and record the skip in the trace.Every check the step lists already runs in
ci.yaml:make lint/emdash,make lint/docs-html,make lint/docs-manifest,make lint/markdownlint, throughmake lintlint-docs, throughpnpm check-docslint-docsBoth jobs are in the
requiredcheck, so a failing check blocks the merge without the review reporting it.Why
On 2026-11-13 a review of #32185 took 215 seconds.
113 of them went to two tool calls that ran lint and the PR's own two shell test suites, each suite twice.
Each of those calls is also one more model call that can wait in the queue.
Testing
markdownlint-cli2andmarkdown-table-formatter --checkpass onSKILL.md.A CI review reads the skill from the base branch, so this text takes effect only after it merges.
3580c80with this text plus ci: report only wrong, missing, and broken findings in CI doc-check reviews #32199, posting nothing.Both skipped step 3, ran no lint, test, or build, and wrote the
deterministic_checksentry as the step asks.The replays ran on a cloud model with no sub-agents, not on the shared model.
Not in this PR
Linear: DOCS-1751
Generated by Coder Agents on behalf of @nickvigilante.