Skip to content

ci(.claude/skills/doc-check): leave the deterministic checks and tests to CI in CI reviews - #32197

Merged
nickvigilante merged 1 commit into
mainfrom
vigilante/docs-1751-doc-check-leave-the-deterministic-checks
Nov 13, 2026
Merged

nickvigilante merged 1 commit into
mainfrom
vigilante/docs-1751-doc-check-leave-the-deterministic-checks

Conversation

@nickvigilante

@nickvigilante nickvigilante commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Step 3 of the doc-check skill has the review run lint that CI already runs on the same PR.
In CI review mode the skill now skips that step, and runs no test suite, build, or generator.

Changes

  • SKILL.md step 3 starts with a CI review rule: skip the step, run no test suite, build, or generator, and record the skip in the trace.
  • The other modes keep the step, because an author runs them before CI does.

Every check the step lists already runs in ci.yaml:

Check CI job
make lint/emdash, make lint/docs-html, make lint/docs-manifest, make lint/markdown lint, through make lint
markdownlint and the table format check lint-docs, through pnpm check-docs
Vale, advisory lint-docs

Both jobs are in the required check, so a failing check blocks the merge without the review reporting it.

Why

On 2026-11-13 a review of #32185 took 215 seconds.
113 of them went to two tool calls that ran lint and the PR's own two shell test suites, each suite twice.
Each of those calls is also one more model call that can wait in the queue.

Testing

Not in this PR

  • Passing CI's check results into the review prompt.
  • The Copy Editor persona asks for these results so it does not repeat them, and a CI review now has none to give it.

Linear: DOCS-1751

Generated by Coder Agents on behalf of @nickvigilante.

…s to CI in CI reviews

Step 3 of the doc-check skill tells the review to run make lint/emdash,
make lint/docs-html, make lint/docs-manifest, markdownlint, and Vale.
The lint and lint-docs jobs in ci.yaml already run each of them on the
same PR, and both jobs are required. In the review workspace they cost
model calls and tool time, and the tools are often missing.

A CI review now skips the step and runs no test suite, build, or
generator. The other modes keep the step, because an author runs them
before CI does.

Linear: DOCS-1751
@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

DOCS-1751

@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 21:46 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 21:46 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 21:56 — with GitHub Actions Inactive
@bpmct
bpmct marked this pull request as ready for review November 13, 2026 21:57
@bpmct
bpmct temporarily deployed to main November 13, 2026 21:58 — with GitHub Actions Inactive
@nickvigilante
nickvigilante merged commit 7d8eba8 into main Nov 13, 2026
60 of 61 checks passed
@nickvigilante
nickvigilante deleted the vigilante/docs-1751-doc-check-leave-the-deterministic-checks branch November 13, 2026 22:07
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 22:07 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 22:07 — with GitHub Actions Inactive
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2026

This branch was previously deployed

2 inactive deployments
docs-preview — 42120ebf Deployed Nov 13, 2026 by nickvigilante via cleanup #63
main — 42120ebf Deployed Nov 13, 2026 by nickvigilante via cla #257040
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants