Skip to content

fix: bump bundled terraform to 1.17.2 (#32110) for 2.29 - #32182

Merged
droopy4096 merged 2 commits into
release/2.29from
backport/32110-to-2.29
Nov 13, 2026
Merged

droopy4096 merged 2 commits into
release/2.29from
backport/32110-to-2.29

Conversation

@coder-backporter-app

@coder-backporter-app coder-backporter-app Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Backport of #32110

Original PR: #32110 — fix: bump bundled terraform to 1.17.2
Merge commit: 872105c
Requested by: @droopy4096

Also includes a backport of #29279 (refresh dogfood apt keyrings, rename google-cloud-sdk to google-cloud-cli) so the dogfood build_image job can pass on release/2.29. HashiCorp's apt repo is now signed with a key (FC9CA96ACA026560) missing from this branch's keyring.

@coder-backporter-app coder-backporter-app Bot added the backport/v2.29 Backport PR targeting release/2.29 label Nov 13, 2026
Bumps the bundled Terraform from 1.17.1 to
[1.17.2](https://github.com/hashicorp/terraform/releases/tag/v1.17.2)
(released 2026-11-11). 1.17.2 pins `klauspost/compress` v1.20.2, which
contains the fix for
[GHSA-fpmh-frq8-7rj8](GHSA-fpmh-frq8-7rj8)
/ [GO-2026-6865](https://pkg.go.dev/vuln/GO-2026-6865) (panic in the
zstd decoder on a crafted frame). 1.17.1 pins v1.19.1.

Iron Bank reports GO-2026-6865 against `/opt/terraform/terraform` in
`coder/coder-enterprise/coder-service-2:2.38.7` (High). The Iron Bank
image takes its Terraform from the version coder bundles, so this bump
is how that finding goes away.

This is a patch bump, so `maxTerraformVersion` stays at 1.17.9. It does
not change the Go toolchain Terraform is built with (still go1.26.10) or
its `go-getter` pin (still v1.8.6).

## Changes

Same file set as #30516:

- `provisioner/terraform/install.go`: `TerraformVersion`
- `install.sh`, `scripts/Dockerfile.base`
- `mise.toml`, `mise.lock` (checksums from HashiCorp's
`terraform_1.17.2_SHA256SUMS`)
- `flake.nix` (fetchurl SRI hashes derived from the same SHA256SUMS)
- `docs/install/prepare/airgap.md`
- `provisioner/terraform/testdata/generation.sha1`: fixture fingerprint,
regenerated with `generate.sh --if-needed`. No plan or state fixture
changed.

I checked the checksum conversion first by deriving the 1.17.1 values
from `terraform_1.17.1_SHA256SUMS`; it reproduces every value currently
in `flake.nix` and `mise.lock`.

## Verification

```
$ mise install terraform        # mise.lock checksums verified against the download
$ mise exec -- terraform version
Terraform v1.17.2 on linux_amd64
$ ./provisioner/terraform/testdata/generate.sh --if-needed
only generation.sha1 changed
$ go test ./provisioner/terraform/ -run 'TestInstall|Version|Golden' -count=1
ok  github.com/coder/coder/v2/provisioner/terraform  (75 tests passed, 0 failed)
```

`flake.nix` was not evaluated with Nix; its hashes come from the same
SHA256SUMS as `mise.lock`.

## AI disclosure

Prepared with an AI coding agent on behalf of @droopy4096. The agent ran
the verification above; a human review is still needed before merge.

Conflict resolution for release/2.29: applied the same 1.17.1 -> 1.17.2
version and checksum bump to the files this branch used for the 1.17.1
backport, since its layout differs from main.

(cherry picked from commit 872105c)
@coder
coder Bot force-pushed the backport/32110-to-2.29 branch from b59ec62 to 39534f3 Compare November 13, 2026 16:50
@coder
coder Bot requested a review from jdomeracki-coder as a code owner November 13, 2026 16:50
@coder coder Bot changed the title fix: bump bundled terraform to 1.17.2 (#32110) (conflicts) fix: bump bundled terraform to 1.17.2 (#32110) for 2.29 Nov 13, 2026
…(2.29)

Backport of #29279 to release/2.29, adapted to this branch's single
dogfood/coder/Dockerfile layout.

HashiCorp signs its apt repo with a new key (FC9CA96ACA026560) that the
shipped hashicorp.gpg lacks, so apt-get update fails and build_image
breaks. This copies the refreshed hashicorp, github-cli and google-cloud
keyrings from main and renames google-cloud-sdk and
google-cloud-sdk-datastore-emulator to their google-cloud-cli names,
which Google now publishes instead.

@droopy4096 droopy4096 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both cherry-picks look good to me.

@droopy4096
droopy4096 merged commit 990a33a into release/2.29 Nov 13, 2026
38 checks passed
@droopy4096
droopy4096 deleted the backport/32110-to-2.29 branch November 13, 2026 20:51
@droopy4096
droopy4096 temporarily deployed to docs-preview November 13, 2026 20:51 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
docs-preview — 2857b2b4 Deployed Nov 13, 2026 by droopy4096 via cleanup #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v2.29 Backport PR targeting release/2.29

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants