Repository navigation
fix: bump bundled terraform to 1.17.2 (#32110) for 2.34 - #32179
Merged
Merged
Conversation
Bumps the bundled Terraform from 1.17.1 to [1.17.2](https://github.com/hashicorp/terraform/releases/tag/v1.17.2) (released 2026-11-11). 1.17.2 pins `klauspost/compress` v1.20.2, which contains the fix for [GHSA-fpmh-frq8-7rj8](GHSA-fpmh-frq8-7rj8) / [GO-2026-6865](https://pkg.go.dev/vuln/GO-2026-6865) (panic in the zstd decoder on a crafted frame). 1.17.1 pins v1.19.1. Iron Bank reports GO-2026-6865 against `/opt/terraform/terraform` in `coder/coder-enterprise/coder-service-2:2.38.7` (High). The Iron Bank image takes its Terraform from the version coder bundles, so this bump is how that finding goes away. This is a patch bump, so `maxTerraformVersion` stays at 1.17.9. It does not change the Go toolchain Terraform is built with (still go1.26.10) or its `go-getter` pin (still v1.8.6). ## Changes Same file set as #30516: - `provisioner/terraform/install.go`: `TerraformVersion` - `install.sh`, `scripts/Dockerfile.base` - `mise.toml`, `mise.lock` (checksums from HashiCorp's `terraform_1.17.2_SHA256SUMS`) - `flake.nix` (fetchurl SRI hashes derived from the same SHA256SUMS) - `docs/install/prepare/airgap.md` - `provisioner/terraform/testdata/generation.sha1`: fixture fingerprint, regenerated with `generate.sh --if-needed`. No plan or state fixture changed. I checked the checksum conversion first by deriving the 1.17.1 values from `terraform_1.17.1_SHA256SUMS`; it reproduces every value currently in `flake.nix` and `mise.lock`. ## Verification ``` $ mise install terraform # mise.lock checksums verified against the download $ mise exec -- terraform version Terraform v1.17.2 on linux_amd64 $ ./provisioner/terraform/testdata/generate.sh --if-needed only generation.sha1 changed $ go test ./provisioner/terraform/ -run 'TestInstall|Version|Golden' -count=1 ok github.com/coder/coder/v2/provisioner/terraform (75 tests passed, 0 failed) ``` `flake.nix` was not evaluated with Nix; its hashes come from the same SHA256SUMS as `mise.lock`. ## AI disclosure Prepared with an AI coding agent on behalf of @droopy4096. The agent ran the verification above; a human review is still needed before merge. Conflict resolution for release/2.34: applied the same 1.17.1 -> 1.17.2 version and checksum bump to the files this branch used for the 1.17.1 backport, since its layout differs from main. (cherry picked from commit 872105c)
coder
Bot
force-pushed
the
backport/32110-to-2.34
branch
from
November 13, 2026 16:50
55e0540 to
9d89551
Compare
…29279) The dogfood base image has been failing to build on `main` since the 11th, on both the 22.04 and 26.04 legs: https://github.com/coder/coder/actions/runs/34796906035 ``` Err:3 https://apt.releases.hashicorp.com jammy InRelease The following signatures couldn't be verified because the public key is not available: NO_PUBKEY FC9CA96ACA026560 E: The repository 'https://apt.releases.hashicorp.com jammy InRelease' is not signed. ``` HashiCorp started signing their apt repo with a new key on the 9th. The `hashicorp.gpg` we ship only has the 2023 key, and as far as I can tell it hasn't been refreshed since it was first added. To fix, we'll just re-run `update-keys.sh` in both distro directories. This also picks up newer `github-cli.gpg` and `google-cloud.gpg` keyrings, neither of which were actually failing. It turns out that was masking a second failure, as `apt-get update` was aborting the `RUN` before `apt-get install` ever ran. Google no longer publishes `google-cloud-sdk` (or `google-cloud-sdk-datastore-emulator`) in the `cloud-sdk` suite; they're now `google-cloud-cli` and `google-cloud-cli-datastore-emulator`. So, we'll rename them in both `Dockerfile.base` files, and in `preferences.d/google-cloud`, which pins everything from that repo to priority 1 unless allowlisted by name. (cherry picked from commit 32bde78)
droopy4096
approved these changes
Nov 13, 2026
zenithwolf1000
approved these changes
Nov 13, 2026
droopy4096
temporarily deployed
to
docs-preview
November 13, 2026 20:51 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32110
Original PR: #32110 — fix: bump bundled terraform to 1.17.2
Merge commit: 872105c
Requested by: @droopy4096
Also includes a backport of #29279 (refresh dogfood apt keyrings, rename google-cloud-sdk to google-cloud-cli) so the dogfood
build_imagejob can pass on release/2.34. HashiCorp's apt repo is now signed with a key (FC9CA96ACA026560) missing from this branch's keyring.