Repository navigation
fix: resolve docs and code conflicts found in the main docs audit - #32158
Conversation
The packaged /etc/coder.d/coder.env set CODER_HTTP_ADDRESS and the CODER_TLS_* options to empty strings. An empty value overrides the built-in default, so an untouched package install did not listen on 127.0.0.1:3000 as the install docs say. Comment the lines out so the defaults apply until an operator sets a value. Add a test that parses the file, with LF and CRLF line endings, and checks that the default HTTP address survives. Fixes DOCS-1587
The docs say that an empty --log-human value, or /dev/null, disables human-readable logging. With no other sink set, the builder instead failed with "no loggers provided". Track whether any sink option was given, and return that error only when none was, so a deliberately silent configuration starts. Fixes DOCS-1652
…ndependent A coder_env with merge_strategy = "error" failed the build only when an earlier entry had already set the same name. If the "error" entry came first, a later entry replaced it silently. Resource order is not something a template author controls, so count the names up front and fail whenever an "error" entry shares its name with another entry. Fixes DOCS-1669
The exec wrapper dropped its effective capabilities and then called setpriority, so a negative CODER_PROC_NICE_SCORE failed without CAP_SYS_NICE even when the agent binary had that capability. Set the nice value first. The capabilities are still dropped before the child command runs. Fixes DOCS-1687
The docs and agentexec treat the variable as enabled when it is set to any value, including an empty one. The agent command only logged that priority management was enabled when the value was not empty. Fixes DOCS-1709
The option help said the max deadline is rounded up to be within the quiet hours window. The scheduler sets it to the start of the user's next quiet hours window. Regenerate the CLI reference, the configuration reference, and the golden files. Fixes DOCS-1664
An audit of main compared the docs with the code and found pages that state behavior, defaults, names, roles, commands, or examples that the code does not support. Correct each page to describe what the code does, and keep related pages consistent with each other. The issue list is in the pull request description.
|
/coder-agents-review |
|
Chat: Review posted | View chat Review history
deep-review v0.13.0 | Round 7 | Last posted: Round 7, 73 findings (5 P2, 17 P3, 37 P4, 14 Nit), COMMENT. Review Finding inventoryFindings
Contested and acknowledgedCRF-4 (P4, cli/agent.go:268) - CLI duplicates NewExecer's process priority decision
CRF-5 (Nit, cli/agent.go:272) - Log field
|
| Reviewer | Focus |
|---|---|
| Bisky | tests |
| Chopper | ops/errors |
| Churn-guard | change verification |
| Ging | language modernization |
| Gon | naming |
| Hisoka | edge cases |
| Killua | perf |
| Kite | change integrity |
| Knov | contracts |
| Knuckle | SQL |
| Komugi | flake/determinism |
| Kurapika | security |
| Law | decomposition |
| Leorio | docs |
| Luffy | product |
| Mafu-san | process |
| Mafuuu | contracts |
| Melody | dispatch/pairing |
| Meruem | structural |
| Nami | frontend |
| Netero | mechanical checks |
| Pariston | premise testing |
| Pen-botter | product gaps |
| Razor | verification |
| Robin | duplication |
| Ryosuke | Go arch |
| Takumi | concurrency |
| Zoro | shape |
🤖 Managed by Coder Agents.
There was a problem hiding this comment.
This PR fixes 106 docs and code conflicts from the docs audit, including five code fixes. Findings: 5 P2, 13 P3, 18 P4, 9 Nit.
The three P2s on the code commits (the agent-exec nice ordering, and the two on the error merge strategy) need a code owner decision; the PR description already offers to split those commits out.
Out of scope (needs a ticket or explicit acceptance by a human):
docs/admin/external-auth.md:287,:306,:383,:390, anddocs/coder-agents/platform-controls/git-providers.md:23,:66: unanchored provider regex examples; a look-alike host receives the provider token.coderd/provisionerdserver/provisionerdserver.go:2324: everycoder_envcheck inMergeExtraEnvsruns afterterraform apply; a template defect found at build time leaves applied infrastructure behind a failed build.coderd/provisionerdserver/provisionerdserver.go:3615:MergeExtraEnvsaccepts a pre-filled map, but both callers pass an empty one; theexistsbranch is reachable only from tests.cli/server.go:453: an emptyCODER_HTTP_ADDRESSwith TLS off stops the server; any env file or container spec from before v2.34.0 with that line fails at startup.agent/agentexec/cli_linux.go:99:writeOOMScoreAdjruns afterdropEffectiveCaps; a negativeCODER_PROC_OOM_SCOREbelow the agent's minimum is likely not applied, whileprocess-priority.md:32documents-1000to1000(unverified).docs/templates/extending-templates/process-priority.md:17: addingCAP_SYS_NICEthrough a container security context does not make it effective for a non-root agent, so the nice fix does not apply to that documented setup (unverified).docs/templates/extending-templates/process-priority.md:113: says the agent strips allCODER_PROC_*variables;cli_linux.go:124-126strips three, so others reach user processes.docs/templates/extending-templates/process-priority.md:31: contains an emdash, which the repository forbids.docs/admin/networking/reverse-proxy-caddy.md:134: the standalone Caddyfile has notls { on_demand }block oremail, so Caddy cannot get a certificate for*.coder.example.com, and the bullets describe anemail@example.comvalue the snippet lacks.helm/provisioner/values.yaml:136: says resources are not set by default, buthelm/libcoder/templates/_coder.yaml:88-96applies 2000m and 4096Mi; the chart comment contradicts the docs this PR fixes.codersdk/deployment.go:3560: the Default Token Lifetime help says it applies when a token is created without a duration, butcoder tokens createwithout--lifetimesendsMaxTokenLifetime; lowering the default does not shorten CLI tokens.docs/install/prepare/airgap.md:91: the mirror stores the AWS provider underaws/aws, but its address ishashicorp/aws; Terraform will not find the bundled provider.docs/admin/integrations/devcontainers/envbuilder/add-envbuilder.md:71: the samezip templates.zip Dockerfile main.tfcommand this PR fixes intemplate-from-scratch.md; it skips subdirectories.agent/agent.go:81:EnvProcPrioMgmtandEnvProcOOMScoreduplicate theagentexecconstants and have no references; the copies can drift.agent/agentexec/cli_linux_test.go:86: theCapabilitiessubtest's fixedcapsdirectory fails under-count=2.agent/agentexec/cli_linux_test.go:83:Capabilitiespasses even when the file capability has no effect, so it does not prove dumpable handling in user-namespaced environments.agent/agentexec/cli_linux.go:101: the OOM score copy of the warning comment has the typo "inappriopriate".docs/coder-agents/index.md:281anddocs/coder-agents/architecture.md:194: theread_skillavailability rule is stated on both pages; the next change must find both.cli/clilog/clilog.go:153: the error names/dev/nullas the remedy but not the empty value thatlogs.mdnow documents.
Notes:
coderd/provisionerdserver/mergeenvs_internal_test.go:12:TestEncodeSubagentEnvsErrorStrategyrepeats threeTestMergeExtraEnvscases; one case is enough to show the subagent path callsMergeExtraEnvs.coder.env:5: commenting out the threeCODER_TLS_*lines changes no behavior, because empty values equal their defaults; onlyCODER_HTTP_ADDRESScaused the startup failure, though the PR table row implies all four lines did.
docs/workspaces/speed-up-templates.md:83
P4 [CRF-17] The new text says to set coder.resources in the values file, but the block still ends with a … line, so pasting it into a values file breaks YAML parsing. (Pen Botter)
yaml.safe_load on the block fails with while scanning a simple key. Remove the trailing … line.
🤖
docs/install/server/rpm.md:85
P3 [CRF-47] The page says coder.service does not start while coder.env is empty, but after this PR an untouched install starts and listens on 127.0.0.1:3000. (Pen Botter)
ConditionFileNotEmpty checks the file size and the packaged file is never empty; before this PR the empty CODER_HTTP_ADDRESS= line made the server exit, so the sentence used to match the outcome. Rewrite it to say the service starts with the packaged defaults, and that the configuration should be set before starting it.
🤖
🤖 This review was automatically generated with Coder Agents.
| logger.Info(ctx, "process priority management enabled", | ||
| slog.F("env_var", agentexec.EnvProcPrioMgmt), | ||
| slog.F("enabled", enabled), | ||
| slog.F("enabled", value), |
There was a problem hiding this comment.
Nit [CRF-5] The log field enabled holds the raw environment value, so an empty variable logs process priority management enabled enabled="". (Netero)
Name the field value, or log the bool.
🤖
There was a problem hiding this comment.
Not changed. The enabled field name predates this PR, and a rename could break existing log queries. Left open for the code owner.
Posted by Coder Agents on behalf of @nickvigilante.
This reverts commit 76ec1ac. The wrapper drops its effective capabilities first on purpose, so that a caller cannot use the capabilities of the agent binary. With the nice value applied first, any local process could run `coder agent-exec --coder-nice=-20` against a binary that has the CAP_SYS_NICE file capability and outrank the agent. Keep the original order and correct the docs instead. Refs DOCS-1687
This reverts commit dff8e7c. The change makes template versions that pair an "error" coder_env with a later entry for the same name fail every workspace build, after terraform apply has run. That is a breaking change that needs its own pull request and release note. Describe the current behavior in the docs instead. Refs DOCS-1669
The packaged coder.env now ships CODER_HTTP_ADDRESS= as a comment, so the sed command in the two Lima examples no longer produced an active line. The command now rewrites the line whether or not it is commented. Upgrades keep an existing /etc/coder.d/coder.env, so a file from a package before this change still has the empty line. Since v2.34.0 an empty value replaces the default, and with TLS off the server exits with "TLS is disabled. Enable with --tls-enable or specify a HTTP address". The RPM page, the upgrade page, and the 2.29 to 2.34 ESR upgrade page now name the error and the fix. coder.env carries a comment with the same warning. The test now reads the file with godotenv and compares every option that the file sets against the built-in defaults, so a new empty line for any option fails it. Refs DOCS-1587
The earlier change on this branch tracked whether a sink option was given, so that only an explicitly disabled sink skipped the "no loggers provided" error. That state is not needed. The error is removed, and a command with every log location empty or /dev/null runs with no log output. This reverses behavior that the docs described before: "An empty string does not disable logging". Since v2.34.0 an empty environment variable counts as set, so CODER_LOGGING_HUMAN= in an env file stopped the server with that error. It now starts a server that writes no logs. Refs DOCS-1652
The --experiments description said '*' opts in to all available experiments. ReadExperiments expands '*' to codersdk.ExperimentsSafe, so the description now says it opts in to the experiments marked safe. The provisioner daemon flag has the same text and calls the same function. The default quiet hours schedule description said the max deadline is the start of the user's next quiet hours window. CalculateAutostop uses the window on the next day that the template's autostop requirement applies, which can be days later. Regenerates the CLI reference, the configuration reference, and the golden files. Refs DOCS-1664
- environment-variables.md: describe the error merge strategy as the code applies it. The check runs only when the error resource is processed, and resources are processed in address order. - process-priority.md: a nice value below the agent's own is not applied, because the exec wrapper drops capabilities before it sets the nice value. Remove the CAP_SYS_NICE instructions. Name the three variables that the agent strips. - external-auth.md: anchor the GitHub Enterprise regex example so it does not match look-alike hosts. - port-forwarding.md: name the CORS Behavior setting, say it applies to every app and port, and restore the note that Simple strips the application's CORS headers. - change-management.md: use a token lifetime that the Owner role allows. - reference/index.md: the keep-alive script no longer shortens a later deadline, and curl now fails on HTTP errors. - agent-metadata.md: say what load remains after batching. - refresh-tokens.md: match the error detail that is specific to an expired OIDC session. - form-types.md: add the switch form type. - database-encryption.md: state the fields that the dbcrypt commands skip once, and link to the list. - speed-up-templates.md: remove a stray line from the YAML example. Refs DOCS-1669, DOCS-1687
|
Response to the
The PR description is updated to match. Posted by Coder Agents on behalf of @nickvigilante. |
|
/coder-agents-review |
There was a problem hiding this comment.
This round reviews the reverts of the agentexec and MergeExtraEnvs code fixes and the fixes for the round 1 findings. New findings: 4 P3, 7 P4, 3 Nit; one P4 is re-raised on its existing thread.
All round 1 findings are fixed except the four the author contested. The reviewers that raised them accept the defenses for the enabled log field name, the "(linux-only)" log message, and the commit subject. For the duplicated process priority check, the helper refactor is accepted as out of scope, and the comment on the line this PR adds is re-raised on that thread.
Out of scope (needs a ticket or explicit acceptance by a human):
coderd/experiments.go:43: the swagger annotation forGET /api/v2/experiments/availabledeclares an array ofcodersdk.Experiment, but the handler returns{"safe": [...]}; the generated API reference and swagger clients are wrong for this endpoint.site/src/pages/DeploymentSettingsPage/OverviewPage/OverviewPageView.stories.tsx:33: three story fixtures keep the old--experimentsdescription, so Storybook shows the text this PR corrects.cli/agent.go:268: the agent CLI andagentexec.NewExecer(agent/agentexec/exec.go:47-48) each compute the process priority decision; if one changes alone, the log reports the wrong state.
🤖 This review was automatically generated with Coder Agents.
The previous commit removed the "no loggers provided" error, so an empty log location turned logging off. An empty location is more likely a mistake, such as CODER_LOGGING_HUMAN= in an env file, and a server that starts with no logs hides it. The error is back for the case with no sinks, unless a log location is /dev/null. That is the documented way to disable logging, and it failed before when no other sink was set. logs.md again says that an empty value does not disable logging, and names the error. Refs DOCS-1652
|
/coder-agents-review |
There was a problem hiding this comment.
This round reviews the fix for the round 4 finding: the logging note now names --trace (CODER_TRACE_ENABLE), which matches cli/clilog/clilog.go, and the link anchor resolves. No new findings, and every finding from earlier rounds is fixed or closed.
The out-of-scope items listed in earlier rounds still need a ticket or explicit acceptance by a human, and the PR description leaves the empty CODER_LOGGING_HUMAN behavior and the code fix commits to the code owners.
🤖 This review was automatically generated with Coder Agents.
- Use "refer to" for cross-references and "visit" for the external issue link, in place of "see", on the lines this branch added. - creating-templates.md: write the button label as the dashboard shows it, "New template". - postgres-ssl.md: split the first server verification step into one instruction per step, put each condition first, and indent the code blocks under their steps so the list numbers continue. - process-priority.md: state the outcome for CAP_SYS_NICE first, and say that a nice value that is not applied is reported on stderr while the command still runs. The table formatter rewrites the whole table, so the dashes in the first row are replaced.
|
/coder-agents-review |
There was a problem hiding this comment.
This round reviews the doc-check follow-up commit (c888885970): "refer to" wording, the New template label, the postgres-ssl.md server verification steps, and the process-priority.md table. The label and the claims match the code. New findings: 2 P4.
Out of scope (needs a ticket or explicit acceptance by a human):
docs/install/prepare/airgap.md:232,docs/get-started/index.md:218, anddocs/admin/integrations/devcontainers/envbuilder/add-envbuilder.md:21: still say New Template, while the dashboard button (site/src/pages/TemplatesPage/TemplatesPageView.tsx:326) andcreating-templates.mdnow say New template.
🤖 This review was automatically generated with Coder Agents.
- process-priority.md: the failed to adjust niceness message is written to the stderr of the command with a coder-agent: prefix, not to the agent log. The troubleshooting entry says so, and the table row links to it in place of repeating it. - postgres-ssl.md: indent the code blocks and the paragraph in the client verification section under their steps, so the steps render as one numbered list.
|
/coder-agents-review |
There was a problem hiding this comment.
This round reviews 30b2c79a47, which fixes the two round 6 findings: the process-priority.md table now links to the troubleshooting entry, which says the niceness message goes to the command's stderr with the coder-agent: prefix, and the postgres-ssl.md client verification steps render as one numbered list. No new findings, and every finding from earlier rounds is fixed or closed.
Out of scope (needs a ticket or explicit acceptance by a human):
docs/templates/extending-templates/process-priority.md:87: the OOM score troubleshooting entry still saysfailed to adjust oom scoreappears "in stderr", without thecoder-agent:prefix or the note that it is not in the agent log, so a reader who searches the agent log does not find it.
Notes:
docs/templates/extending-templates/process-priority.md:93: fordevcontainer upanddevcontainer exec, the agent captures the command's stderr and logs non-JSON lines at debug level (agent/agentcontainers/devcontainercli.go:444), so the niceness message for those commands is in the agent log, not the command output.
🤖 This review was automatically generated with Coder Agents.
bpmct
left a comment
There was a problem hiding this comment.
Pushing one fix about AI Gateway fix. This is a nice collection of small changes to improve the QoL of our overall site. All LGTM :)
- spend-management.md: keep the v2.37 removal note in the callout, and move the cost export steps to their own numbered section. - Replace the budget flag details with a link to the AI Governance cost control page, which already covers them. Generated with Coder Agents.
The message goes to the stderr of the command. For most commands that is the command's own output, but the agent captures the stderr of the devcontainer CLI and logs it at debug level, so "not to the agent log" was too strong.
Summary
Addresses 106 of the 113 conflicts between the docs and the code that the November audit of
mainfound: 102 are fixed and 4 have an interim docs fix. Every finding was re-checked against the code before it was fixed. Most fixes are docs-only. Three are small code fixes where the docs described the intended behavior and the code was wrong, each in its own commits so it can be split out. No change in this PR alters template build or agent behavior.Changes
Fixes by area (finding counts): templates 28, install 13, integrations and monitoring 13, auth and security 12, networking 11, Coder Agents 9, AI governance 7, reference 7, workspaces 6.
Code fixes. Each needs a look from the code owner. If an owner prefers not to take one, drop its commits and I will change the docs to describe the current behavior instead.
fix: keep built-in listener defaults in packaged coder.env, and three follow-up commitscoder.envcomments outCODER_HTTP_ADDRESS=and the threeCODER_TLS_*lines, so an untouched package install listens on127.0.0.1:3000as the docs say. Only theCODER_HTTP_ADDRESS=line changed behavior. The TLS options default to empty, so commenting them out is for consistency. The Lima examples rewrite the commented line and fail if the line is not found. A test compares every option that the file sets against the built-in defaults.config|noreplace), so the upgrade pages now say how to fix it.fix(cli/clilog): accept log sinks that are all disabled, and three follow-up commits--log-human=/dev/nullwith no other log location no longer fails with "no loggers provided". It is the documented way to disable logging. An empty location still fails with that error when no other sink is set, as before./dev/null, the server and the provisioner daemon can start with no log output.fix(cli): detect CODER_PROC_PRIO_MGMT by presence, and a comment follow-upagentexecalready does. No detection or behavior change.Two option descriptions in
codersdk/deployment.goare corrected, with the CLI reference, configuration reference, and golden files regenerated: the default quiet hours schedule (the max deadline is the quiet hours window on the next day that the template's autostop requirement applies) and--experiments(*opts in to the experiments marked safe, also inenterprise/cli/provisionerdaemonstart.go).Code fixes that were reverted after review
Two code fixes from the first version of this PR are reverted in the branch. The net diff has no change under
agent/orcoderd/. The docs now describe what the code does, and both issues stay open for the owner.errormerge strategy forcoder_env(DOCS-1669). The fix mademerge_strategy = "error"fail whenever a name was set twice, whatever the resource order. Existing template versions that pair anerrorentry with a laterreplaceorappendentry would start to fail every build afterterraform apply. That is a breaking change that needs its own PR and release note. The fix and its tests are indff8e7c6ceand can be cherry-picked.environment-variables.mdnow says the check runs only when theerrorresource is processed.coder agent-execapply a negative nice value by callingsetprioritybefore it drops effective capabilities. The current order is deliberate: with the fix, any local process could run the agent binary with--coder-nice=-20when the binary has theCAP_SYS_NICEfile capability.process-priority.mdnow says a nice value below the agent's own is not applied, and no longer tells admins to grantCAP_SYS_NICE.Not included
Seven findings are left out.
Four fixes are interim, so their issues stay open:
Review notes
organizationport sharing in OSS, the telemetry field list, and the1-5cron range in the prebuilds schedule example.dateandtarforms on macOS, the Windows command on the multiple Kubernetes clusters page, and the keep-alive script indocs/reference/index.md(only its comparison logic was run, against sample values). Nothing was checked on a live deployment.mcp-server.md,feature-stages.md,docker-in-workspaces.md), docs: add how-to for rolling out a security update to every workspace #31982 (workspace-management.md), docs: document EWS03 and EIF01 health codes and guard against undocumented codes #31980 (health-check.md), docs: add provisioner metrics and a metrics signpost page #31977 (manage-provisioner-jobs.md), docs: add an air-gapped K3s install tutorial #31869 (airgap.md), docs: add Envbuilder maintenance mode warning #30486 (add-envbuilder.md), and feat: replace xterm.js with ghostty-web in the web terminal #31326 and docs: describe API fields without opening with the Go field name #31531 (codersdk/deployment.goand generated files).Testing
make pre-commit(gen, fmt, lint, slim build), before the PR opened and again after the review changes.go testfor./cli/clilog/...,./codersdk/,./cli/(TestServer,TestAgent, and golden files), and./enterprise/cli/(provisioner, server, and help golden files)../agent/agentexec/...and./coderd/provisionerdserver/...pass after the reverts. Linux only. CI covers macOS and Windows.coder.envtest fails against the file onmainand passes against the new one. It reads the file withgodotenv, which accepts CRLF line endings.CODER_HTTP_ADDRESS=was confirmed end to end with a full build of the server (output below).sedandgreplines in the Lima examples were run with GNU tools against the old and the new form ofcoder.env. The Lima VMs were not started.--log-human=/dev/nullandCODER_LOGGING_HUMAN=were confirmed with the same build (output below).coder agent-exec --coder-nice=-5 -- echofrom a full build, as a non-root user:coder-agent: failed to adjust niceness to -5 ...: permission deniedon stderr, the command output on stdout, exit code 0.postgres-ssl.mdrendered with the GitHub Markdown API: two ordered lists with three and five items, wheremainhas six lists.make lint/emdash,make lint/docs-html,make lint/docs-manifest,make lint/docs-redirects,make lint/style-claims, and Vale on the changed lines.Test and terminal output for the code fixes (Linux)
Linear
Fixes DOCS-1583, DOCS-1585, DOCS-1586, DOCS-1587, DOCS-1588, DOCS-1589, DOCS-1590, DOCS-1591, DOCS-1592, DOCS-1593, DOCS-1594, DOCS-1595, DOCS-1596, DOCS-1597, DOCS-1598, DOCS-1599, DOCS-1601, DOCS-1602, DOCS-1603, DOCS-1604, DOCS-1605, DOCS-1606, DOCS-1607, DOCS-1608, DOCS-1609, DOCS-1614, DOCS-1618, DOCS-1619, DOCS-1620, DOCS-1624, DOCS-1635, DOCS-1639, DOCS-1644, DOCS-1651, DOCS-1652, DOCS-1653, DOCS-1654, DOCS-1655, DOCS-1656, DOCS-1657, DOCS-1658, DOCS-1659, DOCS-1660, DOCS-1661, DOCS-1662, DOCS-1663, DOCS-1664, DOCS-1665, DOCS-1666, DOCS-1667, DOCS-1668, DOCS-1670, DOCS-1671, DOCS-1672, DOCS-1673, DOCS-1674, DOCS-1675, DOCS-1676, DOCS-1677, DOCS-1678, DOCS-1679, DOCS-1680, DOCS-1681, DOCS-1682, DOCS-1684, DOCS-1688, DOCS-1690, DOCS-1691, DOCS-1692, DOCS-1693, DOCS-1694, DOCS-1695, DOCS-1696, DOCS-1697, DOCS-1698, DOCS-1699, DOCS-1700, DOCS-1701, DOCS-1702, DOCS-1704, DOCS-1705, DOCS-1706, DOCS-1707, DOCS-1708, DOCS-1709, DOCS-1710, DOCS-1711, DOCS-1712, DOCS-1713, DOCS-1714, DOCS-1715, DOCS-1716, DOCS-1717, DOCS-1718, DOCS-1719, DOCS-1720, DOCS-1721, DOCS-1722, DOCS-1723, DOCS-1725, DOCS-1726, DOCS-1727
Part of DOCS-1600, DOCS-1689, DOCS-1669, DOCS-1687
Decision log
Scope
!.Docs or code
errormerge strategy and the nice value ordering started as code fixes and went back to docs-only after review. The first breaks existing template versions. The second weakens a deliberate security ordering.userNamefinding (DOCS-1609) took the docs path. The handler is unchanged.Wording choices worth a second look
feature-stages.mdsays--experiments=*enables only the experiments marked safe, and points to the "Get safe experiments" API. It does not list the other experiments, because the list would drift and those experiments are hidden on purpose. The--experimentsflag help now says the same.agent-metadata.mdreplaces the writes-per-second formula with a description of the batcher (each server replica writes one statement every 5 seconds, or sooner at 500 entries).extending-templates/index.mdno longer callsstartup_scriptdeprecated. The provider documents it as an alias for acoder_script.postgres-ssl.mdseparates client verification from server verification, so the server verification steps work alone.rpm.md,upgrade.md, and the 2.29 to 2.34 ESR upgrade page explain the emptyCODER_HTTP_ADDRESS=line that older packages shipped, because upgrades keep the old file. The behavior changed in v2.34.0 with the serpent upgrade in chore: bump coder/serpent to accept empty env vars #24926.docs/reference/index.mdreads the current deadline and skips the request when it is already later. The comparison is on text, so it applies only when the API returns a UTC timestamp, which needs the database to use the UTC time zone. Otherwise the script sets the deadline on every pass, as it did before, and the page says so.external-auth.mdanchors the new GitHub Enterprise regex example. The older unanchored examples on that page and ongit-providers.mdare not changed here.Self-review findings that were rejected
helm/libcoder/templates/_coder.yamlapplies 2000m and 4096Mi whencoder.resourcesis empty.Automated review, round 1
The
coder-agents-reviewapp left 45 findings on8853332. Fixed: the two reverts above, the anchored regex, thecoder.envfollow-ups (Lima examples, upgrade notes, a comment in the file, and a test that covers every option in the file), the clilog change, the two option descriptions, and the docs findings (CORS behavior, token lifetime example, keep-alive script, agent metadata, refresh token errors,switchform type,dbcryptskip list, and a stray line in a YAML example).Declined, with the reason on each thread:
agentexeclogging and renaming its log field: not related to a docs conflict.Capabilitiessubtest, the Helm values comment, the AWS provider path inairgap.md, and others in the review's out-of-scope list).Automated review, round 2
The app left 14 new findings on
04925bd, and accepted the three declined threads oncli/agent.go. All 14 are fixed. The main one: the round 1 change that removed the "no loggers provided" error went too far, because an empty log location would then start a server with no logs. The error is back for every case except/dev/null.Reported by the app as out of scope and not changed: the swagger annotation for
GET /api/v2/experiments/availabledeclares an array, but the handler returns an object with asafearray. Three Storybook fixtures keep the old--experimentsdescription.Automated review, round 3
The app confirmed that all round 2 findings are fixed, and left 10 small findings on
f55cb6d(8 P4, 2 Nit). All are fixed: the TLS condition and the release range in thecoder.envnotes, one place for the/dev/nullrule inclilog, two test cases, a clearer test failure, and the CPU example inagent-metadata.md.Automated review, rounds 4 and 5
Round 4 left one P4 on
8fffb38(name the--traceoption in the logging note), which is fixed. Round 5 on2ce754ereports no new findings and says every earlier finding is fixed or closed. The app did not post an approval: it leaves its out-of-scope items and the code fixes to a human reviewer. Two threads oncli/agent.gostay open on purpose for the code owner.Doc-check review
The doc-check workflow left 12 comments on
2ce754e(10 blocking, 2 suggestions). All are fixed inc888885: "refer to" or "visit" in place of "see" for cross-references on the lines this PR added, the New template label as the dashboard shows it, one instruction per step in the server verification procedure ofpostgres-ssl.md, and two wording changes inprocess-priority.md. TheCAP_SYS_NICEsentence keeps a short reason, which differs from the suggested text.The
coder-agents-reviewapp then reviewed that commit (rounds 6 and 7). Round 6 left two P4 findings, fixed in30b2c79: thefailed to adjust nicenessmessage is described once, in the troubleshooting entry, with where it appears, and the client verification steps inpostgres-ssl.mdrender as one numbered list. Round 7 reports no new findings.2a6035cthen softens one sentence from that fix, because the agent logs the stderr of devcontainer CLI commands. The app was not run again on that commit.Adjacent gaps found and not fixed here
add-envbuilder.mdhas the samezipcommand thattemplate-from-scratch.mdhad.template-from-scratch.mdleaves the reader inbuild/aftercd $_, before a step that runs fromtemplate-tour.Generated by Coder Agents on behalf of @nickvigilante.