Skip to content

fix: resolve docs and code conflicts found in the main docs audit - #32158

Merged
nickvigilante merged 25 commits into
mainfrom
docs/audit-conflict-fixes
Nov 13, 2026
Merged

nickvigilante merged 25 commits into
mainfrom
docs/audit-conflict-fixes

Conversation

@nickvigilante

@nickvigilante nickvigilante commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Addresses 106 of the 113 conflicts between the docs and the code that the November audit of main found: 102 are fixed and 4 have an interim docs fix. Every finding was re-checked against the code before it was fixed. Most fixes are docs-only. Three are small code fixes where the docs described the intended behavior and the code was wrong, each in its own commits so it can be split out. No change in this PR alters template build or agent behavior.

Changes

Fixes by area (finding counts): templates 28, install 13, integrations and monitoring 13, auth and security 12, networking 11, Coder Agents 9, AI governance 7, reference 7, workspaces 6.

Code fixes. Each needs a look from the code owner. If an owner prefers not to take one, drop its commits and I will change the docs to describe the current behavior instead.

Commits Change Risk to check
fix: keep built-in listener defaults in packaged coder.env, and three follow-up commits coder.env comments out CODER_HTTP_ADDRESS= and the three CODER_TLS_* lines, so an untouched package install listens on 127.0.0.1:3000 as the docs say. Only the CODER_HTTP_ADDRESS= line changed behavior. The TLS options default to empty, so commenting them out is for consistency. The Lima examples rewrite the commented line and fail if the line is not found. A test compares every option that the file sets against the built-in defaults. The deb and RPM packages were not built or installed. Every released package through v2.39.0 ships the empty line, and upgrades keep an existing file (config|noreplace), so the upgrade pages now say how to fix it.
fix(cli/clilog): accept log sinks that are all disabled, and three follow-up commits --log-human=/dev/null with no other log location no longer fails with "no loggers provided". It is the documented way to disable logging. An empty location still fails with that error when no other sink is set, as before. Behavior change: with /dev/null, the server and the provisioner daemon can start with no log output.
fix(cli): detect CODER_PROC_PRIO_MGMT by presence, and a comment follow-up Log line only. With the variable set to an empty value, the agent now logs that process priority management is enabled, which is what agentexec already does. No detection or behavior change. Low.

Two option descriptions in codersdk/deployment.go are corrected, with the CLI reference, configuration reference, and golden files regenerated: the default quiet hours schedule (the max deadline is the quiet hours window on the next day that the template's autostop requirement applies) and --experiments (* opts in to the experiments marked safe, also in enterprise/cli/provisionerdaemonstart.go).

Code fixes that were reverted after review

Two code fixes from the first version of this PR are reverted in the branch. The net diff has no change under agent/ or coderd/. The docs now describe what the code does, and both issues stay open for the owner.

  • error merge strategy for coder_env (DOCS-1669). The fix made merge_strategy = "error" fail whenever a name was set twice, whatever the resource order. Existing template versions that pair an error entry with a later replace or append entry would start to fail every build after terraform apply. That is a breaking change that needs its own PR and release note. The fix and its tests are in dff8e7c6ce and can be cherry-picked. environment-variables.md now says the check runs only when the error resource is processed.
  • Nice value before the capability drop (DOCS-1687). The fix let coder agent-exec apply a negative nice value by calling setpriority before it drops effective capabilities. The current order is deliberate: with the fix, any local process could run the agent binary with --coder-nice=-20 when the binary has the CAP_SYS_NICE file capability. process-priority.md now says a nice value below the agent's own is not applied, and no longer tells admins to grant CAP_SYS_NICE.

Not included

Seven findings are left out.

Four fixes are interim, so their issues stay open:

  • DOCS-1600: the AI Gateway pages now agree that the legacy metric names are deprecated and "will be removed in a future release". The code still emits them, and its TODO names v2.37, which has shipped. The owner still needs to set the removal release.
  • DOCS-1689: the page now says New Template opens the builder only for users with the Owner role, because the page gates on read access to the deployment config. Whether Template Admins should get the builder is still open.
  • DOCS-1669 and DOCS-1687: docs-only for now. Refer to Code fixes that were reverted after review.

Review notes

Testing

  • make pre-commit (gen, fmt, lint, slim build), before the PR opened and again after the review changes.
  • go test for ./cli/clilog/..., ./codersdk/, ./cli/ (TestServer, TestAgent, and golden files), and ./enterprise/cli/ (provisioner, server, and help golden files). ./agent/agentexec/... and ./coderd/provisionerdserver/... pass after the reverts. Linux only. CI covers macOS and Windows.
  • The coder.env test fails against the file on main and passes against the new one. It reads the file with godotenv, which accepts CRLF line endings.
  • An empty CODER_HTTP_ADDRESS= was confirmed end to end with a full build of the server (output below).
  • The new sed and grep lines in the Lima examples were run with GNU tools against the old and the new form of coder.env. The Lima VMs were not started.
  • --log-human=/dev/null and CODER_LOGGING_HUMAN= were confirmed with the same build (output below).
  • coder agent-exec --coder-nice=-5 -- echo from a full build, as a non-root user: coder-agent: failed to adjust niceness to -5 ...: permission denied on stderr, the command output on stdout, exit code 0.
  • postgres-ssl.md rendered with the GitHub Markdown API: two ordered lists with three and five items, where main has six lists.
  • markdownlint, the table formatter, make lint/emdash, make lint/docs-html, make lint/docs-manifest, make lint/docs-redirects, make lint/style-claims, and Vale on the changed lines.
  • A doc-check self-review of the docs diff by four independent reviewers. It found six problems, which are fixed. The accuracy and coverage lenses ran on every area. The language and structure lenses ran in full on only part of the diff.
Test and terminal output for the code fixes (Linux)
$ go test ./codersdk/ -run TestPackagedCoderEnvKeepsDefaults -count=1 -v
--- PASS: TestPackagedCoderEnvKeepsDefaults (0.00s)
ok  	github.com/coder/coder/v2/codersdk	0.071s

$ go test ./cli/clilog/ -run TestBuilder -count=1 -v
--- PASS: TestBuilder (0.00s)
    --- PASS: TestBuilder/NoSinks (0.00s)
        --- PASS: TestBuilder/NoSinks/JSONDevNull (0.00s)
        --- PASS: TestBuilder/NoSinks/StackdriverDevNull (0.00s)
        --- PASS: TestBuilder/NoSinks/NoConfiguration (0.00s)
        --- PASS: TestBuilder/NoSinks/HumanDevNull (0.00s)
    --- PASS: TestBuilder/WithHuman (0.00s)
    --- PASS: TestBuilder/WithFilter (0.00s)
    --- PASS: TestBuilder/WithJSON (0.00s)
    --- PASS: TestBuilder/Verbose (0.00s)
    --- PASS: TestBuilder/FromDeploymentValues (0.01s)
        --- PASS: TestBuilder/FromDeploymentValues/Defaults (0.00s)
        --- PASS: TestBuilder/FromDeploymentValues/EmptyHumanEnv (0.00s)
        --- PASS: TestBuilder/FromDeploymentValues/Override (0.00s)
ok  	github.com/coder/coder/v2/cli/clilog	0.171s

$ TMPDIR=$HOME/.cache/agentexec-tmp go test ./agent/agentexec/... ./coderd/provisionerdserver/... -count=1
ok  	github.com/coder/coder/v2/agent/agentexec	4.236s
ok  	github.com/coder/coder/v2/coderd/provisionerdserver	2.404s

# Full build of the server (go build ./cmd/coder). An empty value stops it before it connects to the database.
$ CODER_HTTP_ADDRESS= coder server --postgres-url 'postgres://127.0.0.1:1/x?sslmode=disable'
Encountered an error running "coder server", see "coder server --help" for more information
error: TLS is disabled. Enable with --tls-enable or specify a HTTP address

# With the variable unset, the server passes that check and goes on to the database.
$ coder server --postgres-url 'postgres://127.0.0.1:1/x?sslmode=disable'
2026-11-13 02:19:41.901 [warn]  ping postgres: retrying  error="dial tcp 127.0.0.1:1: connect: connection refused"  try=11
Encountered an error running "coder server", see "coder server --help" for more information
error: connect to postgres: connect to postgres: unable to connect after 11 tries; last error: dial tcp 127.0.0.1:1: connect: connection refused

# An empty log location with no other sink still stops the server.
$ CODER_LOGGING_HUMAN= coder server --postgres-url 'postgres://127.0.0.1:1/x?sslmode=disable'
Encountered an error running "coder server", see "coder server --help" for more information
error: make logger: no loggers provided, use /dev/null to disable logging

# /dev/null passes the logger check. The server prints no log lines and goes on to the database.
$ coder server --log-human=/dev/null --postgres-url 'postgres://127.0.0.1:1/x?sslmode=disable'
Encountered an error running "coder server", see "coder server --help" for more information
error: connect to postgres: connect to postgres: unable to connect after 11 tries; last error: dial tcp 127.0.0.1:1: connect: connection refused

Linear

Fixes DOCS-1583, DOCS-1585, DOCS-1586, DOCS-1587, DOCS-1588, DOCS-1589, DOCS-1590, DOCS-1591, DOCS-1592, DOCS-1593, DOCS-1594, DOCS-1595, DOCS-1596, DOCS-1597, DOCS-1598, DOCS-1599, DOCS-1601, DOCS-1602, DOCS-1603, DOCS-1604, DOCS-1605, DOCS-1606, DOCS-1607, DOCS-1608, DOCS-1609, DOCS-1614, DOCS-1618, DOCS-1619, DOCS-1620, DOCS-1624, DOCS-1635, DOCS-1639, DOCS-1644, DOCS-1651, DOCS-1652, DOCS-1653, DOCS-1654, DOCS-1655, DOCS-1656, DOCS-1657, DOCS-1658, DOCS-1659, DOCS-1660, DOCS-1661, DOCS-1662, DOCS-1663, DOCS-1664, DOCS-1665, DOCS-1666, DOCS-1667, DOCS-1668, DOCS-1670, DOCS-1671, DOCS-1672, DOCS-1673, DOCS-1674, DOCS-1675, DOCS-1676, DOCS-1677, DOCS-1678, DOCS-1679, DOCS-1680, DOCS-1681, DOCS-1682, DOCS-1684, DOCS-1688, DOCS-1690, DOCS-1691, DOCS-1692, DOCS-1693, DOCS-1694, DOCS-1695, DOCS-1696, DOCS-1697, DOCS-1698, DOCS-1699, DOCS-1700, DOCS-1701, DOCS-1702, DOCS-1704, DOCS-1705, DOCS-1706, DOCS-1707, DOCS-1708, DOCS-1709, DOCS-1710, DOCS-1711, DOCS-1712, DOCS-1713, DOCS-1714, DOCS-1715, DOCS-1716, DOCS-1717, DOCS-1718, DOCS-1719, DOCS-1720, DOCS-1721, DOCS-1722, DOCS-1723, DOCS-1725, DOCS-1726, DOCS-1727

Part of DOCS-1600, DOCS-1689, DOCS-1669, DOCS-1687

Decision log

Scope

  • One PR for all findings, as agreed with the reviewer. The code fixes are separate commits so an owner can ask for any of them to move to its own PR. Nothing in the PR is a breaking change, so the title has no !.
  • A finding was skipped only when an open PR already covers it, or when every available wording would assert an undecided product behavior.
  • Each validation comment on the Linear issues records the evidence, the corrections to the original finding, and what was not verified.

Docs or code

  • The default was a docs-only fix that describes what the code does.
  • A code fix was chosen when the docs describe a behavior the code plainly intended and the code change is small and testable: the packaged env file, the log sink check, and the log line for the environment variable presence check.
  • The error merge strategy and the nice value ordering started as code fixes and went back to docs-only after review. The first breaks existing template versions. The second weakens a deliberate security ordering.
  • The SCIM userName finding (DOCS-1609) took the docs path. The handler is unchanged.

Wording choices worth a second look

  • feature-stages.md says --experiments=* enables only the experiments marked safe, and points to the "Get safe experiments" API. It does not list the other experiments, because the list would drift and those experiments are hidden on purpose. The --experiments flag help now says the same.
  • agent-metadata.md replaces the writes-per-second formula with a description of the batcher (each server replica writes one statement every 5 seconds, or sooner at 500 entries).
  • extending-templates/index.md no longer calls startup_script deprecated. The provider documents it as an alias for a coder_script.
  • postgres-ssl.md separates client verification from server verification, so the server verification steps work alone.
  • rpm.md, upgrade.md, and the 2.29 to 2.34 ESR upgrade page explain the empty CODER_HTTP_ADDRESS= line that older packages shipped, because upgrades keep the old file. The behavior changed in v2.34.0 with the serpent upgrade in chore: bump coder/serpent to accept empty env vars #24926.
  • The keep-alive script in docs/reference/index.md reads the current deadline and skips the request when it is already later. The comparison is on text, so it applies only when the API returns a UTC timestamp, which needs the database to use the UTC time zone. Otherwise the script sets the deadline on every pass, as it did before, and the page says so.
  • external-auth.md anchors the new GitHub Enterprise regex example. The older unanchored examples on that page and on git-providers.md are not changed here.

Self-review findings that were rejected

  • "The builder opens for Template Admins": the Templates page needs a successful deployment config read, which the Template Admin role does not have.
  • "Organization Admins can set AI model prices": the price write authorizes against a site-level object, which organization-scoped grants do not match.
  • "The provisioner chart sets no default resources": helm/libcoder/templates/_coder.yaml applies 2000m and 4096Mi when coder.resources is empty.

Automated review, round 1

The coder-agents-review app left 45 findings on 8853332. Fixed: the two reverts above, the anchored regex, the coder.env follow-ups (Lima examples, upgrade notes, a comment in the file, and a test that covers every option in the file), the clilog change, the two option descriptions, and the docs findings (CORS behavior, token lifetime example, keep-alive script, agent metadata, refresh token errors, switch form type, dbcrypt skip list, and a stray line in a YAML example).

Declined, with the reason on each thread:

  • Refactoring the agentexec logging and renaming its log field: not related to a docs conflict.
  • Rewording the "process priority management not enabled (linux-only)" log message: the docs quote the message, and the wording predates this PR.
  • Problems in code and docs that this PR does not change (the Capabilities subtest, the Helm values comment, the AWS provider path in airgap.md, and others in the review's out-of-scope list).

Automated review, round 2

The app left 14 new findings on 04925bd, and accepted the three declined threads on cli/agent.go. All 14 are fixed. The main one: the round 1 change that removed the "no loggers provided" error went too far, because an empty log location would then start a server with no logs. The error is back for every case except /dev/null.

Reported by the app as out of scope and not changed: the swagger annotation for GET /api/v2/experiments/available declares an array, but the handler returns an object with a safe array. Three Storybook fixtures keep the old --experiments description.

Automated review, round 3

The app confirmed that all round 2 findings are fixed, and left 10 small findings on f55cb6d (8 P4, 2 Nit). All are fixed: the TLS condition and the release range in the coder.env notes, one place for the /dev/null rule in clilog, two test cases, a clearer test failure, and the CPU example in agent-metadata.md.

Automated review, rounds 4 and 5

Round 4 left one P4 on 8fffb38 (name the --trace option in the logging note), which is fixed. Round 5 on 2ce754e reports no new findings and says every earlier finding is fixed or closed. The app did not post an approval: it leaves its out-of-scope items and the code fixes to a human reviewer. Two threads on cli/agent.go stay open on purpose for the code owner.

Doc-check review

The doc-check workflow left 12 comments on 2ce754e (10 blocking, 2 suggestions). All are fixed in c888885: "refer to" or "visit" in place of "see" for cross-references on the lines this PR added, the New template label as the dashboard shows it, one instruction per step in the server verification procedure of postgres-ssl.md, and two wording changes in process-priority.md. The CAP_SYS_NICE sentence keeps a short reason, which differs from the suggested text.

The coder-agents-review app then reviewed that commit (rounds 6 and 7). Round 6 left two P4 findings, fixed in 30b2c79: the failed to adjust niceness message is described once, in the troubleshooting entry, with where it appears, and the client verification steps in postgres-ssl.md render as one numbered list. Round 7 reports no new findings. 2a6035c then softens one sentence from that fix, because the agent logs the stderr of devcontainer CLI commands. The app was not run again on that commit.

Adjacent gaps found and not fixed here

  • add-envbuilder.md has the same zip command that template-from-scratch.md had.
  • template-from-scratch.md leaves the reader in build/ after cd $_, before a step that runs from template-tour.

Generated by Coder Agents on behalf of @nickvigilante.

The packaged /etc/coder.d/coder.env set CODER_HTTP_ADDRESS and the
CODER_TLS_* options to empty strings. An empty value overrides the
built-in default, so an untouched package install did not listen on
127.0.0.1:3000 as the install docs say. Comment the lines out so the
defaults apply until an operator sets a value.

Add a test that parses the file, with LF and CRLF line endings, and
checks that the default HTTP address survives.

Fixes DOCS-1587
The docs say that an empty --log-human value, or /dev/null, disables
human-readable logging. With no other sink set, the builder instead
failed with "no loggers provided". Track whether any sink option was
given, and return that error only when none was, so a deliberately
silent configuration starts.

Fixes DOCS-1652
…ndependent

A coder_env with merge_strategy = "error" failed the build only when an
earlier entry had already set the same name. If the "error" entry came
first, a later entry replaced it silently. Resource order is not
something a template author controls, so count the names up front and
fail whenever an "error" entry shares its name with another entry.

Fixes DOCS-1669
The exec wrapper dropped its effective capabilities and then called
setpriority, so a negative CODER_PROC_NICE_SCORE failed without
CAP_SYS_NICE even when the agent binary had that capability. Set the
nice value first. The capabilities are still dropped before the child
command runs.

Fixes DOCS-1687
The docs and agentexec treat the variable as enabled when it is set to
any value, including an empty one. The agent command only logged that
priority management was enabled when the value was not empty.

Fixes DOCS-1709
The option help said the max deadline is rounded up to be within the
quiet hours window. The scheduler sets it to the start of the user's
next quiet hours window. Regenerate the CLI reference, the
configuration reference, and the golden files.

Fixes DOCS-1664
An audit of main compared the docs with the code and found pages that
state behavior, defaults, names, roles, commands, or examples that the
code does not support. Correct each page to describe what the code
does, and keep related pages consistent with each other.

The issue list is in the pull request description.
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 01:33 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 01:33 — with GitHub Actions Inactive
@nickvigilante
nickvigilante requested a review from bpmct November 13, 2026 01:33
@nickvigilante

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@coder-agents-review

coder-agents-review Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Chat: Review posted | View chat
Requested: 2026-11-13 20:40 UTC by @nickvigilante
Spend: $79.01 / $100.00

Review history
  • R2 (2026-11-13): 13 reviewers, 12 Nit, 5 P2, 17 P3, 25 P4, COMMENT. Review
  • R3 (2026-11-13): 11 reviewers, 14 Nit, 5 P2, 17 P3, 34 P4, COMMENT. Review
  • R4 (2026-11-13): 11 reviewers, 14 Nit, 5 P2, 17 P3, 35 P4, COMMENT. Review
  • R5 (2026-11-13): 4 reviewers, 14 Nit, 5 P2, 17 P3, 35 P4, COMMENT. Review
  • R6 (2026-11-13): 4 reviewers, 14 Nit, 5 P2, 17 P3, 37 P4, COMMENT. Review
  • R7 (2026-11-13): 5 reviewers, 14 Nit, 5 P2, 17 P3, 37 P4, COMMENT. Review

deep-review v0.13.0 | Round 7 | e6a57f3..30b2c79

Last posted: Round 7, 73 findings (5 P2, 17 P3, 37 P4, 14 Nit), COMMENT. Review

Finding inventory

Findings

# Sev Status Location Summary Round Reviewer Posted
CRF-1 P3 Author fixed (27ca5ec) cli/clilog/clilog.go:152 "no loggers provided" error unreachable from production callers; field comment false R1 Netero Yes
CRF-2 P3 Author fixed (b070cfc, reverted) agent/agentexec/cli_linux_test.go:117 LowerNiceWithCapSysNice fails instead of skipping in user namespaces R1 Netero Yes
CRF-3 P4 Author fixed (b070cfc, reverted) agent/agentexec/cli_linux_test.go:113 Fixed nice-caps dir fails under -count=N R1 Netero Yes
CRF-4 P4 Author fixed (274f82a) cli/agent.go:268 CLI duplicates NewExecer's process priority decision R1 Netero P4, Gon P2 (comment) Yes
CRF-5 Nit Author contested; panel closed R2 (1/1 accept) cli/agent.go:272 Log field enabled holds raw env value R1 Netero Yes
CRF-6 Note Note (body) coderd/provisionerdserver/mergeenvs_internal_test.go:12 Subagent test repeats TestMergeExtraEnvs cases R1 Netero No
CRF-7 P2 Author fixed (b070cfc revert, 04925bd) agent/agentexec/cli_linux.go:73 agent-exec applies argv nice with file caps effective; any local caller gets negative nice R1 Kurapika P2, Razor Note, Ryosuke Note Yes
CRF-8 P2 Author fixed (04925bd) docs/admin/external-auth.md:266 New GHE regex example is unanchored; token sent to look-alike hosts R1 Kurapika Yes
CRF-9 P2 Author fixed (e6f9b50 revert, 04925bd) coderd/provisionerdserver/provisionerdserver.go:3629 Already-imported template versions fail every build after apply R1 Ryosuke Yes
CRF-10 P2 Author fixed (b070cfc, e6f9b50 reverts) coderd/provisionerdserver/provisionerdserver.go:3613 Breaking template behavior change with no breaking marker; squash merges into docs commit R1 Ryosuke Yes
CRF-11 P2 Author fixed (bf047a4) docs/install/server/rpm.md:101 Upgrade fix for empty CODER_HTTP_ADDRESS only on RPM page; upgraders not told; no error string R1 Pariston P2, Mafuuu P3, Razor P3, Leorio P3, Pen Botter OOS Yes
CRF-12 P3 Author fixed (56a71ae) codersdk/deployment.go:4032 Quiet hours description wrong for non-daily autostop requirement R1 Mafuuu, Razor, Mafu-san Yes
CRF-13 P3 Author fixed (04925bd) docs/admin/networking/port-forwarding.md:203 Deleted CORS stripping sentence that Simple still does; scope "all shared ports" wrong R1 Pen Botter, Mafuuu, Razor Yes
CRF-14 P3 Author fixed (04925bd) docs/templates/managing-templates/change-management.md:71 --lifetime 30d fails for Owners R1 Pen Botter, Leorio Yes
CRF-15 P3 Author fixed (04925bd) docs/reference/index.md:91 Keep-alive script shortens deadline; curl lacks -f R1 Pen Botter Yes
CRF-16 P4 Author fixed (04925bd) docs/templates/extending-templates/agent-metadata.md:122 "overwhelm your database" warning no longer actionable R1 Pen Botter Yes
CRF-17 P4 Author fixed (04925bd) docs/workspaces/speed-up-templates.md:83 Trailing ellipsis line breaks YAML values example R1 Pen Botter Yes
CRF-18 Note Note (body) coder.env:5 Commenting out CODER_TLS_* changes no behavior R1 Pariston No
CRF-19 P4 Author fixed (04925bd) docs/templates/extending-templates/environment-variables.md:35 error row ignores coder_agent.env override R1 Mafuuu, Leorio Yes
CRF-20 P4 Author fixed (bf047a4) codersdk/deployment_test.go:2215 CRLF subtest only tests the test helper R1 Bisky, Zoro Yes
CRF-21 P4 Author fixed (27ca5ec) cli/clilog/clilog_test.go:64 DevNullHumanWithJSON redundant, does not reach changed check R1 Bisky Yes
CRF-22 P4 Author fixed (27ca5ec) cli/clilog/clilog_test.go:59 require.Empty(stderr) cannot fail R1 Bisky Yes
CRF-23 P3 Author fixed (e6f9b50, reverted) coderd/provisionerdserver/provisionerdserver.go:3631 Error text names a cause production cannot hit R1 Leorio P3, Gon P4 Yes
CRF-24 P3 Author fixed (56a71ae) docs/reference/feature-stages.md:54 Linked --experiments help still says all experiments R1 Leorio Yes
CRF-25 P4 Author fixed (04925bd) docs/admin/users/oidc-auth/refresh-tokens.md:154 Generic signed-out message treated as refresh failure R1 Leorio Yes
CRF-26 P4 Author contested; panel closed R2 (1/1 accept) cli/agent.go:276 "(linux-only)" log message misleads on Linux R1 Leorio Yes
CRF-27 P4 Author fixed (b070cfc, reverted) agent/agentexec/cli_linux_test.go:110 Test comment gives false same-filesystem reason R1 Leorio P4, Gon P2 Yes
CRF-28 P4 Author fixed (bf047a4) codersdk/deployment_test.go:2199 Test doc comment tautological and omits TLS condition R1 Leorio P4, Gon P2 Yes
CRF-29 P4 Author contested; panel closed R2 (1/1 accept) cli/agent.go:268 Commit subject "detect by presence" describes a log-only change R1 Leorio Yes
CRF-30 P3 Author fixed (27ca5ec) docs/admin/monitoring/logs.md:19 clilog commit misstates docs; empty value reverses documented behavior R1 Mafu-san P2 Yes
CRF-31 P3 Author fixed (e6f9b50, reverted) coderd/provisionerdserver/provisionerdserver.go:3615 Merge commit rationale contradicted by address sorting R1 Mafu-san P2 Yes
CRF-32 P3 Author fixed (bf047a4) coder.env:5 Lima examples' sed keeps the comment; VMs listen on loopback R1 Zoro Yes
CRF-33 P3 Author fixed (bf047a4) coder.env:5 No warning against uncommenting with an empty value R1 Gon Yes
CRF-34 P4 Author fixed (04925bd) docs/admin/security/database-encryption.md:134 Skipped-field list repeated three times R1 Zoro Yes
CRF-35 P4 Author fixed (b070cfc, reverted) agent/agentexec/cli_linux_test.go:109 Copied Capabilities setup duplicates its defects R1 Zoro Yes
CRF-36 Nit Author fixed (bf047a4) codersdk/deployment_test.go:2240 Use strings.Lines instead of Split R1 Ging-Go Yes
CRF-37 P4 Author fixed (bf047a4) codersdk/deployment_test.go:2227 Test checks two fields, not every empty assignment R1 Razor Yes
CRF-38 P4 Author fixed (04925bd) docs/templates/extending-templates/agent-metadata.md:136 One batch statement per 5s is per replica R1 Razor Yes
CRF-39 P4 Author fixed (04925bd) docs/templates/extending-templates/parameters/form-types.md:28 Table has no switch row R1 Razor Yes
CRF-40 Nit Author fixed (b070cfc, reverted) agent/agentexec/cli_linux.go:71 Ordering comment should state the rule R1 Gon P2 Yes
CRF-41 Nit Author fixed (b070cfc, reverted) agent/agentexec/cli_linux.go:75 Moved comment typo and padding R1 Gon P2 Yes
CRF-42 Nit Author fixed (b070cfc, reverted) agent/agentexec/cli_linux_test.go:116 Test comment repeats production comment R1 Gon P2 Yes
CRF-43 Nit Author fixed (e6f9b50, reverted) coderd/provisionerdserver/provisionerdserver.go:3613 Doc comment sentence wording R1 Gon P2 Yes
CRF-44 Nit Author fixed (bf047a4) codersdk/deployment_test.go:2222 Comment narrates calls instead of why order matters R1 Gon P2 Yes
CRF-45 Nit Author fixed (bf047a4) codersdk/deployment_test.go:2233 Helper comment overclaims EnvironmentFile support R1 Gon P2 Yes
CRF-46 Nit Author fixed (bf047a4) codersdk/deployment_test.go:2203 Test name omits TLS assertion R1 Gon Yes
CRF-47 P3 Author fixed (bf047a4) docs/install/server/rpm.md:85 "doesn't start while empty" false after coder.env change R1 Pen Botter (OOS, moved in scope) Yes
CRF-48 OOS Out of scope (body) docs/admin/external-auth.md:287 Other unanchored regex examples (external-auth.md, git-providers.md) R1 Kurapika No
CRF-49 OOS Out of scope (body) coderd/provisionerdserver/provisionerdserver.go:2324 coder_env validation runs after terraform apply R1 Ryosuke No
CRF-50 OOS Out of scope (body) coderd/provisionerdserver/provisionerdserver.go:3615 exists branch reachable only from tests R1 Ryosuke No
CRF-51 OOS Out of scope (body) cli/server.go:453 Empty CODER_HTTP_ADDRESS could be treated as unset R1 Pariston No
CRF-52 OOS Out of scope (body) agent/agentexec/cli_linux.go:99 OOM score write after cap drop R1 Pariston, Mafu-san No
CRF-53 OOS Out of scope (body) docs/templates/extending-templates/process-priority.md:17 securityContext CAP_SYS_NICE not effective for non-root R1 Pariston, Razor No
CRF-54 OOS Out of scope (body) docs/templates/extending-templates/process-priority.md:113 Claims all CODER_PROC_* stripped R1 Mafu-san No
CRF-55 OOS Author fixed (c888885), was Out of scope (body) docs/templates/extending-templates/process-priority.md:31 Emdash R1 Mafu-san No
CRF-56 OOS Out of scope (body) docs/admin/networking/reverse-proxy-caddy.md:134 Standalone Caddyfile cannot get wildcard cert; email bullet R1 Mafuuu, Pen Botter No
CRF-57 OOS Out of scope (body) helm/provisioner/values.yaml:136 Chart comment says no default resources R1 Pen Botter, Gon No
CRF-58 OOS Out of scope (body) codersdk/deployment.go:3560 Default Token Lifetime help vs CLI behavior R1 Mafuuu No
CRF-59 OOS Out of scope (body) docs/install/prepare/airgap.md:91 AWS provider stored under aws/aws R1 Razor No
CRF-60 OOS Out of scope (body) docs/admin/integrations/devcontainers/envbuilder/add-envbuilder.md:71 Same zip command bug R1 Mafu-san No
CRF-61 OOS Out of scope (body) agent/agent.go:81 Duplicate EnvProc constants R1 Netero, Gon No
CRF-62 OOS Out of scope (body) agent/agentexec/cli_linux_test.go:86 Capabilities fixed dir fails -count=2 R1 Netero No
CRF-63 OOS Out of scope (body) agent/agentexec/cli_linux_test.go:83 Capabilities passes without effective cap R1 Netero No
CRF-64 OOS Out of scope (body) agent/agentexec/cli_linux.go:101 OOM comment typo R1 Gon No
CRF-65 OOS Out of scope (body) docs/coder-agents/index.md:281 read_skill rule stated on two pages R1 Zoro No
CRF-66 OOS Out of scope (body) cli/clilog/clilog.go:153 Error omits empty value as remedy R1 Leorio No
CRF-67 P4 Author fixed (725a69e) coder.env:5 New warning comment also covers the uncommented empty CODER_PG_CONNECTION_URL line R2 Leorio P4, Gon P2 Yes
CRF-68 P3 Author fixed (725a69e); remaining wording raised as CRF-87 in R3 docs/install/operate/upgrade.md:33 "Packages before v2.34.0" false; every package through v2.39.0 ships the line R2 Mafu-san P2, Mafuuu P3, Razor P3, Pen Botter P4 Yes
CRF-69 P3 Author fixed (725a69e) docs/install/server/rpm.md:85 "leaves every option at its default" false for published RPMs and hides tunnel and built-in PostgreSQL R2 Pen Botter P3, Razor P4 Yes
CRF-70 P3 Author fixed (725a69e) docs/install/server/rpm.md:106 Loopback-only claim ignores public tunnel when CODER_ACCESS_URL is empty R2 Pen Botter Yes
CRF-71 P4 Author fixed (725a69e) docs/install/operate/upgrade/esr-2.29-2.34-upgrade.md:177 "empty lines" reads as blank lines R2 Pen Botter Yes
CRF-72 P4 Author fixed (f55cb6d) docs/reference/index.md:83 Non-Z offset sentence does not say when it happens (non-UTC database) R2 Pen Botter Yes
CRF-73 P4 Author fixed (f55cb6d) docs/reference/feature-stages.md:57 Links to API reference that documents the wrong response shape R2 Razor Yes
CRF-74 P4 Author fixed (725a69e) examples/lima/coder-docker.yaml:80 Nothing ties the Lima sed pattern to coder.env R2 Bisky Yes
CRF-75 P4 Author fixed (725a69e) docs/install/server/rpm.md:101 Upgrade explanation stated in three places R2 Zoro Yes
CRF-76 P4 Author fixed (f55cb6d) docs/templates/extending-templates/process-priority.md:93 Nice rule stated three times on one page R2 Zoro Yes
CRF-77 Nit Author fixed (725a69e) codersdk/deployment_test.go:2226 opt.Value nil guard cannot be true and would misreport R2 Zoro Yes
CRF-78 P3 Author fixed (44413db) cli/clilog/clilog.go:141 Empty log location silently disables all logging; keep error for empty, allow /dev/null R2 Knov Yes
CRF-79 Nit Author fixed (44413db) cli/clilog/clilog.go:141 Comment repeats the addSinkIfProvided rule R2 Gon P2 Yes
CRF-80 Nit Author fixed (725a69e) codersdk/deployment_test.go:2200 Test doc comment duplicates coder.env warning R2 Gon P2 Yes
CRF-81 OOS Out of scope (body) coderd/experiments.go:43 Swagger annotation declares array; handler returns object R2 Razor No
CRF-82 OOS Out of scope (body) site/src/pages/DeploymentSettingsPage/OverviewPage/OverviewPageView.stories.tsx:33 Story fixtures keep old experiments description R2 Mafu-san No
CRF-83 OOS Out of scope (body) cli/agent.go:268 CLI and NewExecer each compute the priority decision (CRF-4 refactor part) R2 Netero No
CRF-84 P4 Author fixed (3a425a1) docs/admin/monitoring/logs.md:21 "every log location empty, server exits" false when tracing is on R3 Netero Yes
CRF-85 P4 Author fixed (1fd784c) cli/clilog/clilog_test.go:37 No test covers Stackdriver /dev/null term R3 Netero Yes
CRF-86 P4 Author fixed (3a425a1) docs/install/server/rpm.md:103 "Otherwise the service does not start" drops the TLS condition R3 Leorio, Mafuuu, Pen Botter Yes
CRF-87 P4 Author fixed (3a425a1) docs/install/operate/upgrade.md:33 "Older ... packages" still reads as older than v2.34.0 R3 Leorio, Razor Yes
CRF-88 P4 Author fixed (3a425a1) coder.env:9 "replaces the default listener" does not state the consequence R3 Gon, Leorio Yes
CRF-89 P4 Author fixed (1fd784c) cli/clilog/clilog.go:143 disabled expression duplicates the /dev/null rule and sink field list R3 Zoro, Knov Yes
CRF-90 Nit Author fixed (1fd784c) cli/clilog/clilog.go:143 disabled name does not match what it holds R3 Gon Yes
CRF-91 P4 Author fixed (1fd784c) cli/clilog/clilog_test.go:35 HumanEmpty builds the same Builder as NoConfiguration R3 Bisky Yes
CRF-92 P4 Author fixed (8fffb38) codersdk/deployment_test.go:2232 Count assertion does not name the unmatched variable R3 Chopper Yes
CRF-93 P4 Author fixed (8fffb38) docs/templates/extending-templates/agent-metadata.md:47 Comment says two columns; awk sums three fields R3 Gon Yes
CRF-94 Nit Author fixed (8fffb38) docs/reference/index.md:98 Script comment repeats the condition and page prose R3 Gon P2 Yes
CRF-95 P4 Author fixed (2ce754e) docs/admin/monitoring/logs.md:21 "tracing is off" does not name --trace; reads as --trace-logs R4 Leorio, Pen Botter Yes
CRF-96 OOS Out of scope (body) codersdk/deployment.go:3264 --trace-logs is read by no code R4 Pen Botter No
CRF-97 OOS Out of scope (body) cli/clilog/clilog.go:106 addSinkIfProvided error returns are unreachable R4 Meruem No
CRF-98 P4 Author fixed (30b2c79) docs/templates/extending-templates/process-priority.md:21 New stderr sentence repeats troubleshooting and does not say the message is in the command output, not the agent log R6 Pen Botter, Leorio, Razor Yes
CRF-99 P4 Author fixed (30b2c79) docs/install/server/postgres-ssl.md:42 Client verification steps still render as separate "1." lists R6 Kite, Leorio (Pen Botter listed as out of scope) Yes
CRF-100 OOS Out of scope (body) docs/install/prepare/airgap.md:232 New Template label on airgap.md, get-started/index.md:218, add-envbuilder.md:21 R6 Pen Botter, Leorio No
CRF-101 OOS Out of scope (body) docs/templates/extending-templates/process-priority.md:87 OOM troubleshooting says "in stderr" without the coder-agent prefix or the not-in-agent-log note R7 Leorio, Kite No
CRF-102 Note Note (body) docs/templates/extending-templates/process-priority.md:93 Devcontainer CLI commands send the niceness message to the agent debug log R7 Razor No

Contested and acknowledged

CRF-4 (P4, cli/agent.go:268) - CLI duplicates NewExecer's process priority decision

  • Finding: The CLI recomputes the decision agentexec.NewExecer makes (os.LookupEnv plus runtime.GOOS at agent/agentexec/exec.go:47-48), so the log line stays correct only by hand. Proposed: log from the returned Execer or export one helper. Gon's merged angle: the comment at cli/agent.go:267 should say the check must match NewExecer.
  • Author defense: A shared helper is an agentexec refactor unrelated to a docs conflict; the PR now changes only the log line. Left open for the code owner.
  • Panel re-raised (R2): Netero (the agent that raised it) accepted the refactor part: the PR makes the copy match the real rule, and the remaining duplication predates the PR (moved to out of scope, CRF-83). Gon (the agent that raised the comment angle) re-raised the comment part at P4: the defense covers the refactor, not a one-line comment on a line the PR adds.

CRF-5 (Nit, cli/agent.go:272) - Log field enabled holds raw env value

  • Finding: The enabled field holds the raw value, so an empty variable logs enabled="". Proposed: rename to value or log the bool.
  • Author defense: The field name predates this PR, and a rename could break log queries.
  • Panel closure (R2, 1/1): Netero, the agent that raised it, verified that on base slog.F("enabled", enabled) already held the raw os.Getenv value, so the diff does not change what the field holds, and the message text shows the state.

CRF-26 (P4, cli/agent.go:276) - "(linux-only)" log message misleads on Linux

  • Finding: On Linux with the variable unset, the message points at the OS instead of the missing variable. Proposed: reword.
  • Author defense: The message predates the PR (the PR removes only a trailing space), and process-priority.md quotes it.
  • Panel closure (R2, 1/1): Leorio, the agent that raised it, verified that the log entry carries env_var and os fields and that process-priority.md:112-115 quotes the message and explains the fields, so an operator can find the cause.

CRF-29 (P4, cli/agent.go:268) - Commit subject "detect by presence" describes a log-only change

  • Finding: The commit subject and PR table row describe a detection change for a log-only commit. Proposed: rewrite the subject.
  • Author defense: The PR table row now says log line only; the subject is not rewritten because that needs a force push and the squash merge drops it.
  • Panel closure (R2, 1/1): Leorio, the agent that raised it, verified the corrected row and that the repository squash-merges, so the subject will not reach main.

Round log

Round 1

Full panel (round 1). Netero: no P0, 2 P3, 2 P4, 1 Nit, 1 Note. Law not run (effective additions 731). Panel: Ging-Go, Kurapika, Ryosuke, Pen Botter (specialists); Pariston, Mafuuu (core); Bisky, Leorio, Gon, Razor, Mafu-san (pool); Zoro (wildcard). Size 12, multi-domain and security-sensitive (capability drop path, external auth regex). Leorio corrected three diff-position line numbers to source lines on request.
Cross-check: CRF-11 merges five reviewers on the upgrade note. Gon's comment-wording P2s downgraded to Nit (keep-argument: misleading comments persist; only CRF-27 states a false reason, so it stays at P4). Mafu-san's two commit-rationale P2s downgraded to P3 (keep-argument: owner approves on a wrong rationale; the PR table already names the log behavior change and the docs example supports the merge change). Gon cli/agent.go:267 merged into CRF-4; Gon clilog.go:150 and :36 covered by CRF-1. Pen Botter rpm.md:85 moved into scope as CRF-47 because the coder.env change alters the outcome the sentence describes. Mafu-san OOM sibling and add-envbuilder zip moved out of scope (unchanged instances). Totals posted: 5 P2, 13 P3, 18 P4, 9 Nit; 2 Notes in body; 19 out-of-scope items.
Reviewed against e6a57f3..8853332.
Post: deep-review post returned 502 Server Error from POST /pulls/32158/reviews, but GitHub created the review anyway (review 5884949246, COMMENTED, 2026-11-13T01:59:27Z, 43 inline comments, CRF-17 and CRF-47 folded into the body; checked with an unauthenticated read of the public API). Not retried, to avoid a duplicate review. The CLI may not have recorded the post in its state.

Round 2

Fix round (no files added or renamed in the repo, no exported signature change, title unchanged, effective additions fell from 731 to 588; two code fixes reverted). Churn guard PROCEED: 41 addressed, 4 contested. Netero reused (no findings; accepted CRF-4 refactor part and CRF-5). Panel: Gon and Leorio reused for the dispute check-in; Kurapika, Ryosuke, Pariston, Mafuuu, Razor, Pen Botter, Bisky, Mafu-san, Zoro, Ging-Go spawned new as raisers of findings the new commits touched; Knov wildcard. CRF-5, CRF-26, CRF-29 closed 1/1; CRF-4 re-raised (comment part). New: 4 P3, 7 P4, 3 Nit; 3 out of scope.
Cross-check: CRF-68 has four reviewers at P2 to P4; settled at P3 (keep-argument for P2: operators with v2.34 to v2.39 packages dismiss the note; downgrade reason: the next sentence gives the remedy keyed to the exact error string, independent of version). CRF-69 merges Pen Botter P3 and Razor P4 at P3. Gon comment-wording P2s set to Nit, except coder.env:5 which converges with Leorio at P4 (operator confusion about the PG line). Zoro's CRF-76 suggestion to drop "By default" omitted: RLIMIT_NICE can let an unprivileged process lower nice, so the qualifier is accurate. Razor's swagger root cause moved out of scope (CRF-81); the in-PR part is CRF-73.
Reviewed against e6a57f3..04925bd.

Round 3

Fix round (14 files changed since R2, no files added, no exported signature change, title unchanged). Churn guard PROCEED: 15/15 addressed, none contested. Netero (new agent): 2 P4 (CRF-84, CRF-85). Panel: Gon, Leorio, Mafu-san, Mafuuu, Razor, Pen Botter, Bisky, Zoro, Knov (raisers of R2 findings the new commits touched), Ging-Go (Go specialist), Chopper (wildcard); all new agents, no dispute check-in needed.
Cross-check: CRF-87 is the CRF-68 wording follow-up; Mafuuu and Mafu-san judged the R3 wording fixed, Leorio and Razor showed "Older" still takes v2.34.0 as its reference from the preceding sentence; posted at P4 (both raisers' severity) as a new inline finding because the CRF-68 thread is resolved and outdated. Gon's script-comment P2 set to Nit. New: 8 P4, 2 Nit. No P0 to P3.
Reviewed against e6a57f3..f55cb6d.

Round 4

Fix round (9 files changed since R3, no files added, no exported signature change). Churn guard PROCEED: 11/11 addressed, none contested. Netero (new agent): no findings, verified CRF-84 and CRF-85. Panel: Leorio, Mafuuu, Pen Botter, Razor, Gon, Zoro, Knov, Bisky, Chopper (raisers of R3 findings the commits touched), Ging-Go (Go specialist), Meruem (wildcard); all new agents. New: 1 P4 (CRF-95, Leorio and Pen Botter at P4); 2 out of scope.
Reviewed against e6a57f3..8fffb38.

Round 5

Fix round (one docs line changed since R4). Churn guard PROCEED: 1/1 addressed. Netero (new agent): no findings. Panel: Leorio, Pen Botter (raisers of CRF-95), Mafuuu (core, to reach 3), Chopper (wildcard); all new agents, all no findings. No new findings; every in-scope finding is fixed or closed. Posted as COMMENT, not APPROVE: the deep-review CLI posts APPROVE as a real approval (vault: deep-review-post-success-evidence), and the skill intends a comment.
Reviewed against e6a57f3..2ce754e.

Round 6

Fix round (one docs-only commit, c888885, 8 files, from an automated doc-check review). Churn guard PROCEED: no open findings. CRF-55 (process-priority.md emdash, out of scope) fixed by the author. Netero (new agent): no findings. Panel: Pen Botter (docs specialist), Leorio, Razor (docs claims), Kite (wildcard); all new agents. New: 2 P4, 1 out of scope.
Cross-check: CRF-98 merges three reviewers on one table sentence (duplication plus where the message appears). CRF-99: Pen Botter listed it out of scope; Leorio and Kite placed it in scope because this PR rewrote the client verification section (new kubectl command, new fsGroup/defaultMode paragraph at column 0) and the same commit fixed the identical list problem in the server section of the same page. Kept in scope at P4.
Reviewed against e6a57f3..c888885.

Round 7

Fix round (one docs-only commit, 30b2c79, 2 files). Churn guard PROCEED: 2/2 addressed. Netero (new agent): no findings. Panel: Pen Botter, Leorio, Razor, Kite (raisers of CRF-98 and CRF-99), Zoro (wildcard); all new agents, all no findings. 1 out of scope, 1 Note. Posted as COMMENT (APPROVE is not downgraded by the CLI).
Reviewed against e6a57f3..30b2c79.

About deep-review

CRF = Coder Review Finding (P0-P4, Nit, Note)

Reviewer Focus
Bisky tests
Chopper ops/errors
Churn-guard change verification
Ging language modernization
Gon naming
Hisoka edge cases
Killua perf
Kite change integrity
Knov contracts
Knuckle SQL
Komugi flake/determinism
Kurapika security
Law decomposition
Leorio docs
Luffy product
Mafu-san process
Mafuuu contracts
Melody dispatch/pairing
Meruem structural
Nami frontend
Netero mechanical checks
Pariston premise testing
Pen-botter product gaps
Razor verification
Robin duplication
Ryosuke Go arch
Takumi concurrency
Zoro shape

🤖 Managed by Coder Agents.

@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 01:36 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Docs preview

Links open this pull request's preview at https://pr-32158.docs.cdr-preview.dev, which updates with each push.

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

Preview sites for each built commit (8)

Every built commit keeps its own preview, newest first. Previews aren't indexed by search engines and are deleted when this pull request is merged or closed.

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes 106 docs and code conflicts from the docs audit, including five code fixes. Findings: 5 P2, 13 P3, 18 P4, 9 Nit.

The three P2s on the code commits (the agent-exec nice ordering, and the two on the error merge strategy) need a code owner decision; the PR description already offers to split those commits out.

Out of scope (needs a ticket or explicit acceptance by a human):

  • docs/admin/external-auth.md:287, :306, :383, :390, and docs/coder-agents/platform-controls/git-providers.md:23, :66: unanchored provider regex examples; a look-alike host receives the provider token.
  • coderd/provisionerdserver/provisionerdserver.go:2324: every coder_env check in MergeExtraEnvs runs after terraform apply; a template defect found at build time leaves applied infrastructure behind a failed build.
  • coderd/provisionerdserver/provisionerdserver.go:3615: MergeExtraEnvs accepts a pre-filled map, but both callers pass an empty one; the exists branch is reachable only from tests.
  • cli/server.go:453: an empty CODER_HTTP_ADDRESS with TLS off stops the server; any env file or container spec from before v2.34.0 with that line fails at startup.
  • agent/agentexec/cli_linux.go:99: writeOOMScoreAdj runs after dropEffectiveCaps; a negative CODER_PROC_OOM_SCORE below the agent's minimum is likely not applied, while process-priority.md:32 documents -1000 to 1000 (unverified).
  • docs/templates/extending-templates/process-priority.md:17: adding CAP_SYS_NICE through a container security context does not make it effective for a non-root agent, so the nice fix does not apply to that documented setup (unverified).
  • docs/templates/extending-templates/process-priority.md:113: says the agent strips all CODER_PROC_* variables; cli_linux.go:124-126 strips three, so others reach user processes.
  • docs/templates/extending-templates/process-priority.md:31: contains an emdash, which the repository forbids.
  • docs/admin/networking/reverse-proxy-caddy.md:134: the standalone Caddyfile has no tls { on_demand } block or email, so Caddy cannot get a certificate for *.coder.example.com, and the bullets describe an email@example.com value the snippet lacks.
  • helm/provisioner/values.yaml:136: says resources are not set by default, but helm/libcoder/templates/_coder.yaml:88-96 applies 2000m and 4096Mi; the chart comment contradicts the docs this PR fixes.
  • codersdk/deployment.go:3560: the Default Token Lifetime help says it applies when a token is created without a duration, but coder tokens create without --lifetime sends MaxTokenLifetime; lowering the default does not shorten CLI tokens.
  • docs/install/prepare/airgap.md:91: the mirror stores the AWS provider under aws/aws, but its address is hashicorp/aws; Terraform will not find the bundled provider.
  • docs/admin/integrations/devcontainers/envbuilder/add-envbuilder.md:71: the same zip templates.zip Dockerfile main.tf command this PR fixes in template-from-scratch.md; it skips subdirectories.
  • agent/agent.go:81: EnvProcPrioMgmt and EnvProcOOMScore duplicate the agentexec constants and have no references; the copies can drift.
  • agent/agentexec/cli_linux_test.go:86: the Capabilities subtest's fixed caps directory fails under -count=2.
  • agent/agentexec/cli_linux_test.go:83: Capabilities passes even when the file capability has no effect, so it does not prove dumpable handling in user-namespaced environments.
  • agent/agentexec/cli_linux.go:101: the OOM score copy of the warning comment has the typo "inappriopriate".
  • docs/coder-agents/index.md:281 and docs/coder-agents/architecture.md:194: the read_skill availability rule is stated on both pages; the next change must find both.
  • cli/clilog/clilog.go:153: the error names /dev/null as the remedy but not the empty value that logs.md now documents.

Notes:

  • coderd/provisionerdserver/mergeenvs_internal_test.go:12: TestEncodeSubagentEnvsErrorStrategy repeats three TestMergeExtraEnvs cases; one case is enough to show the subagent path calls MergeExtraEnvs.
  • coder.env:5: commenting out the three CODER_TLS_* lines changes no behavior, because empty values equal their defaults; only CODER_HTTP_ADDRESS caused the startup failure, though the PR table row implies all four lines did.

docs/workspaces/speed-up-templates.md:83

P4 [CRF-17] The new text says to set coder.resources in the values file, but the block still ends with a … line, so pasting it into a values file breaks YAML parsing. (Pen Botter)

yaml.safe_load on the block fails with while scanning a simple key. Remove the trailing … line.

🤖

docs/install/server/rpm.md:85

P3 [CRF-47] The page says coder.service does not start while coder.env is empty, but after this PR an untouched install starts and listens on 127.0.0.1:3000. (Pen Botter)

ConditionFileNotEmpty checks the file size and the packaged file is never empty; before this PR the empty CODER_HTTP_ADDRESS= line made the server exit, so the sentence used to match the outcome. Rewrite it to say the service starts with the packaged defaults, and that the configuration should be set before starting it.

🤖

🤖 This review was automatically generated with Coder Agents.

Comment thread cli/clilog/clilog.go Resolved
Comment thread agent/agentexec/cli_linux_test.go Resolved
Comment thread agent/agentexec/cli_linux_test.go Resolved
Comment thread cli/agent.go Resolved
Comment thread cli/agent.go
logger.Info(ctx, "process priority management enabled",
slog.F("env_var", agentexec.EnvProcPrioMgmt),
slog.F("enabled", enabled),
slog.F("enabled", value),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit [CRF-5] The log field enabled holds the raw environment value, so an empty variable logs process priority management enabled enabled="". (Netero)

Name the field value, or log the bool.

🤖

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changed. The enabled field name predates this PR, and a rename could break existing log queries. Left open for the code owner.

Posted by Coder Agents on behalf of @nickvigilante.

Comment thread agent/agentexec/cli_linux_test.go Resolved
Comment thread codersdk/deployment_test.go Resolved
Comment thread codersdk/deployment_test.go Resolved
Comment thread codersdk/deployment_test.go Resolved
This reverts commit 76ec1ac.

The wrapper drops its effective capabilities first on purpose, so that
a caller cannot use the capabilities of the agent binary. With the
nice value applied first, any local process could run
`coder agent-exec --coder-nice=-20` against a binary that has the
CAP_SYS_NICE file capability and outrank the agent. Keep the original
order and correct the docs instead.

Refs DOCS-1687
This reverts commit dff8e7c.

The change makes template versions that pair an "error" coder_env with
a later entry for the same name fail every workspace build, after
terraform apply has run. That is a breaking change that needs its own
pull request and release note. Describe the current behavior in the
docs instead.

Refs DOCS-1669
The packaged coder.env now ships CODER_HTTP_ADDRESS= as a comment, so
the sed command in the two Lima examples no longer produced an active
line. The command now rewrites the line whether or not it is commented.

Upgrades keep an existing /etc/coder.d/coder.env, so a file from a
package before this change still has the empty line. Since v2.34.0 an
empty value replaces the default, and with TLS off the server exits with
"TLS is disabled. Enable with --tls-enable or specify a HTTP address".
The RPM page, the upgrade page, and the 2.29 to 2.34 ESR upgrade page
now name the error and the fix. coder.env carries a comment with the
same warning.

The test now reads the file with godotenv and compares every option that
the file sets against the built-in defaults, so a new empty line for any
option fails it.

Refs DOCS-1587
The earlier change on this branch tracked whether a sink option was
given, so that only an explicitly disabled sink skipped the "no loggers
provided" error. That state is not needed. The error is removed, and a
command with every log location empty or /dev/null runs with no log
output.

This reverses behavior that the docs described before: "An empty string
does not disable logging". Since v2.34.0 an empty environment variable
counts as set, so CODER_LOGGING_HUMAN= in an env file stopped the server
with that error. It now starts a server that writes no logs.

Refs DOCS-1652
The --experiments description said '*' opts in to all available
experiments. ReadExperiments expands '*' to codersdk.ExperimentsSafe, so
the description now says it opts in to the experiments marked safe. The
provisioner daemon flag has the same text and calls the same function.

The default quiet hours schedule description said the max deadline is
the start of the user's next quiet hours window. CalculateAutostop uses
the window on the next day that the template's autostop requirement
applies, which can be days later.

Regenerates the CLI reference, the configuration reference, and the
golden files.

Refs DOCS-1664
- environment-variables.md: describe the error merge strategy as the
  code applies it. The check runs only when the error resource is
  processed, and resources are processed in address order.
- process-priority.md: a nice value below the agent's own is not
  applied, because the exec wrapper drops capabilities before it sets
  the nice value. Remove the CAP_SYS_NICE instructions. Name the three
  variables that the agent strips.
- external-auth.md: anchor the GitHub Enterprise regex example so it
  does not match look-alike hosts.
- port-forwarding.md: name the CORS Behavior setting, say it applies to
  every app and port, and restore the note that Simple strips the
  application's CORS headers.
- change-management.md: use a token lifetime that the Owner role allows.
- reference/index.md: the keep-alive script no longer shortens a later
  deadline, and curl now fails on HTTP errors.
- agent-metadata.md: say what load remains after batching.
- refresh-tokens.md: match the error detail that is specific to an
  expired OIDC session.
- form-types.md: add the switch form type.
- database-encryption.md: state the fields that the dbcrypt commands
  skip once, and link to the list.
- speed-up-templates.md: remove a stray line from the YAML example.

Refs DOCS-1669, DOCS-1687
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 02:30 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 02:30 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 02:33 — with GitHub Actions Inactive
@nickvigilante

Copy link
Copy Markdown
Collaborator Author

Response to the coder-agents-review review of 8853332. Each thread has a reply with the commit that resolves it.

  • Reverted: the nice value ordering change (b070cfc) and the error merge strategy change (e6f9b50). The docs now describe what the code does, and DOCS-1669 and DOCS-1687 stay open for the owners.
  • Findings in the review body: the stray … line in the speed-up-templates.md YAML example is removed (04925bd), and the RPM page no longer says the service fails with an untouched coder.env (bf047a4).
  • Left open for the code owner: three threads on cli/agent.go (shared helper for the priority decision, the enabled log field name, and the "linux-only" log message).
  • Out-of-scope list: not changed. Those items are in code and docs that this PR does not touch.

The PR description is updated to match.

Posted by Coder Agents on behalf of @nickvigilante.

@nickvigilante

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This round reviews the reverts of the agentexec and MergeExtraEnvs code fixes and the fixes for the round 1 findings. New findings: 4 P3, 7 P4, 3 Nit; one P4 is re-raised on its existing thread.

All round 1 findings are fixed except the four the author contested. The reviewers that raised them accept the defenses for the enabled log field name, the "(linux-only)" log message, and the commit subject. For the duplicated process priority check, the helper refactor is accepted as out of scope, and the comment on the line this PR adds is re-raised on that thread.

Out of scope (needs a ticket or explicit acceptance by a human):

  • coderd/experiments.go:43: the swagger annotation for GET /api/v2/experiments/available declares an array of codersdk.Experiment, but the handler returns {"safe": [...]}; the generated API reference and swagger clients are wrong for this endpoint.
  • site/src/pages/DeploymentSettingsPage/OverviewPage/OverviewPageView.stories.tsx:33: three story fixtures keep the old --experiments description, so Storybook shows the text this PR corrects.
  • cli/agent.go:268: the agent CLI and agentexec.NewExecer (agent/agentexec/exec.go:47-48) each compute the process priority decision; if one changes alone, the log reports the wrong state.

🤖 This review was automatically generated with Coder Agents.

Comment thread coder.env Resolved
Comment thread docs/install/operate/upgrade.md Resolved
Comment thread docs/install/server/rpm.md Resolved
Comment thread docs/install/server/rpm.md Resolved
Comment thread codersdk/deployment_test.go Resolved
Comment thread cli/clilog/clilog.go Resolved
Comment thread cli/clilog/clilog.go Resolved
Comment thread codersdk/deployment_test.go Resolved
The previous commit removed the "no loggers provided" error, so an empty
log location turned logging off. An empty location is more likely a
mistake, such as CODER_LOGGING_HUMAN= in an env file, and a server that
starts with no logs hides it.

The error is back for the case with no sinks, unless a log location is
/dev/null. That is the documented way to disable logging, and it failed
before when no other sink was set.

logs.md again says that an empty value does not disable logging, and
names the error.

Refs DOCS-1652
@nickvigilante

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 03:27 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 03:30 — with GitHub Actions Inactive

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This round reviews the fix for the round 4 finding: the logging note now names --trace (CODER_TRACE_ENABLE), which matches cli/clilog/clilog.go, and the link anchor resolves. No new findings, and every finding from earlier rounds is fixed or closed.

The out-of-scope items listed in earlier rounds still need a ticket or explicit acceptance by a human, and the PR description leaves the empty CODER_LOGGING_HUMAN behavior and the code fix commits to the code owners.

🤖 This review was automatically generated with Coder Agents.

@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 03:33 — with GitHub Actions Inactive
Comment thread docs/workspaces/workspace-scheduling.md Resolved
Comment thread docs/admin/monitoring/logs.md Resolved
Comment thread docs/coder-agents/architecture.md Resolved
Comment thread docs/install/server/postgres-ssl.md Resolved
Comment thread docs/templates/creating-templates.md Resolved
- Use "refer to" for cross-references and "visit" for the external
  issue link, in place of "see", on the lines this branch added.
- creating-templates.md: write the button label as the dashboard shows
  it, "New template".
- postgres-ssl.md: split the first server verification step into one
  instruction per step, put each condition first, and indent the code
  blocks under their steps so the list numbers continue.
- process-priority.md: state the outcome for CAP_SYS_NICE first, and
  say that a nice value that is not applied is reported on stderr while
  the command still runs. The table formatter rewrites the whole table,
  so the dashes in the first row are replaced.
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 20:29 — with GitHub Actions Inactive
@nickvigilante

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 20:30 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 20:33 — with GitHub Actions Inactive

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This round reviews the doc-check follow-up commit (c888885970): "refer to" wording, the New template label, the postgres-ssl.md server verification steps, and the process-priority.md table. The label and the claims match the code. New findings: 2 P4.

Out of scope (needs a ticket or explicit acceptance by a human):

  • docs/install/prepare/airgap.md:232, docs/get-started/index.md:218, and docs/admin/integrations/devcontainers/envbuilder/add-envbuilder.md:21: still say New Template, while the dashboard button (site/src/pages/TemplatesPage/TemplatesPageView.tsx:326) and creating-templates.md now say New template.

🤖 This review was automatically generated with Coder Agents.

Comment thread docs/install/server/postgres-ssl.md Resolved
- process-priority.md: the failed to adjust niceness message is written
  to the stderr of the command with a coder-agent: prefix, not to the
  agent log. The troubleshooting entry says so, and the table row links
  to it in place of repeating it.
- postgres-ssl.md: indent the code blocks and the paragraph in the
  client verification section under their steps, so the steps render as
  one numbered list.
@nickvigilante

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 20:40 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 20:43 — with GitHub Actions Inactive

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This round reviews 30b2c79a47, which fixes the two round 6 findings: the process-priority.md table now links to the troubleshooting entry, which says the niceness message goes to the command's stderr with the coder-agent: prefix, and the postgres-ssl.md client verification steps render as one numbered list. No new findings, and every finding from earlier rounds is fixed or closed.

Out of scope (needs a ticket or explicit acceptance by a human):

  • docs/templates/extending-templates/process-priority.md:87: the OOM score troubleshooting entry still says failed to adjust oom score appears "in stderr", without the coder-agent: prefix or the note that it is not in the agent log, so a reader who searches the agent log does not find it.

Notes:

  • docs/templates/extending-templates/process-priority.md:93: for devcontainer up and devcontainer exec, the agent captures the command's stderr and logs non-JSON lines at debug level (agent/agentcontainers/devcontainercli.go:444), so the niceness message for those commands is in the agent log, not the command output.

🤖 This review was automatically generated with Coder Agents.

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing one fix about AI Gateway fix. This is a nice collection of small changes to improve the QoL of our overall site. All LGTM :)

- spend-management.md: keep the v2.37 removal note in the callout, and
  move the cost export steps to their own numbered section.
- Replace the budget flag details with a link to the AI Governance cost
  control page, which already covers them.

Generated with Coder Agents.
@bpmct
bpmct temporarily deployed to main November 13, 2026 21:11 — with GitHub Actions Inactive
The message goes to the stderr of the command. For most commands that
is the command's own output, but the agent captures the stderr of the
devcontainer CLI and logs it at debug level, so "not to the agent log"
was too strong.
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 21:12 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 21:13 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 21:16 — with GitHub Actions Inactive
@nickvigilante
nickvigilante enabled auto-merge (squash) November 13, 2026 21:33
@nickvigilante
nickvigilante merged commit 1baff57 into main Nov 13, 2026
39 checks passed
@nickvigilante
nickvigilante deleted the docs/audit-conflict-fixes branch November 13, 2026 21:35
@nickvigilante
nickvigilante temporarily deployed to docs-preview November 13, 2026 21:35 — with GitHub Actions Inactive
@nickvigilante
nickvigilante temporarily deployed to main November 13, 2026 21:35 — with GitHub Actions Inactive
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2026

This branch was previously deployed

2 inactive deployments
main — 2a6035ce Deployed Nov 13, 2026 by nickvigilante via cla #257028
docs-preview — 2a6035ce Deployed Nov 13, 2026 by nickvigilante via cleanup #62
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants