Skip to content

ci: run linkspector on pull requests to release branches - #32131

Merged
nickvigilante merged 1 commit into
mainfrom
vigilante/linkspector-release-branches
Nov 18, 2026
Merged

nickvigilante merged 1 commit into
mainfrom
vigilante/linkspector-release-branches

Conversation

@nickvigilante

Copy link
Copy Markdown
Collaborator

The docs link check (Linkspector, in weekly-docs.yaml) only runs on pull requests to main, and its weekly scheduled run only checks main. Pull requests to release/** never get it. That let #31796, a backport to release/2.39, merge with a link to admin/workspaces/devcontainers/customizing-dev-containers.md, main's layout for that page; on 2.39 the page is still under user-guides/devcontainers/. No check flagged it, and the docs publish has refused to build 2.39 since 2026-11-09 because of it.

This adds release/** to the pull_request branches, so the same check runs on backports. On pull requests Linkspector only checks the Markdown files the PR changes (filter_mode: file), so a backport pays only for its own files. The Slack notification still fires only for the scheduled run.

A pull request runs the workflow from the branch it targets, so this only takes effect on a release branch once it's backported there. It should be cherry-picked to each release branch that still takes docs backports (at least 2.39, 2.38 and 2.37).

actionlint reports the workflow clean.


🤖 Built with AI assistance.

The docs link check only ran on pull requests to main, and its weekly
run only checks main. A backport to release/2.39 brought over a link to
main's docs layout that doesn't exist on 2.39; no check saw it, and the
docs publish has refused to build 2.39 since. Running the same check on
pull requests to release/** catches that before merge.

Pull requests use the workflow from the branch they target, so this has
to be backported to each supported release branch to take effect there.

Assisted-by: AI
@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

DOCS-1746

@ianjevans ianjevans left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nickvigilante
nickvigilante enabled auto-merge (squash) November 17, 2026 18:06

@Lisa-Fiander Lisa-Fiander left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvigilante
nickvigilante merged commit 3db7a3e into main Nov 18, 2026
57 checks passed
@nickvigilante
nickvigilante deleted the vigilante/linkspector-release-branches branch November 18, 2026 14:58
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2026

This branch had an error being deployed

1 failed and 1 inactive deployments
main — 7371d78b Deployed Nov 18, 2026 by nickvigilante via cla #259595
docs-preview — 7371d78b Deployed Nov 18, 2026 by nickvigilante via cleanup #210
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants