Repository navigation
ci: deploy docs previews to the preview target only - #32126
Draft
nickvigilante wants to merge 1 commit into
Draft
nickvigilante wants to merge 1 commit into
nickvigilante wants to merge 1 commit into
Conversation
Vercel makes a project's first deployment production. When closing a PR deleted the last deployments in the preview project, the next PR's deploy became that project's production deployment, aliased at coder-docs-pr-preview-prod. The deploy now passes --target=preview, so a PR preview is never promoted, and a test fails if the deploy loses the flag or anything deploys to production. Assisted-by: AI
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs PR previews (#30698) could become the preview project's production deployment. Vercel makes a project's first deployment production, and closing #32098 had just deleted the last deployments in
coder-docs-pr-preview, so the next deploy, for #31992, was assigned to production and aliased atcoder-docs-pr-preview-prod.docs.cdr-preview.dev. The CLI said so: "This is your project's first deployment, so it was assigned to production." #31992's ownpr-31992aliases were set as usual.This passes
--target=previewtovercel deploy, so a PR preview is never production regardless of what's in the project.test-docs-preview-mapper.shgains a check that the single deploy command carries--target=previewand that nothing in the workflow deploys with--prodor--target=production; it fails againstmain's workflow and passes with this change.The existing production deployment (
dpl_Di1vwonwpGZbfvveixmRRQgRYezP, serving #31992's content) carries noprtag, so the cleanup workflow won't find it. It should be deleted by hand in thecoder-docs-pr-previewproject once #31992 closes; deleting it sooner would take #31992's preview down with it.Testing
All mapper tests pass with GNU coreutils, sed, grep and awk on macOS, including the new one; it fails against
main's workflow.actionlintand ShellCheck report nothing.🤖 Built with AI assistance.