Skip to content

ci(.github/workflows): don't fail doc-check when the review outlives the wait - #32097

Merged
bpmct merged 1 commit into
mainfrom
ben/doc-check-timeout-not-red
Nov 12, 2026
Merged

bpmct merged 1 commit into
mainfrom
ben/doc-check-timeout-not-red

Conversation

@bpmct

@bpmct bpmct commented Nov 12, 2026

Copy link
Copy Markdown
Member

The doc-check chat keeps running in Coder after the job stops waiting at 40 minutes, and it posts its own comment when it is done. When the local model is busy, reviews run past the wait and the check goes red even though nothing failed. 33 of 46 doc-check runs today ended red this way, including on #32088, #31788, #31621 and #31620.

Changes

  • continue-on-error on the agents-chat-action step.
  • New step that ends with a notice when the wait timed out and the chat is still running or pending, and fails the job for every other error.

Generated by Coder Agents on behalf of @bpmct.

…the wait

The doc-check chat keeps running in Coder after the job stops waiting and
posts its own comment. A wait timeout turned the check red on PRs where the
review was fine. Report it as a notice instead, and keep failing the job for
every other error.

Coder Agents generated.
@bpmct
bpmct temporarily deployed to main November 12, 2026 16:41 — with GitHub Actions Inactive
@bpmct
bpmct temporarily deployed to main November 12, 2026 16:41 — with GitHub Actions Inactive
@bpmct
bpmct merged commit e49fe29 into main Nov 12, 2026
51 checks passed
@bpmct
bpmct deleted the ben/doc-check-timeout-not-red branch November 12, 2026 17:28
@bpmct
bpmct temporarily deployed to main November 12, 2026 17:28 — with GitHub Actions Inactive
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026

This branch was previously deployed

1 inactive deployment
main — 93264a87 Deployed Nov 12, 2026 by bpmct via cla #255118
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants