Repository navigation
fix(site): stop using browser APIs newer than the browserslist floor - #31950
ethanndickson wants to merge 3 commits into
Conversation
f1c57cf to
c8c59cf
Compare
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ba200e5 to
124c8c3
Compare
124c8c3 to
a0f52aa
Compare
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Chat: Review in progress (0/1 reviewers complete) | View chat deep-review v0.13.0 | Round 1 | Status: Netero (first pass) About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
a0f52aa to
8beaec5
Compare
Relates to CODAGT-1455
Codex caught a
URL.parsecall in #31949, and it turns out we'd already shipped one onmainin #31603.URL.parseneeds Chrome 126 and Safari 18, but ourbrowserslistfloor is Chrome 111, Firefox 128 and Safari 16.4 (#28769), and Vite doesn't polyfill it, so on an older browser the call just throws.URL.canParseinapps.tsandObject.groupByinRoleSelector.tsxhave the same problem. I've stacked this on #31949 so that PR stays as it was reviewed.To fix, we'll add a
parseURLhelper toutils/uri.tsthat returnsundefinedinstead of throwing, use it in place ofURL.parseandURL.canParse, and replaceObject.groupBywith twofiltercalls.So this doesn't happen a third time, I've also added a
no-restricted-propertiesrule to.oxlintrc.jsoncthat bans 12 static APIs newer than the floor, each with a message pointing at what to use instead. Tests ande2e/are exempt, as they run in Node. The list is written by hand, so it won't catch instance methods likeSet.prototype.unionor new globals.eslint-plugin-compatwould readbrowserslistdirectly, but it'd need a new dependency and oxlint's experimental JS plugin support, which I think is out of scope here.I've tested this by hand on Chrome 116, which has none of these APIs. Without this PR, the Coder Agents add-panel menu, the workspace page, the edit roles dialog and the inbox all crash with "Something went wrong", and with it they all work. Chrome 157 behaves the same as before.