Skip to content

fix(site): stop using browser APIs newer than the browserslist floor - #31950

Open
ethanndickson wants to merge 3 commits into
ethan/codagt-1455-blocked-app-viewfrom
ethan/codagt-1455-url-compat
Open

ethanndickson wants to merge 3 commits into
ethan/codagt-1455-blocked-app-viewfrom
ethan/codagt-1455-url-compat

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Relates to CODAGT-1455

Codex caught a URL.parse call in #31949, and it turns out we'd already shipped one on main in #31603. URL.parse needs Chrome 126 and Safari 18, but our browserslist floor is Chrome 111, Firefox 128 and Safari 16.4 (#28769), and Vite doesn't polyfill it, so on an older browser the call just throws. URL.canParse in apps.ts and Object.groupBy in RoleSelector.tsx have the same problem. I've stacked this on #31949 so that PR stays as it was reviewed.

To fix, we'll add a parseURL helper to utils/uri.ts that returns undefined instead of throwing, use it in place of URL.parse and URL.canParse, and replace Object.groupBy with two filter calls.

So this doesn't happen a third time, I've also added a no-restricted-properties rule to .oxlintrc.jsonc that bans 12 static APIs newer than the floor, each with a message pointing at what to use instead. Tests and e2e/ are exempt, as they run in Node. The list is written by hand, so it won't catch instance methods like Set.prototype.union or new globals. eslint-plugin-compat would read browserslist directly, but it'd need a new dependency and oxlint's experimental JS plugin support, which I think is out of scope here.

I've tested this by hand on Chrome 116, which has none of these APIs. Without this PR, the Coder Agents add-panel menu, the workspace page, the edit roles dialog and the inbox all crash with "Something went wrong", and with it they all work. Chrome 157 behaves the same as before.

@linear-code

linear-code Bot commented Nov 10, 2026

Copy link
Copy Markdown

CODAGT-1455

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T05:47:55.230896Z a0f52aa Manual request
🔒 Security Review ✅ Completed 2026-11-12T05:49:12.575753Z a0f52aa Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: c8c59cf8f6

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: c8c59cf8f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson force-pushed the ethan/codagt-1455-url-compat branch from ba200e5 to 124c8c3 Compare November 10, 2026 13:49
@ethanndickson
ethanndickson removed this pull request from stack #31951 November 10, 2026 13:49
@ethanndickson
ethanndickson force-pushed the ethan/codagt-1455-url-compat branch from 124c8c3 to a0f52aa Compare November 12, 2026 04:13
@ethanndickson
ethanndickson marked this pull request as ready for review November 12, 2026 05:45
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: a0f52aaf7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: a0f52aaf7f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@coder-agents-review

coder-agents-review Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Chat: Review in progress (0/1 reviewers complete) | View chat
Requested: 2026-11-12 05:51 UTC by @ethanndickson
Spend: $0.71 / $100.00

deep-review v0.13.0 | Round 1 | 71ac834..a0f52aa

Status: Netero (first pass)

About deep-review

CRF = Coder Review Finding (P0-P4, Nit, Note)

Reviewer Focus
Bisky tests
Chopper ops/errors
Churn-guard change verification
Ging language modernization
Gon naming
Hisoka edge cases
Killua perf
Kite change integrity
Knov contracts
Knuckle SQL
Komugi flake/determinism
Kurapika security
Law decomposition
Leorio docs
Luffy product
Mafu-san process
Mafuuu contracts
Melody dispatch/pairing
Meruem structural
Nami frontend
Netero mechanical checks
Pariston premise testing
Pen-botter product gaps
Razor verification
Robin duplication
Ryosuke Go arch
Takumi concurrency
Zoro shape

🤖 Managed by Coder Agents.

@ethanndickson
ethanndickson force-pushed the ethan/codagt-1455-url-compat branch from a0f52aa to 8beaec5 Compare November 12, 2026 12:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant