Skip to content

fix(site/src/components/Filter/FilterCombobox): mute icon-less filter options and space flyouts 4px from the menu - #31814

Merged
tracyjohnsonux merged 1 commit into
mainfrom
des-22264-filter-menu-fixes
Nov 6, 2026
Merged

tracyjohnsonux merged 1 commit into
mainfrom
des-22264-filter-menu-fixes

Conversation

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator

Fixes DES-22264

Two fixes for the filter menu on /workspaces:

  • Muted option text. Options without an icon ("Workspace is..." Outdated, Dormant) always rendered in content-primary. They now use content-secondary until hovered, highlighted, or selected, like the status options.
  • 4px flyout gap. Owner/Template/Organization flyouts now sit 4px from the main menu (sideOffset={4}). The gap made the flyout close while the pointer crossed it, because the wrapper's onMouseLeave fired. Invisible 4px strips on both sides of the wrapper bridge the gap, so the flyout stays open whether it opens right or left.

The hover focus ring is out of scope; #30682 handles it.

Generated by Coder Agents on behalf of @tracyjohnsonux.

@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

DES-22264

@jakehwll jakehwll left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine with this but I am wondering why we're moving away from the established pattern in other dropdown submenus in regards to spacing?

<FilterCombobox /> <DropdownMenu /> → <Sub />
Image Image

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator Author

@jakehwll expect a few more PRs to correct those as well

@tracyjohnsonux
tracyjohnsonux merged commit 98261f8 into main Nov 6, 2026
84 of 89 checks passed
@tracyjohnsonux
tracyjohnsonux deleted the des-22264-filter-menu-fixes branch November 6, 2026 01:30
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants