Repository navigation
fix(site/src/components/Filter/FilterCombobox): mute icon-less filter options and space flyouts 4px from the menu - #31814
Merged
Conversation
… options and space flyouts 4px from the menu
Collaborator
Author
|
@jakehwll expect a few more PRs to correct those as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes DES-22264
Two fixes for the filter menu on
/workspaces:content-primary. They now usecontent-secondaryuntil hovered, highlighted, or selected, like the status options.sideOffset={4}). The gap made the flyout close while the pointer crossed it, because the wrapper'sonMouseLeavefired. Invisible 4px strips on both sides of the wrapper bridge the gap, so the flyout stays open whether it opens right or left.The hover focus ring is out of scope; #30682 handles it.