Repository navigation
feat: send a message after the current turn from the chat input - #31774
ethanndickson merged 6 commits into
Conversation
84017fe to
a30e3b1
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a30e3b1837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review re: Respect after-turn scheduling for built-in commands Valid, but this already happens on main: a plain send of /compact or /clear to a busy chat runs the command at once and gets the same 409. This PR only adds a second way to reach it. Making /compact follow steer and after-turn delivery needs server work: chatd has to hold the compaction and run it before the next model call or when the turn ends. We track that as a follow-up in CODAGT-1536. /clear stays rejected while the chat is busy. Accepted as a known limitation for this PR. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2cf6bd7 to
291c567
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 291c567e5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
291c567 to
d16f7c8
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d16f7c82c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a588ff6d94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The busy send tooltip showed only "Send" and "After turn". It now shows "Send during turn" and "Send after turn", so it says that a plain send reaches the agent during the current turn and the shortcut holds the message until the turn ends. The send menu uses the same labels.
AgentChatInput.tsx was over 2000 lines, and AgentChatSendMenu.tsx only exported the send button, so the button and its menu now live in AgentChatSendButton.tsx. The single-use shortcut hint helper is inlined, and canSendAfterTurn becomes offersSendAfterTurn because it stays true with an empty draft. A new test checks that Escape closes the send menu and returns focus to Send. The stories wire the modifier preference inline, and comments that restated the code are trimmed.
While the agent works, the send button's tooltip says "Send during turn", but screen readers read the button as "Send". The screen-reader text now uses the tooltip label, so both say "Send during turn" while the agent works and "Send" otherwise.
05e57a6 to
5152307
Compare
mafredri
left a comment
There was a problem hiding this comment.
This change looks reasonable to me, I'd still recommend having someone from the FE team look through this.
There was a problem hiding this comment.
This seemed like a lot of added code with not much contrasting deleted code, but I guess the send button wasn't that complex before.
| asChild | ||
| disabled | ||
| type={undefined} | ||
| // biome-ignore lint/a11y/useValidAriaValues: undefined removes the Radix default. |
There was a problem hiding this comment.
I'd question this lint ignore, agent's love to add them but often the approach is wrong. Not too familiar with this to make a more informed comment on it though.
Since #31174 made steer the default, there's been no way to send a queue message from the site, i.e. one that waits for the current turn to end. This adds that back in two ways.
Whilst the agent is working, Cmd/Ctrl+Enter now sends the message under "After turn" (
busy_behavior: "queue"), and Enter still steers. If you've turned on "Require Cmd/Ctrl+Enter to send agent messages", or you're on a touch device where Enter is a newline, Cmd/Ctrl+Enter already sends, so Option/Alt+Enter sends after the turn instead. The send button tooltip lists both shortcuts, as "Send during turn" and "Send after turn".A shortcut isn't very discoverable, and there isn't one on a phone, so right-clicking the send button, or long pressing it on a touch screen, opens a small menu with "Send during turn" and "Send after turn". The menu only opens whilst the agent is busy and there's something to send, as otherwise there's no turn to wait for. Editing a sent message doesn't get the option either, since an edit has no lane to pick.
The docs now describe both.
Part of CODAGT-1140